diff options
author | ulfvonbelow <strilen@tilde.club> | 2023-01-29 06:46:57 -0600 |
---|---|---|
committer | Martin Schanzenbach <schanzen@gnunet.org> | 2023-02-06 14:00:27 +0900 |
commit | 207d866701897c9f0bf6341561e8f2194eec2b49 (patch) | |
tree | 7b05b92c0e173ddd0b5638d30873407a26496534 | |
parent | f7a3ef7b46311a01d5934a52b2fc0962f833a73f (diff) | |
download | gnunet-207d866701897c9f0bf6341561e8f2194eec2b49.tar.gz gnunet-207d866701897c9f0bf6341561e8f2194eec2b49.zip |
-NAMESTORE: fix memory leaks in tests.
This allows us to use sanitizers to find bugs that matter.
Signed-off-by: Martin Schanzenbach <schanzen@gnunet.org>
17 files changed, 19 insertions, 0 deletions
diff --git a/src/namestore/perf_namestore_api_import.c b/src/namestore/perf_namestore_api_import.c index cde5eaad5..b4f17f742 100644 --- a/src/namestore/perf_namestore_api_import.c +++ b/src/namestore/perf_namestore_api_import.c | |||
@@ -397,6 +397,7 @@ main (int argc, | |||
397 | } | 397 | } |
398 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 398 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
399 | "GNUNET_TEST_HOME"); | 399 | "GNUNET_TEST_HOME"); |
400 | GNUNET_free (plugin_name); | ||
400 | GNUNET_free (cfg_name); | 401 | GNUNET_free (cfg_name); |
401 | return res; | 402 | return res; |
402 | } | 403 | } |
diff --git a/src/namestore/perf_namestore_api_zone_iteration.c b/src/namestore/perf_namestore_api_zone_iteration.c index 0e0b6d93b..bf89d6225 100644 --- a/src/namestore/perf_namestore_api_zone_iteration.c +++ b/src/namestore/perf_namestore_api_zone_iteration.c | |||
@@ -369,6 +369,7 @@ main (int argc, | |||
369 | } | 369 | } |
370 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 370 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
371 | "GNUNET_TEST_HOME"); | 371 | "GNUNET_TEST_HOME"); |
372 | GNUNET_free (plugin_name); | ||
372 | GNUNET_free (cfg_name); | 373 | GNUNET_free (cfg_name); |
373 | return res; | 374 | return res; |
374 | } | 375 | } |
diff --git a/src/namestore/test_common.c b/src/namestore/test_common.c index e35c76075..60749a0b1 100644 --- a/src/namestore/test_common.c +++ b/src/namestore/test_common.c | |||
@@ -102,6 +102,7 @@ TNC_test_plugin (const char *cfg_name) | |||
102 | GNUNET_asprintf (&cfg_name, file_template, plugin_name); \ | 102 | GNUNET_asprintf (&cfg_name, file_template, plugin_name); \ |
103 | if (! TNC_test_plugin (cfg_name)) \ | 103 | if (! TNC_test_plugin (cfg_name)) \ |
104 | { \ | 104 | { \ |
105 | GNUNET_free (plugin_name); \ | ||
105 | GNUNET_free (cfg_name); \ | 106 | GNUNET_free (cfg_name); \ |
106 | return 77; \ | 107 | return 77; \ |
107 | } \ | 108 | } \ |
@@ -119,6 +120,7 @@ TNC_test_plugin (const char *cfg_name) | |||
119 | GNUNET_asprintf (&cfg_name, "test_namestore_api_%s.conf", plugin_name); \ | 120 | GNUNET_asprintf (&cfg_name, "test_namestore_api_%s.conf", plugin_name); \ |
120 | if (! TNC_test_plugin (cfg_name)) \ | 121 | if (! TNC_test_plugin (cfg_name)) \ |
121 | { \ | 122 | { \ |
123 | GNUNET_free (plugin_name); \ | ||
122 | GNUNET_free (cfg_name); \ | 124 | GNUNET_free (cfg_name); \ |
123 | return 77; \ | 125 | return 77; \ |
124 | } \ | 126 | } \ |
diff --git a/src/namestore/test_namestore_api_edit_records.c b/src/namestore/test_namestore_api_edit_records.c index fb588f0e1..fbee57432 100644 --- a/src/namestore/test_namestore_api_edit_records.c +++ b/src/namestore/test_namestore_api_edit_records.c | |||
@@ -390,6 +390,7 @@ main (int argc, char *argv[]) | |||
390 | } | 390 | } |
391 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 391 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
392 | "GNUNET_TEST_HOME"); | 392 | "GNUNET_TEST_HOME"); |
393 | GNUNET_free (plugin_name); | ||
393 | GNUNET_free (cfg_name); | 394 | GNUNET_free (cfg_name); |
394 | return res; | 395 | return res; |
395 | } | 396 | } |
diff --git a/src/namestore/test_namestore_api_lookup_nick.c b/src/namestore/test_namestore_api_lookup_nick.c index 8fa001196..b26674a95 100644 --- a/src/namestore/test_namestore_api_lookup_nick.c +++ b/src/namestore/test_namestore_api_lookup_nick.c | |||
@@ -338,6 +338,7 @@ main (int argc, char *argv[]) | |||
338 | } | 338 | } |
339 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 339 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
340 | "GNUNET_TEST_HOME"); | 340 | "GNUNET_TEST_HOME"); |
341 | GNUNET_free (plugin_name); | ||
341 | GNUNET_free (cfg_name); | 342 | GNUNET_free (cfg_name); |
342 | return res; | 343 | return res; |
343 | } | 344 | } |
diff --git a/src/namestore/test_namestore_api_monitoring.c b/src/namestore/test_namestore_api_monitoring.c index b129c2996..271f4c40b 100644 --- a/src/namestore/test_namestore_api_monitoring.c +++ b/src/namestore/test_namestore_api_monitoring.c | |||
@@ -369,6 +369,7 @@ main (int argc, | |||
369 | } | 369 | } |
370 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 370 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
371 | "GNUNET_TEST_HOME"); | 371 | "GNUNET_TEST_HOME"); |
372 | GNUNET_free (plugin_name); | ||
372 | GNUNET_free (cfg_name); | 373 | GNUNET_free (cfg_name); |
373 | return res; | 374 | return res; |
374 | } | 375 | } |
diff --git a/src/namestore/test_namestore_api_monitoring_existing.c b/src/namestore/test_namestore_api_monitoring_existing.c index bc03de541..87476b309 100644 --- a/src/namestore/test_namestore_api_monitoring_existing.c +++ b/src/namestore/test_namestore_api_monitoring_existing.c | |||
@@ -384,6 +384,7 @@ main (int argc, | |||
384 | } | 384 | } |
385 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 385 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
386 | "GNUNET_TEST_HOME"); | 386 | "GNUNET_TEST_HOME"); |
387 | GNUNET_free (plugin_name); | ||
387 | GNUNET_free (cfg_name); | 388 | GNUNET_free (cfg_name); |
388 | return res; | 389 | return res; |
389 | } | 390 | } |
diff --git a/src/namestore/test_namestore_api_remove.c b/src/namestore/test_namestore_api_remove.c index 5aab2ebe6..9c00cdfad 100644 --- a/src/namestore/test_namestore_api_remove.c +++ b/src/namestore/test_namestore_api_remove.c | |||
@@ -210,6 +210,7 @@ main (int argc, char *argv[]) | |||
210 | } | 210 | } |
211 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 211 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
212 | "GNUNET_TEST_HOME"); | 212 | "GNUNET_TEST_HOME"); |
213 | GNUNET_free (plugin_name); | ||
213 | GNUNET_free (cfg_name); | 214 | GNUNET_free (cfg_name); |
214 | return res; | 215 | return res; |
215 | } | 216 | } |
diff --git a/src/namestore/test_namestore_api_remove_not_existing_record.c b/src/namestore/test_namestore_api_remove_not_existing_record.c index ea95a6b57..9a3eabbee 100644 --- a/src/namestore/test_namestore_api_remove_not_existing_record.c +++ b/src/namestore/test_namestore_api_remove_not_existing_record.c | |||
@@ -170,6 +170,7 @@ main (int argc, char *argv[]) | |||
170 | } | 170 | } |
171 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 171 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
172 | "GNUNET_TEST_HOME"); | 172 | "GNUNET_TEST_HOME"); |
173 | GNUNET_free (plugin_name); | ||
173 | GNUNET_free (cfg_name); | 174 | GNUNET_free (cfg_name); |
174 | return res; | 175 | return res; |
175 | } | 176 | } |
diff --git a/src/namestore/test_namestore_api_store.c b/src/namestore/test_namestore_api_store.c index d291045e5..f8a3dd412 100644 --- a/src/namestore/test_namestore_api_store.c +++ b/src/namestore/test_namestore_api_store.c | |||
@@ -163,6 +163,7 @@ main (int argc, char *argv[]) | |||
163 | } | 163 | } |
164 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 164 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
165 | "GNUNET_TEST_HOME"); | 165 | "GNUNET_TEST_HOME"); |
166 | GNUNET_free (plugin_name); | ||
166 | GNUNET_free (cfg_name); | 167 | GNUNET_free (cfg_name); |
167 | return res; | 168 | return res; |
168 | } | 169 | } |
diff --git a/src/namestore/test_namestore_api_store_update.c b/src/namestore/test_namestore_api_store_update.c index bef19385c..9baa4becd 100644 --- a/src/namestore/test_namestore_api_store_update.c +++ b/src/namestore/test_namestore_api_store_update.c | |||
@@ -143,6 +143,7 @@ lookup_success (void *cls, | |||
143 | &rd_new, | 143 | &rd_new, |
144 | &put_cont, | 144 | &put_cont, |
145 | (void *) name); | 145 | (void *) name); |
146 | GNUNET_free (rd_new.data); | ||
146 | update_performed = GNUNET_YES; | 147 | update_performed = GNUNET_YES; |
147 | } | 148 | } |
148 | else | 149 | else |
@@ -259,6 +260,7 @@ main (int argc, | |||
259 | } | 260 | } |
260 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 261 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
261 | "GNUNET_TEST_HOME"); | 262 | "GNUNET_TEST_HOME"); |
263 | GNUNET_free (plugin_name); | ||
262 | GNUNET_free (cfg_name); | 264 | GNUNET_free (cfg_name); |
263 | return res; | 265 | return res; |
264 | } | 266 | } |
diff --git a/src/namestore/test_namestore_api_tx_rollback.c b/src/namestore/test_namestore_api_tx_rollback.c index 5b4bc6174..1b1d00c96 100644 --- a/src/namestore/test_namestore_api_tx_rollback.c +++ b/src/namestore/test_namestore_api_tx_rollback.c | |||
@@ -255,6 +255,7 @@ main (int argc, char *argv[]) | |||
255 | } | 255 | } |
256 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 256 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
257 | "GNUNET_TEST_HOME"); | 257 | "GNUNET_TEST_HOME"); |
258 | GNUNET_free (plugin_name); | ||
258 | GNUNET_free (cfg_name); | 259 | GNUNET_free (cfg_name); |
259 | return res; | 260 | return res; |
260 | } | 261 | } |
diff --git a/src/namestore/test_namestore_api_zone_iteration.c b/src/namestore/test_namestore_api_zone_iteration.c index e072dbef9..f9bf4986b 100644 --- a/src/namestore/test_namestore_api_zone_iteration.c +++ b/src/namestore/test_namestore_api_zone_iteration.c | |||
@@ -455,6 +455,7 @@ main (int argc, char *argv[]) | |||
455 | } | 455 | } |
456 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 456 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
457 | "GNUNET_TEST_HOME"); | 457 | "GNUNET_TEST_HOME"); |
458 | GNUNET_free (plugin_name); | ||
458 | GNUNET_free (cfg_name); | 459 | GNUNET_free (cfg_name); |
459 | return res; | 460 | return res; |
460 | } | 461 | } |
diff --git a/src/namestore/test_namestore_api_zone_iteration_nick.c b/src/namestore/test_namestore_api_zone_iteration_nick.c index e371bb312..5855b1e87 100644 --- a/src/namestore/test_namestore_api_zone_iteration_nick.c +++ b/src/namestore/test_namestore_api_zone_iteration_nick.c | |||
@@ -451,6 +451,7 @@ main (int argc, char *argv[]) | |||
451 | } | 451 | } |
452 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 452 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
453 | "GNUNET_TEST_HOME"); | 453 | "GNUNET_TEST_HOME"); |
454 | GNUNET_free (plugin_name); | ||
454 | GNUNET_free (cfg_name); | 455 | GNUNET_free (cfg_name); |
455 | return res; | 456 | return res; |
456 | } | 457 | } |
diff --git a/src/namestore/test_namestore_api_zone_iteration_specific_zone.c b/src/namestore/test_namestore_api_zone_iteration_specific_zone.c index 074cd4dbb..519383169 100644 --- a/src/namestore/test_namestore_api_zone_iteration_specific_zone.c +++ b/src/namestore/test_namestore_api_zone_iteration_specific_zone.c | |||
@@ -438,6 +438,7 @@ main (int argc, char *argv[]) | |||
438 | } | 438 | } |
439 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 439 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
440 | "GNUNET_TEST_HOME"); | 440 | "GNUNET_TEST_HOME"); |
441 | GNUNET_free (plugin_name); | ||
441 | GNUNET_free (cfg_name); | 442 | GNUNET_free (cfg_name); |
442 | return res; | 443 | return res; |
443 | } | 444 | } |
diff --git a/src/namestore/test_namestore_api_zone_iteration_stop.c b/src/namestore/test_namestore_api_zone_iteration_stop.c index 7efe59648..4fe86301c 100644 --- a/src/namestore/test_namestore_api_zone_iteration_stop.c +++ b/src/namestore/test_namestore_api_zone_iteration_stop.c | |||
@@ -439,6 +439,7 @@ main (int argc, char *argv[]) | |||
439 | } | 439 | } |
440 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 440 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
441 | "GNUNET_TEST_HOME"); | 441 | "GNUNET_TEST_HOME"); |
442 | GNUNET_free (plugin_name); | ||
442 | GNUNET_free (cfg_name); | 443 | GNUNET_free (cfg_name); |
443 | 444 | ||
444 | return res; | 445 | return res; |
diff --git a/src/namestore/test_namestore_api_zone_to_name.c b/src/namestore/test_namestore_api_zone_to_name.c index dfdefa039..a99b7bc71 100644 --- a/src/namestore/test_namestore_api_zone_to_name.c +++ b/src/namestore/test_namestore_api_zone_to_name.c | |||
@@ -257,6 +257,7 @@ main (int argc, | |||
257 | } | 257 | } |
258 | GNUNET_DISK_purge_cfg_dir (cfg_name, | 258 | GNUNET_DISK_purge_cfg_dir (cfg_name, |
259 | "GNUNET_TEST_HOME"); | 259 | "GNUNET_TEST_HOME"); |
260 | GNUNET_free (plugin_name); | ||
260 | GNUNET_free (cfg_name); | 261 | GNUNET_free (cfg_name); |
261 | return res; | 262 | return res; |
262 | } | 263 | } |