aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatthias Wachs <wachs@net.in.tum.de>2012-05-24 09:35:37 +0000
committerMatthias Wachs <wachs@net.in.tum.de>2012-05-24 09:35:37 +0000
commit101f5787ac60dafa175950fb714c6d4cc4906478 (patch)
tree711c8042c8b22856b0946d0c819a3520498ac274
parent6743123dcc6b37dabf2759f384a7f6ad08a08bec (diff)
downloadgnunet-101f5787ac60dafa175950fb714c6d4cc4906478.tar.gz
gnunet-101f5787ac60dafa175950fb714c6d4cc4906478.zip
- adding return value to mst callback
-rw-r--r--src/core/gnunet-service-core_clients.c3
-rw-r--r--src/core/gnunet-service-core_kx.c5
-rw-r--r--src/dns/gnunet-service-dns.c13
-rw-r--r--src/dv/gnunet-service-dv.c3
-rw-r--r--src/exit/gnunet-daemon-exit.c21
-rw-r--r--src/fs/fs_dirmetascan.c17
-rw-r--r--src/statistics/gnunet-service-statistics.c3
-rw-r--r--src/transport/gnunet-helper-transport-wlan-dummy.c6
-rw-r--r--src/transport/gnunet-service-transport.c2
-rw-r--r--src/transport/plugin_transport_http_client.c5
-rw-r--r--src/transport/plugin_transport_http_server.c5
-rw-r--r--src/transport/plugin_transport_udp.c5
-rw-r--r--src/transport/plugin_transport_udp_broadcasting.c10
-rw-r--r--src/transport/plugin_transport_wlan.c6
-rw-r--r--src/vpn/gnunet-service-vpn.c15
15 files changed, 68 insertions, 51 deletions
diff --git a/src/core/gnunet-service-core_clients.c b/src/core/gnunet-service-core_clients.c
index 2c603d217..1076f343f 100644
--- a/src/core/gnunet-service-core_clients.c
+++ b/src/core/gnunet-service-core_clients.c
@@ -506,7 +506,7 @@ handle_client_send (void *cls, struct GNUNET_SERVER_Client *client,
506 * @param client reservation request ('struct GSC_ClientActiveRequest') 506 * @param client reservation request ('struct GSC_ClientActiveRequest')
507 * @param message the actual message 507 * @param message the actual message
508 */ 508 */
509static void 509static int
510client_tokenizer_callback (void *cls, void *client, 510client_tokenizer_callback (void *cls, void *client,
511 const struct GNUNET_MessageHeader *message) 511 const struct GNUNET_MessageHeader *message)
512{ 512{
@@ -546,6 +546,7 @@ client_tokenizer_callback (void *cls, void *client,
546 GNUNET_CORE_OPTION_SEND_HDR_OUTBOUND); 546 GNUNET_CORE_OPTION_SEND_HDR_OUTBOUND);
547 GSC_SESSIONS_transmit (car, message, tc->cork); 547 GSC_SESSIONS_transmit (car, message, tc->cork);
548 } 548 }
549 return GNUNET_OK;
549} 550}
550 551
551 552
diff --git a/src/core/gnunet-service-core_kx.c b/src/core/gnunet-service-core_kx.c
index 81c3382af..1fce2e528 100644
--- a/src/core/gnunet-service-core_kx.c
+++ b/src/core/gnunet-service-core_kx.c
@@ -1658,7 +1658,7 @@ GSC_KX_handle_encrypted_message (struct GSC_KeyExchangeInfo *kx,
1658 * @param client who sent us the message (struct GSC_KeyExchangeInfo) 1658 * @param client who sent us the message (struct GSC_KeyExchangeInfo)
1659 * @param m the message 1659 * @param m the message
1660 */ 1660 */
1661static void 1661static int
1662deliver_message (void *cls, void *client, const struct GNUNET_MessageHeader *m) 1662deliver_message (void *cls, void *client, const struct GNUNET_MessageHeader *m)
1663{ 1663{
1664 struct DeliverMessageContext *dmc = client; 1664 struct DeliverMessageContext *dmc = client;
@@ -1668,7 +1668,7 @@ deliver_message (void *cls, void *client, const struct GNUNET_MessageHeader *m)
1668 case GNUNET_MESSAGE_TYPE_CORE_BINARY_TYPE_MAP: 1668 case GNUNET_MESSAGE_TYPE_CORE_BINARY_TYPE_MAP:
1669 case GNUNET_MESSAGE_TYPE_CORE_COMPRESSED_TYPE_MAP: 1669 case GNUNET_MESSAGE_TYPE_CORE_COMPRESSED_TYPE_MAP:
1670 GSC_SESSIONS_set_typemap (dmc->peer, m); 1670 GSC_SESSIONS_set_typemap (dmc->peer, m);
1671 return; 1671 return GNUNET_OK;
1672 default: 1672 default:
1673 GSC_CLIENTS_deliver_message (dmc->peer, dmc->atsi, dmc->atsi_count, m, 1673 GSC_CLIENTS_deliver_message (dmc->peer, dmc->atsi, dmc->atsi_count, m,
1674 ntohs (m->size), 1674 ntohs (m->size),
@@ -1677,6 +1677,7 @@ deliver_message (void *cls, void *client, const struct GNUNET_MessageHeader *m)
1677 sizeof (struct GNUNET_MessageHeader), 1677 sizeof (struct GNUNET_MessageHeader),
1678 GNUNET_CORE_OPTION_SEND_HDR_INBOUND); 1678 GNUNET_CORE_OPTION_SEND_HDR_INBOUND);
1679 } 1679 }
1680 return GNUNET_OK;
1680} 1681}
1681 1682
1682 1683
diff --git a/src/dns/gnunet-service-dns.c b/src/dns/gnunet-service-dns.c
index 173fd24e8..6337538d1 100644
--- a/src/dns/gnunet-service-dns.c
+++ b/src/dns/gnunet-service-dns.c
@@ -1239,7 +1239,7 @@ handle_client_response (void *cls GNUNET_UNUSED,
1239 * @param client identification of the client 1239 * @param client identification of the client
1240 * @param message the actual message, a DNS request we should handle 1240 * @param message the actual message, a DNS request we should handle
1241 */ 1241 */
1242static void 1242static int
1243process_helper_messages (void *cls GNUNET_UNUSED, void *client, 1243process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1244 const struct GNUNET_MessageHeader *message) 1244 const struct GNUNET_MessageHeader *message)
1245{ 1245{
@@ -1260,7 +1260,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1260 { 1260 {
1261 /* non-IP packet received on TUN!? */ 1261 /* non-IP packet received on TUN!? */
1262 GNUNET_break (0); 1262 GNUNET_break (0);
1263 return; 1263 return GNUNET_OK;
1264 } 1264 }
1265 msize -= sizeof (struct GNUNET_MessageHeader); 1265 msize -= sizeof (struct GNUNET_MessageHeader);
1266 tun = (const struct GNUNET_TUN_Layer2PacketHeader *) &message[1]; 1266 tun = (const struct GNUNET_TUN_Layer2PacketHeader *) &message[1];
@@ -1279,7 +1279,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1279 /* non-IP/UDP packet received on TUN (or with options) */ 1279 /* non-IP/UDP packet received on TUN (or with options) */
1280 GNUNET_log (GNUNET_ERROR_TYPE_INFO, 1280 GNUNET_log (GNUNET_ERROR_TYPE_INFO,
1281 _("Received malformed IPv4-UDP packet on TUN interface.\n")); 1281 _("Received malformed IPv4-UDP packet on TUN interface.\n"));
1282 return; 1282 return GNUNET_OK;
1283 } 1283 }
1284 udp = (const struct GNUNET_TUN_UdpHeader*) &ip4[1]; 1284 udp = (const struct GNUNET_TUN_UdpHeader*) &ip4[1];
1285 msize -= sizeof (struct GNUNET_TUN_IPv4Header); 1285 msize -= sizeof (struct GNUNET_TUN_IPv4Header);
@@ -1295,7 +1295,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1295 /* non-IP/UDP packet received on TUN (or with extensions) */ 1295 /* non-IP/UDP packet received on TUN (or with extensions) */
1296 GNUNET_log (GNUNET_ERROR_TYPE_INFO, 1296 GNUNET_log (GNUNET_ERROR_TYPE_INFO,
1297 _("Received malformed IPv6-UDP packet on TUN interface.\n")); 1297 _("Received malformed IPv6-UDP packet on TUN interface.\n"));
1298 return; 1298 return GNUNET_OK;
1299 } 1299 }
1300 udp = (const struct GNUNET_TUN_UdpHeader*) &ip6[1]; 1300 udp = (const struct GNUNET_TUN_UdpHeader*) &ip6[1];
1301 msize -= sizeof (struct GNUNET_TUN_IPv6Header); 1301 msize -= sizeof (struct GNUNET_TUN_IPv6Header);
@@ -1306,7 +1306,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1306 _("Got non-IP packet with %u bytes and protocol %u from TUN\n"), 1306 _("Got non-IP packet with %u bytes and protocol %u from TUN\n"),
1307 (unsigned int) msize, 1307 (unsigned int) msize,
1308 ntohs (tun->proto)); 1308 ntohs (tun->proto));
1309 return; 1309 return GNUNET_OK;
1310 } 1310 }
1311 if (msize <= sizeof (struct GNUNET_TUN_UdpHeader) + sizeof (struct GNUNET_TUN_DnsHeader)) 1311 if (msize <= sizeof (struct GNUNET_TUN_UdpHeader) + sizeof (struct GNUNET_TUN_DnsHeader))
1312 { 1312 {
@@ -1314,7 +1314,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1314 GNUNET_STATISTICS_update (stats, 1314 GNUNET_STATISTICS_update (stats,
1315 gettext_noop ("# Non-DNS UDP packet received via TUN interface"), 1315 gettext_noop ("# Non-DNS UDP packet received via TUN interface"),
1316 1, GNUNET_NO); 1316 1, GNUNET_NO);
1317 return; 1317 return GNUNET_OK;
1318 } 1318 }
1319 msize -= sizeof (struct GNUNET_TUN_UdpHeader); 1319 msize -= sizeof (struct GNUNET_TUN_UdpHeader);
1320 dns = (const struct GNUNET_TUN_DnsHeader*) &udp[1]; 1320 dns = (const struct GNUNET_TUN_DnsHeader*) &udp[1];
@@ -1381,6 +1381,7 @@ process_helper_messages (void *cls GNUNET_UNUSED, void *client,
1381 1, GNUNET_NO); 1381 1, GNUNET_NO);
1382 /* start request processing state machine */ 1382 /* start request processing state machine */
1383 next_phase (rr); 1383 next_phase (rr);
1384 return GNUNET_OK;
1384} 1385}
1385 1386
1386 1387
diff --git a/src/dv/gnunet-service-dv.c b/src/dv/gnunet-service-dv.c
index 50aac09cd..651b92ac0 100644
--- a/src/dv/gnunet-service-dv.c
+++ b/src/dv/gnunet-service-dv.c
@@ -1288,7 +1288,7 @@ checkPeerID (void *cls, const GNUNET_HashCode * key, void *value)
1288 * @param client the TokenizedMessageContext which contains message information 1288 * @param client the TokenizedMessageContext which contains message information
1289 * @param message the actual message 1289 * @param message the actual message
1290 */ 1290 */
1291void 1291int
1292tokenized_message_handler (void *cls, void *client, 1292tokenized_message_handler (void *cls, void *client,
1293 const struct GNUNET_MessageHeader *message) 1293 const struct GNUNET_MessageHeader *message)
1294{ 1294{
@@ -1312,6 +1312,7 @@ tokenized_message_handler (void *cls, void *client,
1312 send_to_plugin (ctx->peer, message, ntohs (message->size), 1312 send_to_plugin (ctx->peer, message, ntohs (message->size),
1313 &ctx->distant->identity, ctx->distant->cost); 1313 &ctx->distant->identity, ctx->distant->cost);
1314 } 1314 }
1315 return GNUNET_OK;
1315} 1316}
1316 1317
1317#if DELAY_FORWARDS 1318#if DELAY_FORWARDS
diff --git a/src/exit/gnunet-daemon-exit.c b/src/exit/gnunet-daemon-exit.c
index e58611cc6..26f3e7536 100644
--- a/src/exit/gnunet-daemon-exit.c
+++ b/src/exit/gnunet-daemon-exit.c
@@ -953,7 +953,7 @@ tcp_from_helper (const struct GNUNET_TUN_TcpHeader *tcp,
953 * @param client unsued 953 * @param client unsued
954 * @param message message received from helper 954 * @param message message received from helper
955 */ 955 */
956static void 956static int
957message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED, 957message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
958 const struct GNUNET_MessageHeader *message) 958 const struct GNUNET_MessageHeader *message)
959{ 959{
@@ -970,13 +970,13 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
970 if (ntohs (message->type) != GNUNET_MESSAGE_TYPE_VPN_HELPER) 970 if (ntohs (message->type) != GNUNET_MESSAGE_TYPE_VPN_HELPER)
971 { 971 {
972 GNUNET_break (0); 972 GNUNET_break (0);
973 return; 973 return GNUNET_OK;
974 } 974 }
975 size = ntohs (message->size); 975 size = ntohs (message->size);
976 if (size < sizeof (struct GNUNET_TUN_Layer2PacketHeader) + sizeof (struct GNUNET_MessageHeader)) 976 if (size < sizeof (struct GNUNET_TUN_Layer2PacketHeader) + sizeof (struct GNUNET_MessageHeader))
977 { 977 {
978 GNUNET_break (0); 978 GNUNET_break (0);
979 return; 979 return GNUNET_OK;
980 } 980 }
981 GNUNET_STATISTICS_update (stats, 981 GNUNET_STATISTICS_update (stats,
982 gettext_noop ("# Bytes received from TUN"), 982 gettext_noop ("# Bytes received from TUN"),
@@ -993,20 +993,20 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
993 { 993 {
994 /* Kernel to blame? */ 994 /* Kernel to blame? */
995 GNUNET_break (0); 995 GNUNET_break (0);
996 return; 996 return GNUNET_OK;
997 } 997 }
998 pkt4 = (const struct GNUNET_TUN_IPv4Header *) &pkt_tun[1]; 998 pkt4 = (const struct GNUNET_TUN_IPv4Header *) &pkt_tun[1];
999 if (size != ntohs (pkt4->total_length)) 999 if (size != ntohs (pkt4->total_length))
1000 { 1000 {
1001 /* Kernel to blame? */ 1001 /* Kernel to blame? */
1002 GNUNET_break (0); 1002 GNUNET_break (0);
1003 return; 1003 return GNUNET_OK;
1004 } 1004 }
1005 if (pkt4->header_length * 4 != sizeof (struct GNUNET_TUN_IPv4Header)) 1005 if (pkt4->header_length * 4 != sizeof (struct GNUNET_TUN_IPv4Header))
1006 { 1006 {
1007 GNUNET_log (GNUNET_ERROR_TYPE_WARNING, 1007 GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
1008 _("IPv4 packet options received. Ignored.\n")); 1008 _("IPv4 packet options received. Ignored.\n"));
1009 return; 1009 return GNUNET_OK;
1010 } 1010 }
1011 1011
1012 size -= sizeof (struct GNUNET_TUN_IPv4Header); 1012 size -= sizeof (struct GNUNET_TUN_IPv4Header);
@@ -1034,7 +1034,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1034 GNUNET_log (GNUNET_ERROR_TYPE_WARNING, 1034 GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
1035 _("IPv4 packet with unsupported next header %u received. Ignored.\n"), 1035 _("IPv4 packet with unsupported next header %u received. Ignored.\n"),
1036 (int) pkt4->protocol); 1036 (int) pkt4->protocol);
1037 return; 1037 return GNUNET_OK;
1038 } 1038 }
1039 } 1039 }
1040 break; 1040 break;
@@ -1046,14 +1046,14 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1046 { 1046 {
1047 /* Kernel to blame? */ 1047 /* Kernel to blame? */
1048 GNUNET_break (0); 1048 GNUNET_break (0);
1049 return; 1049 return GNUNET_OK;
1050 } 1050 }
1051 pkt6 = (struct GNUNET_TUN_IPv6Header *) &pkt_tun[1]; 1051 pkt6 = (struct GNUNET_TUN_IPv6Header *) &pkt_tun[1];
1052 if (size != ntohs (pkt6->payload_length) + sizeof (struct GNUNET_TUN_IPv6Header)) 1052 if (size != ntohs (pkt6->payload_length) + sizeof (struct GNUNET_TUN_IPv6Header))
1053 { 1053 {
1054 /* Kernel to blame? */ 1054 /* Kernel to blame? */
1055 GNUNET_break (0); 1055 GNUNET_break (0);
1056 return; 1056 return GNUNET_OK;
1057 } 1057 }
1058 size -= sizeof (struct GNUNET_TUN_IPv6Header); 1058 size -= sizeof (struct GNUNET_TUN_IPv6Header);
1059 switch (pkt6->next_header) 1059 switch (pkt6->next_header)
@@ -1080,7 +1080,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1080 GNUNET_log (GNUNET_ERROR_TYPE_WARNING, 1080 GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
1081 _("IPv6 packet with unsupported next header %d received. Ignored.\n"), 1081 _("IPv6 packet with unsupported next header %d received. Ignored.\n"),
1082 pkt6->next_header); 1082 pkt6->next_header);
1083 return; 1083 return GNUNET_OK;
1084 } 1084 }
1085 } 1085 }
1086 break; 1086 break;
@@ -1090,6 +1090,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1090 ntohs (pkt_tun->proto)); 1090 ntohs (pkt_tun->proto));
1091 break; 1091 break;
1092 } 1092 }
1093 return GNUNET_OK;
1093} 1094}
1094 1095
1095 1096
diff --git a/src/fs/fs_dirmetascan.c b/src/fs/fs_dirmetascan.c
index 2c6d914ab..7d322e0d7 100644
--- a/src/fs/fs_dirmetascan.c
+++ b/src/fs/fs_dirmetascan.c
@@ -248,7 +248,7 @@ finish_scan (void *cls,
248 * @param client always NULL 248 * @param client always NULL
249 * @param msg message from the helper process 249 * @param msg message from the helper process
250 */ 250 */
251static void 251static int
252process_helper_msgs (void *cls, 252process_helper_msgs (void *cls,
253 void *client, 253 void *client,
254 const struct GNUNET_MessageHeader *msg) 254 const struct GNUNET_MessageHeader *msg)
@@ -281,7 +281,7 @@ process_helper_msgs (void *cls,
281 else 281 else
282 (void) expand_tree (ds->pos, 282 (void) expand_tree (ds->pos,
283 filename, GNUNET_NO); 283 filename, GNUNET_NO);
284 return; 284 return GNUNET_OK;
285 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_PROGRESS_DIRECTORY: 285 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_PROGRESS_DIRECTORY:
286 if (filename[left-1] != '\0') 286 if (filename[left-1] != '\0')
287 { 287 {
@@ -296,7 +296,7 @@ process_helper_msgs (void *cls,
296 break; 296 break;
297 } 297 }
298 ds->pos = ds->pos->parent; 298 ds->pos = ds->pos->parent;
299 return; 299 return GNUNET_OK;
300 } 300 }
301 ds->progress_callback (ds->progress_callback_cls, 301 ds->progress_callback (ds->progress_callback_cls,
302 filename, GNUNET_YES, 302 filename, GNUNET_YES,
@@ -305,7 +305,7 @@ process_helper_msgs (void *cls,
305 filename, GNUNET_YES); 305 filename, GNUNET_YES);
306 if (NULL == ds->toplevel) 306 if (NULL == ds->toplevel)
307 ds->toplevel = ds->pos; 307 ds->toplevel = ds->pos;
308 return; 308 return GNUNET_OK;
309 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_ERROR: 309 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_ERROR:
310 break; 310 break;
311 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_SKIP_FILE: 311 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_SKIP_FILE:
@@ -314,7 +314,7 @@ process_helper_msgs (void *cls,
314 ds->progress_callback (ds->progress_callback_cls, 314 ds->progress_callback (ds->progress_callback_cls,
315 filename, GNUNET_SYSERR, 315 filename, GNUNET_SYSERR,
316 GNUNET_FS_DIRSCANNER_FILE_IGNORED); 316 GNUNET_FS_DIRSCANNER_FILE_IGNORED);
317 return; 317 return GNUNET_OK;
318 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_COUNTING_DONE: 318 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_COUNTING_DONE:
319 if (0 != left) 319 if (0 != left)
320 { 320 {
@@ -332,7 +332,7 @@ process_helper_msgs (void *cls,
332 ds->pos = ds->toplevel; 332 ds->pos = ds->toplevel;
333 if (GNUNET_YES == ds->pos->is_directory) 333 if (GNUNET_YES == ds->pos->is_directory)
334 ds->pos = advance (ds->pos); 334 ds->pos = advance (ds->pos);
335 return; 335 return GNUNET_OK;
336 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_META_DATA: 336 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_META_DATA:
337 { 337 {
338 size_t nlen; 338 size_t nlen;
@@ -382,7 +382,7 @@ process_helper_msgs (void *cls,
382 } 382 }
383 ds->pos->ksk_uri = GNUNET_FS_uri_ksk_create_from_meta_data (ds->pos->meta); 383 ds->pos->ksk_uri = GNUNET_FS_uri_ksk_create_from_meta_data (ds->pos->meta);
384 ds->pos = advance (ds->pos); 384 ds->pos = advance (ds->pos);
385 return; 385 return GNUNET_OK;
386 } 386 }
387 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_FINISHED: 387 case GNUNET_MESSAGE_TYPE_FS_PUBLISH_HELPER_FINISHED:
388 if (NULL != ds->pos) 388 if (NULL != ds->pos)
@@ -402,7 +402,7 @@ process_helper_msgs (void *cls,
402 } 402 }
403 ds->stop_task = GNUNET_SCHEDULER_add_now (&finish_scan, 403 ds->stop_task = GNUNET_SCHEDULER_add_now (&finish_scan,
404 ds); 404 ds);
405 return; 405 return GNUNET_OK;
406 default: 406 default:
407 GNUNET_break (0); 407 GNUNET_break (0);
408 break; 408 break;
@@ -410,6 +410,7 @@ process_helper_msgs (void *cls,
410 ds->progress_callback (ds->progress_callback_cls, 410 ds->progress_callback (ds->progress_callback_cls,
411 NULL, GNUNET_SYSERR, 411 NULL, GNUNET_SYSERR,
412 GNUNET_FS_DIRSCANNER_INTERNAL_ERROR); 412 GNUNET_FS_DIRSCANNER_INTERNAL_ERROR);
413 return GNUNET_OK;
413} 414}
414 415
415 416
diff --git a/src/statistics/gnunet-service-statistics.c b/src/statistics/gnunet-service-statistics.c
index 5cced1426..efd834624 100644
--- a/src/statistics/gnunet-service-statistics.c
+++ b/src/statistics/gnunet-service-statistics.c
@@ -214,12 +214,13 @@ static int in_shutdown;
214 * @param client unused 214 * @param client unused
215 * @param msg message to inject 215 * @param msg message to inject
216 */ 216 */
217static void 217static int
218inject_message (void *cls, void *client, const struct GNUNET_MessageHeader *msg) 218inject_message (void *cls, void *client, const struct GNUNET_MessageHeader *msg)
219{ 219{
220 struct GNUNET_SERVER_Handle *server = cls; 220 struct GNUNET_SERVER_Handle *server = cls;
221 221
222 GNUNET_break (GNUNET_OK == GNUNET_SERVER_inject (server, NULL, msg)); 222 GNUNET_break (GNUNET_OK == GNUNET_SERVER_inject (server, NULL, msg));
223 return GNUNET_OK;
223} 224}
224 225
225 226
diff --git a/src/transport/gnunet-helper-transport-wlan-dummy.c b/src/transport/gnunet-helper-transport-wlan-dummy.c
index 9d82fccf3..a7015ac2c 100644
--- a/src/transport/gnunet-helper-transport-wlan-dummy.c
+++ b/src/transport/gnunet-helper-transport-wlan-dummy.c
@@ -119,7 +119,7 @@ send_mac_to_plugin (char *buffer, struct GNUNET_TRANSPORT_WLAN_MacAddress *mac)
119 * @param client unused 119 * @param client unused
120 * @param hdr inbound message from the FIFO 120 * @param hdr inbound message from the FIFO
121 */ 121 */
122static void 122static int
123stdin_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr) 123stdin_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
124{ 124{
125 struct SendBuffer *write_pout = cls; 125 struct SendBuffer *write_pout = cls;
@@ -154,6 +154,7 @@ stdin_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
154 &in[1], 154 &in[1],
155 payload_size); 155 payload_size);
156 write_pout->size += payload_size; 156 write_pout->size += payload_size;
157 return GNUNET_OK;
157} 158}
158 159
159 160
@@ -164,7 +165,7 @@ stdin_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
164 * @param client unused 165 * @param client unused
165 * @param hdr the message we received to copy to the buffer 166 * @param hdr the message we received to copy to the buffer
166 */ 167 */
167static void 168static int
168file_in_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr) 169file_in_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
169{ 170{
170 struct SendBuffer *write_std = cls; 171 struct SendBuffer *write_std = cls;
@@ -178,6 +179,7 @@ file_in_send (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
178 } 179 }
179 memcpy (write_std->buf + write_std->size, hdr, sendsize); 180 memcpy (write_std->buf + write_std->size, hdr, sendsize);
180 write_std->size += sendsize; 181 write_std->size += sendsize;
182 return GNUNET_OK;
181} 183}
182 184
183 185
diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index 93fd0d685..9a1d86ffe 100644
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -230,7 +230,7 @@ plugin_env_receive_callback (void *cls, const struct GNUNET_PeerIdentity *peer,
230 if (NULL == message) 230 if (NULL == message)
231 goto end; 231 goto end;
232 type = ntohs (message->type); 232 type = ntohs (message->type);
233 GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Received Message with type %u from peer `%s'\n", type, GNUNET_i2s (peer)); 233 GNUNET_log (GNUNET_ERROR_TYPE_ERROR, "Received Message with type %u from peer `%s'\n", type, GNUNET_i2s (peer));
234 234
235 GNUNET_STATISTICS_update (GST_stats, 235 GNUNET_STATISTICS_update (GST_stats,
236 gettext_noop 236 gettext_noop
diff --git a/src/transport/plugin_transport_http_client.c b/src/transport/plugin_transport_http_client.c
index cf21a425a..79f70bb6c 100644
--- a/src/transport/plugin_transport_http_client.c
+++ b/src/transport/plugin_transport_http_client.c
@@ -333,7 +333,7 @@ client_disconnect (struct Session *s)
333 return res; 333 return res;
334} 334}
335 335
336static void 336static int
337client_receive_mst_cb (void *cls, void *client, 337client_receive_mst_cb (void *cls, void *client,
338 const struct GNUNET_MessageHeader *message) 338 const struct GNUNET_MessageHeader *message)
339{ 339{
@@ -343,7 +343,7 @@ client_receive_mst_cb (void *cls, void *client,
343 if (GNUNET_YES != exist_session(p, s)) 343 if (GNUNET_YES != exist_session(p, s))
344 { 344 {
345 GNUNET_break (0); 345 GNUNET_break (0);
346 return; 346 return GNUNET_OK;
347 } 347 }
348 348
349 delay = http_plugin_receive (s, &s->target, message, s, s->addr, s->addrlen); 349 delay = http_plugin_receive (s, &s->target, message, s, s->addr, s->addrlen);
@@ -359,6 +359,7 @@ client_receive_mst_cb (void *cls, void *client,
359 GNUNET_i2s (&s->target), GNUNET_a2s (s->addr, s->addrlen), 359 GNUNET_i2s (&s->target), GNUNET_a2s (s->addr, s->addrlen),
360 delay); 360 delay);
361 } 361 }
362 return GNUNET_OK;
362} 363}
363 364
364static void 365static void
diff --git a/src/transport/plugin_transport_http_server.c b/src/transport/plugin_transport_http_server.c
index 00ad005bd..c49e4953a 100644
--- a/src/transport/plugin_transport_http_server.c
+++ b/src/transport/plugin_transport_http_server.c
@@ -273,7 +273,7 @@ server_reschedule (struct Plugin *plugin, struct MHD_Daemon *server, int now)
273 * @param client clien 273 * @param client clien
274 * @param message the message to be forwarded to transport service 274 * @param message the message to be forwarded to transport service
275 */ 275 */
276static void 276static int
277server_receive_mst_cb (void *cls, void *client, 277server_receive_mst_cb (void *cls, void *client,
278 const struct GNUNET_MessageHeader *message) 278 const struct GNUNET_MessageHeader *message)
279{ 279{
@@ -281,7 +281,7 @@ server_receive_mst_cb (void *cls, void *client,
281 281
282 GNUNET_assert (NULL != p); 282 GNUNET_assert (NULL != p);
283 if (GNUNET_NO == exist_session(p, s)) 283 if (GNUNET_NO == exist_session(p, s))
284 return; 284 return GNUNET_OK;
285 285
286 struct Plugin *plugin = s->plugin; 286 struct Plugin *plugin = s->plugin;
287 struct GNUNET_TIME_Relative delay; 287 struct GNUNET_TIME_Relative delay;
@@ -299,6 +299,7 @@ server_receive_mst_cb (void *cls, void *client,
299 http_plugin_address_to_string (NULL, s->addr, s->addrlen), 299 http_plugin_address_to_string (NULL, s->addr, s->addrlen),
300 delay); 300 delay);
301 } 301 }
302 return GNUNET_OK;
302} 303}
303 304
304/** 305/**
diff --git a/src/transport/plugin_transport_udp.c b/src/transport/plugin_transport_udp.c
index 86af69fc8..60814327c 100644
--- a/src/transport/plugin_transport_udp.c
+++ b/src/transport/plugin_transport_udp.c
@@ -1263,7 +1263,7 @@ udp_nat_port_map_callback (void *cls, int add_remove,
1263 * @param client the 'struct SourceInformation' 1263 * @param client the 'struct SourceInformation'
1264 * @param hdr the actual message 1264 * @param hdr the actual message
1265 */ 1265 */
1266static void 1266static int
1267process_inbound_tokenized_messages (void *cls, void *client, 1267process_inbound_tokenized_messages (void *cls, void *client,
1268 const struct GNUNET_MessageHeader *hdr) 1268 const struct GNUNET_MessageHeader *hdr)
1269{ 1269{
@@ -1274,7 +1274,7 @@ process_inbound_tokenized_messages (void *cls, void *client,
1274 1274
1275 GNUNET_assert (si->session != NULL); 1275 GNUNET_assert (si->session != NULL);
1276 if (GNUNET_YES == si->session->in_destroy) 1276 if (GNUNET_YES == si->session->in_destroy)
1277 return; 1277 return GNUNET_OK;
1278 /* setup ATS */ 1278 /* setup ATS */
1279 ats[0].type = htonl (GNUNET_ATS_QUALITY_NET_DISTANCE); 1279 ats[0].type = htonl (GNUNET_ATS_QUALITY_NET_DISTANCE);
1280 ats[0].value = htonl (1); 1280 ats[0].value = htonl (1);
@@ -1289,6 +1289,7 @@ process_inbound_tokenized_messages (void *cls, void *client,
1289 si->arg, 1289 si->arg,
1290 si->args); 1290 si->args);
1291 si->session->flow_delay_for_other_peer = delay; 1291 si->session->flow_delay_for_other_peer = delay;
1292 return GNUNET_OK;
1292} 1293}
1293 1294
1294 1295
diff --git a/src/transport/plugin_transport_udp_broadcasting.c b/src/transport/plugin_transport_udp_broadcasting.c
index 2935d8da3..baabf45ea 100644
--- a/src/transport/plugin_transport_udp_broadcasting.c
+++ b/src/transport/plugin_transport_udp_broadcasting.c
@@ -90,7 +90,7 @@ struct Mstv6Context
90 90
91 91
92 92
93void 93int
94broadcast_ipv6_mst_cb (void *cls, void *client, 94broadcast_ipv6_mst_cb (void *cls, void *client,
95 const struct GNUNET_MessageHeader *message) 95 const struct GNUNET_MessageHeader *message)
96{ 96{
@@ -104,7 +104,7 @@ broadcast_ipv6_mst_cb (void *cls, void *client,
104 104
105 if (GNUNET_MESSAGE_TYPE_TRANSPORT_BROADCAST_BEACON != 105 if (GNUNET_MESSAGE_TYPE_TRANSPORT_BROADCAST_BEACON !=
106 ntohs (msg->header.type)) 106 ntohs (msg->header.type))
107 return; 107 return GNUNET_OK;
108 LOG (GNUNET_ERROR_TYPE_DEBUG, 108 LOG (GNUNET_ERROR_TYPE_DEBUG,
109 "Received beacon with %u bytes from peer `%s' via address `%s'\n", 109 "Received beacon with %u bytes from peer `%s' via address `%s'\n",
110 ntohs (msg->header.size), GNUNET_i2s (&msg->sender), 110 ntohs (msg->header.size), GNUNET_i2s (&msg->sender),
@@ -128,9 +128,10 @@ broadcast_ipv6_mst_cb (void *cls, void *client,
128 ("# IPv6 multicast HELLO beacons received via udp"), 128 ("# IPv6 multicast HELLO beacons received via udp"),
129 1, GNUNET_NO); 129 1, GNUNET_NO);
130 GNUNET_free (mc); 130 GNUNET_free (mc);
131 return GNUNET_OK;
131} 132}
132 133
133void 134int
134broadcast_ipv4_mst_cb (void *cls, void *client, 135broadcast_ipv4_mst_cb (void *cls, void *client,
135 const struct GNUNET_MessageHeader *message) 136 const struct GNUNET_MessageHeader *message)
136{ 137{
@@ -143,7 +144,7 @@ broadcast_ipv4_mst_cb (void *cls, void *client,
143 144
144 if (GNUNET_MESSAGE_TYPE_TRANSPORT_BROADCAST_BEACON != 145 if (GNUNET_MESSAGE_TYPE_TRANSPORT_BROADCAST_BEACON !=
145 ntohs (msg->header.type)) 146 ntohs (msg->header.type))
146 return; 147 return GNUNET_OK;
147 LOG (GNUNET_ERROR_TYPE_DEBUG, 148 LOG (GNUNET_ERROR_TYPE_DEBUG,
148 "Received beacon with %u bytes from peer `%s' via address `%s'\n", 149 "Received beacon with %u bytes from peer `%s' via address `%s'\n",
149 ntohs (msg->header.size), GNUNET_i2s (&msg->sender), 150 ntohs (msg->header.size), GNUNET_i2s (&msg->sender),
@@ -168,6 +169,7 @@ broadcast_ipv4_mst_cb (void *cls, void *client,
168 ("# IPv4 broadcast HELLO beacons received via udp"), 169 ("# IPv4 broadcast HELLO beacons received via udp"),
169 1, GNUNET_NO); 170 1, GNUNET_NO);
170 GNUNET_free (mc); 171 GNUNET_free (mc);
172 return GNUNET_OK;
171} 173}
172 174
173void 175void
diff --git a/src/transport/plugin_transport_wlan.c b/src/transport/plugin_transport_wlan.c
index bda17cb90..aed4b2286 100644
--- a/src/transport/plugin_transport_wlan.c
+++ b/src/transport/plugin_transport_wlan.c
@@ -1081,7 +1081,7 @@ wlan_plugin_send (void *cls,
1081 * @param client pointer to the session this message belongs to 1081 * @param client pointer to the session this message belongs to
1082 * @param hdr start of the message 1082 * @param hdr start of the message
1083 */ 1083 */
1084static void 1084static int
1085process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr) 1085process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
1086{ 1086{
1087 struct Plugin *plugin = cls; 1087 struct Plugin *plugin = cls;
@@ -1245,6 +1245,7 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
1245 (mas->endpoint == NULL) ? 0 : sizeof (struct GNUNET_TRANSPORT_WLAN_MacAddress)); 1245 (mas->endpoint == NULL) ? 0 : sizeof (struct GNUNET_TRANSPORT_WLAN_MacAddress));
1246 break; 1246 break;
1247 } 1247 }
1248 return GNUNET_OK;
1248} 1249}
1249#undef NUM_ATS 1250#undef NUM_ATS
1250 1251
@@ -1256,7 +1257,7 @@ process_data (void *cls, void *client, const struct GNUNET_MessageHeader *hdr)
1256 * @param client client that send the data (not used) 1257 * @param client client that send the data (not used)
1257 * @param hdr header of the GNUNET_MessageHeader 1258 * @param hdr header of the GNUNET_MessageHeader
1258 */ 1259 */
1259static void 1260static int
1260handle_helper_message (void *cls, void *client, 1261handle_helper_message (void *cls, void *client,
1261 const struct GNUNET_MessageHeader *hdr) 1262 const struct GNUNET_MessageHeader *hdr)
1262{ 1263{
@@ -1358,6 +1359,7 @@ handle_helper_message (void *cls, void *client,
1358 ntohs (hdr->type), ntohs (hdr->size)); 1359 ntohs (hdr->type), ntohs (hdr->size));
1359 break; 1360 break;
1360 } 1361 }
1362 return GNUNET_OK;
1361} 1363}
1362 1364
1363 1365
diff --git a/src/vpn/gnunet-service-vpn.c b/src/vpn/gnunet-service-vpn.c
index 5cd636900..324671b0c 100644
--- a/src/vpn/gnunet-service-vpn.c
+++ b/src/vpn/gnunet-service-vpn.c
@@ -1504,7 +1504,7 @@ route_packet (struct DestinationEntry *destination,
1504 * @param client NULL 1504 * @param client NULL
1505 * @param message message we got from the client (VPN tunnel interface) 1505 * @param message message we got from the client (VPN tunnel interface)
1506 */ 1506 */
1507static void 1507static int
1508message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED, 1508message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1509 const struct GNUNET_MessageHeader *message) 1509 const struct GNUNET_MessageHeader *message)
1510{ 1510{
@@ -1521,7 +1521,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1521 (mlen < sizeof (struct GNUNET_MessageHeader) + sizeof (struct GNUNET_TUN_Layer2PacketHeader)) ) 1521 (mlen < sizeof (struct GNUNET_MessageHeader) + sizeof (struct GNUNET_TUN_Layer2PacketHeader)) )
1522 { 1522 {
1523 GNUNET_break (0); 1523 GNUNET_break (0);
1524 return; 1524 return GNUNET_OK;
1525 } 1525 }
1526 tun = (const struct GNUNET_TUN_Layer2PacketHeader *) &message[1]; 1526 tun = (const struct GNUNET_TUN_Layer2PacketHeader *) &message[1];
1527 mlen -= (sizeof (struct GNUNET_MessageHeader) + sizeof (struct GNUNET_TUN_Layer2PacketHeader)); 1527 mlen -= (sizeof (struct GNUNET_MessageHeader) + sizeof (struct GNUNET_TUN_Layer2PacketHeader));
@@ -1535,7 +1535,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1535 { 1535 {
1536 /* blame kernel */ 1536 /* blame kernel */
1537 GNUNET_break (0); 1537 GNUNET_break (0);
1538 return; 1538 return GNUNET_OK;
1539 } 1539 }
1540 pkt6 = (const struct GNUNET_TUN_IPv6Header *) &tun[1]; 1540 pkt6 = (const struct GNUNET_TUN_IPv6Header *) &tun[1];
1541 get_destination_key_from_ip (AF_INET6, 1541 get_destination_key_from_ip (AF_INET6,
@@ -1557,7 +1557,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1557 &pkt6->destination_address, 1557 &pkt6->destination_address,
1558 buf, 1558 buf,
1559 sizeof (buf))); 1559 sizeof (buf)));
1560 return; 1560 return GNUNET_OK;
1561 } 1561 }
1562 route_packet (de, 1562 route_packet (de,
1563 AF_INET6, 1563 AF_INET6,
@@ -1576,7 +1576,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1576 { 1576 {
1577 /* blame kernel */ 1577 /* blame kernel */
1578 GNUNET_break (0); 1578 GNUNET_break (0);
1579 return; 1579 return GNUNET_OK;
1580 } 1580 }
1581 pkt4 = (struct GNUNET_TUN_IPv4Header *) &tun[1]; 1581 pkt4 = (struct GNUNET_TUN_IPv4Header *) &tun[1];
1582 get_destination_key_from_ip (AF_INET, 1582 get_destination_key_from_ip (AF_INET,
@@ -1598,13 +1598,13 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1598 &pkt4->destination_address, 1598 &pkt4->destination_address,
1599 buf, 1599 buf,
1600 sizeof (buf))); 1600 sizeof (buf)));
1601 return; 1601 return GNUNET_OK;
1602 } 1602 }
1603 if (pkt4->header_length * 4 != sizeof (struct GNUNET_TUN_IPv4Header)) 1603 if (pkt4->header_length * 4 != sizeof (struct GNUNET_TUN_IPv4Header))
1604 { 1604 {
1605 GNUNET_log (GNUNET_ERROR_TYPE_INFO, 1605 GNUNET_log (GNUNET_ERROR_TYPE_INFO,
1606 _("Received IPv4 packet with options (dropping it)\n")); 1606 _("Received IPv4 packet with options (dropping it)\n"));
1607 return; 1607 return GNUNET_OK;
1608 } 1608 }
1609 route_packet (de, 1609 route_packet (de,
1610 AF_INET, 1610 AF_INET,
@@ -1621,6 +1621,7 @@ message_token (void *cls GNUNET_UNUSED, void *client GNUNET_UNUSED,
1621 (unsigned int) ntohs (tun->proto)); 1621 (unsigned int) ntohs (tun->proto));
1622 break; 1622 break;
1623 } 1623 }
1624 return GNUNET_OK;
1624} 1625}
1625 1626
1626 1627