aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Schanzenbach <mschanzenbach@posteo.de>2021-05-15 18:54:03 +0200
committerMartin Schanzenbach <mschanzenbach@posteo.de>2021-05-15 18:54:03 +0200
commitc2b5973f9ada481c7d623e388094dd58e7668211 (patch)
treeb72fc840e768f3f34f5afed5cd3d5b97784dacfa
parent168e501991b9506b588e1180527dad9c9662ae0c (diff)
downloadgnunet-c2b5973f9ada481c7d623e388094dd58e7668211.tar.gz
gnunet-c2b5973f9ada481c7d623e388094dd58e7668211.zip
-coverity: nptr frees
-rw-r--r--src/dht/dht_api.c3
-rw-r--r--src/dht/gnunet-service-dht_clients.c12
-rw-r--r--src/dht/gnunet-service-dht_hello.c3
-rw-r--r--src/dht/gnunet-service-dht_neighbours.c3
4 files changed, 14 insertions, 7 deletions
diff --git a/src/dht/dht_api.c b/src/dht/dht_api.c
index 96399cb5a..19aa58a35 100644
--- a/src/dht/dht_api.c
+++ b/src/dht/dht_api.c
@@ -1258,7 +1258,8 @@ GNUNET_DHT_monitor_stop (struct GNUNET_DHT_MonitorHandle *mh)
1258 } 1258 }
1259 GNUNET_MQ_send (handle->mq, 1259 GNUNET_MQ_send (handle->mq,
1260 env); 1260 env);
1261 GNUNET_free (mh->key); 1261 if (NULL != mh->key)
1262 GNUNET_free (mh->key);
1262 GNUNET_free (mh); 1263 GNUNET_free (mh);
1263} 1264}
1264 1265
diff --git a/src/dht/gnunet-service-dht_clients.c b/src/dht/gnunet-service-dht_clients.c
index cfcb25336..86b7653da 100644
--- a/src/dht/gnunet-service-dht_clients.c
+++ b/src/dht/gnunet-service-dht_clients.c
@@ -938,7 +938,8 @@ handle_dht_local_monitor_stop (void *cls,
938 GNUNET_CONTAINER_DLL_remove (monitor_head, 938 GNUNET_CONTAINER_DLL_remove (monitor_head,
939 monitor_tail, 939 monitor_tail,
940 r); 940 r);
941 GNUNET_free (r->key); 941 if (NULL != r->key)
942 GNUNET_free (r->key);
942 GNUNET_free (r); 943 GNUNET_free (r);
943 return; /* Delete only ONE entry */ 944 return; /* Delete only ONE entry */
944 } 945 }
@@ -1281,7 +1282,8 @@ GDS_CLIENTS_process_get (uint32_t options,
1281 env); 1282 env);
1282 } 1283 }
1283 } 1284 }
1284 GNUNET_free (cl); 1285 if (NULL != cl)
1286 GNUNET_free (cl);
1285} 1287}
1286 1288
1287 1289
@@ -1363,7 +1365,8 @@ GDS_CLIENTS_process_get_resp (enum GNUNET_BLOCK_Type type,
1363 env); 1365 env);
1364 } 1366 }
1365 } 1367 }
1366 GNUNET_free (cl); 1368 if (NULL != cl)
1369 GNUNET_free (cl);
1367} 1370}
1368 1371
1369 1372
@@ -1445,7 +1448,8 @@ GDS_CLIENTS_process_put (uint32_t options,
1445 env); 1448 env);
1446 } 1449 }
1447 } 1450 }
1448 GNUNET_free (cl); 1451 if (NULL != cl)
1452 GNUNET_free (cl);
1449} 1453}
1450 1454
1451 1455
diff --git a/src/dht/gnunet-service-dht_hello.c b/src/dht/gnunet-service-dht_hello.c
index 906391334..7b22e928f 100644
--- a/src/dht/gnunet-service-dht_hello.c
+++ b/src/dht/gnunet-service-dht_hello.c
@@ -86,7 +86,8 @@ process_hello (void *cls,
86 gettext_noop ("# HELLOs obtained from peerinfo"), 1, 86 gettext_noop ("# HELLOs obtained from peerinfo"), 1,
87 GNUNET_NO); 87 GNUNET_NO);
88 hm = GNUNET_CONTAINER_multipeermap_get (peer_to_hello, peer); 88 hm = GNUNET_CONTAINER_multipeermap_get (peer_to_hello, peer);
89 GNUNET_free (hm); 89 if (NULL != hm)
90 GNUNET_free (hm);
90 hm = GNUNET_malloc (GNUNET_HELLO_size (hello)); 91 hm = GNUNET_malloc (GNUNET_HELLO_size (hello));
91 GNUNET_memcpy (hm, hello, GNUNET_HELLO_size (hello)); 92 GNUNET_memcpy (hm, hello, GNUNET_HELLO_size (hello));
92 GNUNET_assert (GNUNET_SYSERR != 93 GNUNET_assert (GNUNET_SYSERR !=
diff --git a/src/dht/gnunet-service-dht_neighbours.c b/src/dht/gnunet-service-dht_neighbours.c
index 88b0c5d92..39b155152 100644
--- a/src/dht/gnunet-service-dht_neighbours.c
+++ b/src/dht/gnunet-service-dht_neighbours.c
@@ -1436,7 +1436,8 @@ GDS_NEIGHBOURS_handle_get (enum GNUNET_BLOCK_Type type,
1436 if (msize + sizeof(struct PeerGetMessage) >= GNUNET_MAX_MESSAGE_SIZE) 1436 if (msize + sizeof(struct PeerGetMessage) >= GNUNET_MAX_MESSAGE_SIZE)
1437 { 1437 {
1438 GNUNET_break (0); 1438 GNUNET_break (0);
1439 GNUNET_free (reply_bf); 1439 if (NULL != reply_bf)
1440 GNUNET_free (reply_bf);
1440 GNUNET_free (targets); 1441 GNUNET_free (targets);
1441 return GNUNET_NO; 1442 return GNUNET_NO;
1442 } 1443 }