diff options
author | Martin Schanzenbach <schanzen@gnunet.org> | 2022-11-01 11:32:39 +0900 |
---|---|---|
committer | Martin Schanzenbach <schanzen@gnunet.org> | 2022-11-01 11:32:39 +0900 |
commit | 0f45038d25da3d3de3f83d04bcf30eca5da361d0 (patch) | |
tree | 7eb579ded346186c26e65ecd3ce0b882904f3301 /src/conversation | |
parent | 3cf47c04e2de3e3f275398f4dbc223fdaeea6aff (diff) | |
download | gnunet-0f45038d25da3d3de3f83d04bcf30eca5da361d0.tar.gz gnunet-0f45038d25da3d3de3f83d04bcf30eca5da361d0.zip |
-fix coverity
Diffstat (limited to 'src/conversation')
-rw-r--r-- | src/conversation/gnunet-service-conversation.c | 19 |
1 files changed, 13 insertions, 6 deletions
diff --git a/src/conversation/gnunet-service-conversation.c b/src/conversation/gnunet-service-conversation.c index a551bed1a..1fff8bd26 100644 --- a/src/conversation/gnunet-service-conversation.c +++ b/src/conversation/gnunet-service-conversation.c | |||
@@ -738,7 +738,7 @@ handle_client_audio_message (void *cls, const struct ClientAudioMessage *msg) | |||
738 | static enum GNUNET_GenericReturnValue | 738 | static enum GNUNET_GenericReturnValue |
739 | check_cadet_ring_message (void *cls, const struct CadetPhoneRingMessage *msg) | 739 | check_cadet_ring_message (void *cls, const struct CadetPhoneRingMessage *msg) |
740 | { | 740 | { |
741 | //FIXME | 741 | // FIXME |
742 | return GNUNET_OK; | 742 | return GNUNET_OK; |
743 | } | 743 | } |
744 | 744 | ||
@@ -1181,6 +1181,18 @@ handle_client_call_message (void *cls, const struct ClientCallMessage *msg) | |||
1181 | rs.target_peer = msg->target; | 1181 | rs.target_peer = msg->target; |
1182 | rs.expiration_time = | 1182 | rs.expiration_time = |
1183 | GNUNET_TIME_absolute_hton (GNUNET_TIME_relative_to_absolute (RING_TIMEOUT)); | 1183 | GNUNET_TIME_absolute_hton (GNUNET_TIME_relative_to_absolute (RING_TIMEOUT)); |
1184 | key_len = ntohl (msg->key_len); | ||
1185 | if (GNUNET_SYSERR == | ||
1186 | GNUNET_IDENTITY_read_private_key_from_buffer (&msg[1], | ||
1187 | key_len, | ||
1188 | &caller_id, | ||
1189 | &read)) | ||
1190 | { | ||
1191 | GNUNET_break_op (0); | ||
1192 | GNUNET_free (ch); | ||
1193 | GNUNET_SERVICE_client_drop (line->client); | ||
1194 | return; | ||
1195 | } | ||
1184 | ch->line = line; | 1196 | ch->line = line; |
1185 | GNUNET_CONTAINER_DLL_insert (line->channel_head, line->channel_tail, ch); | 1197 | GNUNET_CONTAINER_DLL_insert (line->channel_head, line->channel_tail, ch); |
1186 | ch->status = CS_CALLER_CALLING; | 1198 | ch->status = CS_CALLER_CALLING; |
@@ -1192,11 +1204,6 @@ handle_client_call_message (void *cls, const struct ClientCallMessage *msg) | |||
1192 | &inbound_end, | 1204 | &inbound_end, |
1193 | cadet_handlers); | 1205 | cadet_handlers); |
1194 | ch->mq = GNUNET_CADET_get_mq (ch->channel); | 1206 | ch->mq = GNUNET_CADET_get_mq (ch->channel); |
1195 | key_len = ntohl (msg->key_len); | ||
1196 | GNUNET_IDENTITY_read_private_key_from_buffer (&msg[1], | ||
1197 | key_len, | ||
1198 | &caller_id, | ||
1199 | &read); | ||
1200 | GNUNET_assert (read == key_len); | 1207 | GNUNET_assert (read == key_len); |
1201 | GNUNET_IDENTITY_sign (&caller_id, &rs, &sig); | 1208 | GNUNET_IDENTITY_sign (&caller_id, &rs, &sig); |
1202 | sig_len = GNUNET_IDENTITY_signature_get_length (&sig); | 1209 | sig_len = GNUNET_IDENTITY_signature_get_length (&sig); |