clarify prettyprinter API and protocols, make sure implementations are consistent in their implemenation, doxygen fixes, indentation fixes, subtle semantic fixes

1 files changed, 15 insertions, 9 deletions

diff --git a/src/transport/plugin_transport_http_common.c b/src/transport/plugin_transport_http_common.c
index f5712db58..02129f37d 100644
--- a/src/transport/plugin_transport_http_common.c
+++ b/src/transport/plugin_transport_http_common.c
@@ -207,18 +207,24 @@ http_common_plugin_address_pretty_printer (void *cls,
                                            void *asc_cls)
 {
   const struct HttpAddress *address = addr;
-
-  if (NULL
-      == http_common_plugin_address_to_string (NULL, type, address, addrlen))
-    asc (asc_cls, NULL, GNUNET_SYSERR);
-  else
-    asc (asc_cls,
-        http_common_plugin_address_to_string (NULL, type, address, addrlen),
-        GNUNET_OK);
-  asc (asc_cls, NULL, GNUNET_OK);
+  const char *ret;
+
+  ret = http_common_plugin_address_to_string (NULL,
+                                              type,
+                                              address,
+                                              addrlen);
+  asc (asc_cls,
+       NULL,
+       (NULL == ret) ? GNUNET_SYSERR : GNUNET_OK);
+  asc (asc_cls,
+       NULL,
+       GNUNET_OK);
 }
 
 
+/**
+ * FIXME.
+ */
 const char *
 http_common_plugin_address_to_url (void *cls,
                                    const void *addr,