aboutsummaryrefslogtreecommitdiff
path: root/src/transport
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2015-02-13 00:11:53 +0000
committerChristian Grothoff <christian@grothoff.org>2015-02-13 00:11:53 +0000
commit3e693f3ceb1b3425b17900423628aecb609f2433 (patch)
tree2dd5d5694771de9458eb8c394ce704dea1d0c87e /src/transport
parentc1fa22fd40d14035c8d323cb4ae8724970850e73 (diff)
downloadgnunet-3e693f3ceb1b3425b17900423628aecb609f2433.tar.gz
gnunet-3e693f3ceb1b3425b17900423628aecb609f2433.zip
-fixing misc minor bugs and style issues (unchecked return values, memory leaks, dead code
Diffstat (limited to 'src/transport')
-rw-r--r--src/transport/gnunet-service-transport_validation.c1
-rw-r--r--src/transport/gnunet-transport.c11
-rw-r--r--src/transport/plugin_transport_tcp.c4
-rw-r--r--src/transport/plugin_transport_unix.c1
4 files changed, 4 insertions, 13 deletions
diff --git a/src/transport/gnunet-service-transport_validation.c b/src/transport/gnunet-service-transport_validation.c
index 8f563de02..2022a8c47 100644
--- a/src/transport/gnunet-service-transport_validation.c
+++ b/src/transport/gnunet-service-transport_validation.c
@@ -578,6 +578,7 @@ transmit_ping_if_allowed (void *cls,
578 ve->address->address, 578 ve->address->address,
579 ve->address->address_length); 579 ve->address->address_length);
580 papi = GST_plugins_find (ve->address->transport_name); 580 papi = GST_plugins_find (ve->address->transport_name);
581 GNUNET_assert (NULL != papi);
581 session = papi->get_session (papi->cls, 582 session = papi->get_session (papi->cls,
582 ve->address); 583 ve->address);
583 if (NULL == session) 584 if (NULL == session)
diff --git a/src/transport/gnunet-transport.c b/src/transport/gnunet-transport.c
index 8e8c173af..bf586b7f0 100644
--- a/src/transport/gnunet-transport.c
+++ b/src/transport/gnunet-transport.c
@@ -940,17 +940,6 @@ process_validation_cb (void *cls,
940 _("Monitor disconnected from transport service. Reconnecting.\n")); 940 _("Monitor disconnected from transport service. Reconnecting.\n"));
941 return; 941 return;
942 } 942 }
943
944 /* done */
945 vic = NULL;
946 if (NULL != end)
947 GNUNET_SCHEDULER_cancel (end);
948 end = GNUNET_SCHEDULER_add_now (&shutdown_task, NULL);
949 return;
950 }
951 if (NULL == address)
952 {
953 /* invalid response */
954 vic = NULL; 943 vic = NULL;
955 if (NULL != end) 944 if (NULL != end)
956 GNUNET_SCHEDULER_cancel (end); 945 GNUNET_SCHEDULER_cancel (end);
diff --git a/src/transport/plugin_transport_tcp.c b/src/transport/plugin_transport_tcp.c
index 167d1c490..313cbf7f0 100644
--- a/src/transport/plugin_transport_tcp.c
+++ b/src/transport/plugin_transport_tcp.c
@@ -1752,7 +1752,7 @@ tcp_plugin_get_session (void *cls,
1752 plugin->cur_connections++; 1752 plugin->cur_connections++;
1753 if (plugin->cur_connections == plugin->max_connections) 1753 if (plugin->cur_connections == plugin->max_connections)
1754 { 1754 {
1755 GNUNET_STATISTICS_update (session->plugin->env->stats, 1755 GNUNET_STATISTICS_update (plugin->env->stats,
1756 gettext_noop ("# TCP service suspended"), 1756 gettext_noop ("# TCP service suspended"),
1757 1, 1757 1,
1758 GNUNET_NO); 1758 GNUNET_NO);
@@ -2330,7 +2330,7 @@ handle_tcp_welcome (void *cls,
2330 { 2330 {
2331 GNUNET_log (GNUNET_ERROR_TYPE_WARNING, 2331 GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
2332 _("TCP connection limit reached, suspending server\n")); 2332 _("TCP connection limit reached, suspending server\n"));
2333 GNUNET_STATISTICS_update (session->plugin->env->stats, 2333 GNUNET_STATISTICS_update (plugin->env->stats,
2334 gettext_noop ("# TCP service suspended"), 2334 gettext_noop ("# TCP service suspended"),
2335 1, 2335 1,
2336 GNUNET_NO); 2336 GNUNET_NO);
diff --git a/src/transport/plugin_transport_unix.c b/src/transport/plugin_transport_unix.c
index ddb5f747c..1866c56a4 100644
--- a/src/transport/plugin_transport_unix.c
+++ b/src/transport/plugin_transport_unix.c
@@ -1383,6 +1383,7 @@ unix_transport_server_start (void *cls)
1383 if (NULL == plugin->unix_sock.desc) 1383 if (NULL == plugin->unix_sock.desc)
1384 { 1384 {
1385 GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "socket"); 1385 GNUNET_log_strerror (GNUNET_ERROR_TYPE_ERROR, "socket");
1386 GNUNET_free (un);
1386 return GNUNET_SYSERR; 1387 return GNUNET_SYSERR;
1387 } 1388 }
1388 if ('\0' != un->sun_path[0]) 1389 if ('\0' != un->sun_path[0])