TESTING: Sanitize API. Add new GNUNET_TESTING_command_new API

This commit changes the label member of GNUNET_TRANSPORT_Command to a
static, fixed length buffer allocated with the struct itself.
The check for the end of a command array should be done by checking the
run command instead of the label.

5 files changed, 30 insertions, 51 deletions

diff --git a/src/transport/transport_api_cmd_backchannel_check.c b/src/transport/transport_api_cmd_backchannel_check.c
index e67d9a79c..9f62281a4 100644
--- a/src/transport/transport_api_cmd_backchannel_check.c
+++ b/src/transport/transport_api_cmd_backchannel_check.c
@@ -545,14 +545,10 @@ GNUNET_TRANSPORT_cmd_backchannel_check (const char *label,
   cs->node_n = node_n;
   cs->namespace_n = namespace_n;
 
-  struct GNUNET_TESTING_Command cmd = {
-    .cls = cs,
-    .label = GNUNET_strdup (label),
-    .run = &backchannel_check_run,
-    .ac = &cs->ac,
-    .cleanup = &backchannel_check_cleanup,
-    .traits = &backchannel_check_traits
-  };
-
-  return cmd;
+  return GNUNET_TESTING_command_new (cs,
+                                     label,
+                                     &backchannel_check_run,
+                                     &backchannel_check_cleanup,
+                                     &backchannel_check_traits,
+                                     &cs->ac);
 }
diff --git a/src/transport/transport_api_cmd_connecting_peers.c b/src/transport/transport_api_cmd_connecting_peers.c
index d610bbcb7..528e05b5f 100644
--- a/src/transport/transport_api_cmd_connecting_peers.c
+++ b/src/transport/transport_api_cmd_connecting_peers.c
@@ -251,16 +251,10 @@ GNUNET_TRANSPORT_cmd_connect_peers (const char *label,
   cps->notify_connect = notify_connect;
   cps->additional_connects = additional_connects;
 
-  {
-    struct GNUNET_TESTING_Command cmd = {
-      .cls = cps,
-      .label = GNUNET_strdup (label),
-      .run = &connect_peers_run,
-      .ac = &cps->ac,
-      .cleanup = &connect_peers_cleanup,
-      .traits = &connect_peers_traits
-    };
-
-    return cmd;
-  }
+  return GNUNET_TESTING_command_new (cps,
+                                     label,
+                                     &connect_peers_run,
+                                     &connect_peers_cleanup,
+                                     &connect_peers_traits,
+                                     &cps->ac);
 }
diff --git a/src/transport/transport_api_cmd_send_simple.c b/src/transport/transport_api_cmd_send_simple.c
index 73edcf549..2671727c0 100644
--- a/src/transport/transport_api_cmd_send_simple.c
+++ b/src/transport/transport_api_cmd_send_simple.c
@@ -153,12 +153,10 @@ GNUNET_TRANSPORT_cmd_send_simple (const char *label,
   sss->create_label = create_label;
   sss->topology = topology;
 
-  struct GNUNET_TESTING_Command cmd = {
-    .cls = sss,
-    .label = GNUNET_strdup (label),
-    .run = &send_simple_run,
-    .cleanup = &send_simple_cleanup
-  };
-
-  return cmd;
+  return GNUNET_TESTING_command_new (sss,
+                                     label,
+                                     &send_simple_run,
+                                     &send_simple_cleanup,
+                                     NULL,
+                                     NULL);
 }
diff --git a/src/transport/transport_api_cmd_start_peer.c b/src/transport/transport_api_cmd_start_peer.c
index 7de1d842e..0677b6227 100644
--- a/src/transport/transport_api_cmd_start_peer.c
+++ b/src/transport/transport_api_cmd_start_peer.c
@@ -469,15 +469,10 @@ GNUNET_TRANSPORT_cmd_start_peer (const char *label,
                    handlers,
                    i * sizeof(struct GNUNET_MQ_MessageHandler));
   }
-
-  struct GNUNET_TESTING_Command cmd = {
-    .cls = sps,
-    .label = GNUNET_strdup (label),
-    .run = &start_peer_run,
-    .ac = &sps->ac,
-    .cleanup = &start_peer_cleanup,
-    .traits = &start_peer_traits
-  };
-
-  return cmd;
+  return GNUNET_TESTING_command_new (sps,
+                                     label,
+                                     &start_peer_run,
+                                     &start_peer_cleanup,
+                                     &start_peer_traits,
+                                     &sps->ac);
 }
diff --git a/src/transport/transport_api_cmd_stop_peer.c b/src/transport/transport_api_cmd_stop_peer.c
index 04c822155..1fdd48fa6 100644
--- a/src/transport/transport_api_cmd_stop_peer.c
+++ b/src/transport/transport_api_cmd_stop_peer.c
@@ -143,14 +143,10 @@ GNUNET_TRANSPORT_cmd_stop_peer (const char *label,
 
   sps = GNUNET_new (struct StopPeerState);
   sps->start_label = start_label;
-  {
-    struct GNUNET_TESTING_Command cmd = {
-      .cls = sps,
-      .label = GNUNET_strdup (label),
-      .run = &stop_peer_run,
-      .cleanup = &stop_peer_cleanup,
-      .traits = &stop_peer_traits
-    };
-    return cmd;
-  }
+  return GNUNET_TESTING_command_new (sps,
+                                     label,
+                                     &stop_peer_run,
+                                     &stop_peer_cleanup,
+                                     &stop_peer_traits,
+                                     NULL);
 }