aboutsummaryrefslogtreecommitdiff
path: root/src/transport
diff options
context:
space:
mode:
authorMartin Schanzenbach <schanzen@gnunet.org>2022-10-18 10:04:57 +0900
committerMartin Schanzenbach <schanzen@gnunet.org>2022-10-18 10:04:57 +0900
commitc9562b8cf7a29f4ec2457cb9d9d4530c24225da1 (patch)
treefb7d0296af5537ddda7e772a46e959c8ed64fbac /src/transport
parent9173da4f8c1f4b50ccd9d61f6fa138904740ecfa (diff)
parentd748b0c920b0581ca65962f34d1f2e94c9a89926 (diff)
downloadgnunet-c9562b8cf7a29f4ec2457cb9d9d4530c24225da1.tar.gz
gnunet-c9562b8cf7a29f4ec2457cb9d9d4530c24225da1.zip
-fix conflict
Diffstat (limited to 'src/transport')
-rw-r--r--src/transport/gnunet-communicator-tcp.c16
-rw-r--r--src/transport/gnunet-communicator-udp.c12
-rw-r--r--src/transport/gnunet-service-tng.c32
-rw-r--r--src/transport/gnunet-service-transport.c7
-rw-r--r--src/transport/gnunet-service-transport_ats.c14
-rw-r--r--src/transport/gnunet-service-transport_ats.h3
-rw-r--r--src/transport/gnunet-service-transport_hello.c10
-rw-r--r--src/transport/gnunet-service-transport_manipulation.c4
-rw-r--r--src/transport/gnunet-service-transport_neighbours.c24
-rw-r--r--src/transport/gnunet-service-transport_neighbours.h2
-rw-r--r--src/transport/gnunet-service-transport_plugins.c19
-rw-r--r--src/transport/gnunet-service-transport_plugins.h4
-rw-r--r--src/transport/plugin_transport_http_client.c6
-rw-r--r--src/transport/plugin_transport_http_common.c45
-rw-r--r--src/transport/plugin_transport_http_common.h6
-rw-r--r--src/transport/plugin_transport_http_server.c2
-rw-r--r--src/transport/plugin_transport_tcp.c2
-rw-r--r--src/transport/plugin_transport_udp.c2
-rw-r--r--src/transport/tcp_server_legacy.c20
-rw-r--r--src/transport/transport-testing-cmds.h10
-rw-r--r--src/transport/transport-testing-communicator.c15
-rw-r--r--src/transport/transport-testing-filenames.c28
-rw-r--r--src/transport/transport-testing-main.c2
-rw-r--r--src/transport/transport-testing-main2.c2
-rw-r--r--src/transport/transport-testing2.c33
-rw-r--r--src/transport/transport-testing2.h2
-rw-r--r--src/transport/transport_api2_communication.c80
-rw-r--r--src/transport/transport_api_address_to_string.c4
-rw-r--r--src/transport/transport_api_cmd_backchannel_check.c12
-rw-r--r--src/transport/transport_api_cmd_connecting_peers.c11
-rw-r--r--src/transport/transport_api_cmd_send_simple.c10
-rw-r--r--src/transport/transport_api_core.c2
-rw-r--r--src/transport/transport_api_monitor_peers.c26
-rw-r--r--src/transport/transport_api_monitor_plugins.c4
-rw-r--r--src/transport/transport_api_offer_hello.c5
35 files changed, 57 insertions, 419 deletions
diff --git a/src/transport/gnunet-communicator-tcp.c b/src/transport/gnunet-communicator-tcp.c
index 2a5290bf9..4820caf70 100644
--- a/src/transport/gnunet-communicator-tcp.c
+++ b/src/transport/gnunet-communicator-tcp.c
@@ -981,7 +981,7 @@ queue_destroy (struct Queue *queue)
981 * @param[in,out] hmac_secret secret for HMAC calculation 981 * @param[in,out] hmac_secret secret for HMAC calculation
982 * @param buf buffer to MAC 982 * @param buf buffer to MAC
983 * @param buf_size number of bytes in @a buf 983 * @param buf_size number of bytes in @a buf
984 * @param smac[out] where to write the HMAC 984 * @param[out] smac where to write the HMAC
985 */ 985 */
986static void 986static void
987calculate_hmac (struct GNUNET_HashCode *hmac_secret, 987calculate_hmac (struct GNUNET_HashCode *hmac_secret,
@@ -1155,8 +1155,8 @@ pass_plaintext_to_core (struct Queue *queue,
1155 * 1155 *
1156 * @param dh shared secret 1156 * @param dh shared secret
1157 * @param pid decrypting peer's identity 1157 * @param pid decrypting peer's identity
1158 * @param cipher[out] cipher to initialize 1158 * @param[out] cipher cipher to initialize
1159 * @param hmac_key[out] HMAC key to initialize 1159 * @param[out] hmac_key HMAC key to initialize
1160 */ 1160 */
1161static void 1161static void
1162setup_cipher (const struct GNUNET_HashCode *dh, 1162setup_cipher (const struct GNUNET_HashCode *dh,
@@ -1287,7 +1287,7 @@ rekey_monotime_cb (void *cls,
1287 * Setup cipher of @a queue for decryption. 1287 * Setup cipher of @a queue for decryption.
1288 * 1288 *
1289 * @param ephemeral ephemeral key we received from the other peer 1289 * @param ephemeral ephemeral key we received from the other peer
1290 * @param queue[in,out] queue to initialize decryption cipher for 1290 * @param[in,out] queue queue to initialize decryption cipher for
1291 */ 1291 */
1292static void 1292static void
1293setup_in_cipher (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral, 1293setup_in_cipher (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral,
@@ -1448,8 +1448,8 @@ handshake_ack_monotime_cb (void *cls,
1448 * @param queue The queue context. 1448 * @param queue The queue context.
1449 */ 1449 */
1450static void 1450static void
1451send_challenge (struct GNUNET_CRYPTO_ChallengeNonceP challenge, struct 1451send_challenge (struct GNUNET_CRYPTO_ChallengeNonceP challenge,
1452 Queue *queue) 1452 struct Queue *queue)
1453{ 1453{
1454 struct TCPConfirmationAck tca; 1454 struct TCPConfirmationAck tca;
1455 struct TcpHandshakeAckSignature thas; 1455 struct TcpHandshakeAckSignature thas;
@@ -2613,7 +2613,7 @@ handshake_monotime_cb (void *cls,
2613 * Note that #setup_in_cipher() must have already been called. 2613 * Note that #setup_in_cipher() must have already been called.
2614 * 2614 *
2615 * @param queue queue to decrypt initial bytes from other peer for 2615 * @param queue queue to decrypt initial bytes from other peer for
2616 * @param tc[out] where to store the result 2616 * @param[out] tc where to store the result
2617 * @param ibuf incoming data, of size 2617 * @param ibuf incoming data, of size
2618 * `INITIAL_KX_SIZE` 2618 * `INITIAL_KX_SIZE`
2619 * @return #GNUNET_OK if the signature was OK, #GNUNET_SYSERR if not 2619 * @return #GNUNET_OK if the signature was OK, #GNUNET_SYSERR if not
@@ -3179,7 +3179,7 @@ enc_notify_cb (void *cls,
3179 * a function to call whenever our set of 'valid' addresses changes. 3179 * a function to call whenever our set of 'valid' addresses changes.
3180 * 3180 *
3181 * @param cls closure 3181 * @param cls closure
3182 * @param app_ctx[in,out] location where the app can store stuff 3182 * @param[in,out] app_ctx location where the app can store stuff
3183 * on add and retrieve it on remove 3183 * on add and retrieve it on remove
3184 * @param add_remove #GNUNET_YES to add a new public IP address, 3184 * @param add_remove #GNUNET_YES to add a new public IP address,
3185 * #GNUNET_NO to remove a previous (now invalid) one 3185 * #GNUNET_NO to remove a previous (now invalid) one
diff --git a/src/transport/gnunet-communicator-udp.c b/src/transport/gnunet-communicator-udp.c
index 07beeac38..2748a6594 100644
--- a/src/transport/gnunet-communicator-udp.c
+++ b/src/transport/gnunet-communicator-udp.c
@@ -998,7 +998,7 @@ kce_destroy (struct KeyCacheEntry *kce)
998 * 998 *
999 * @param msec master secret for HMAC calculation 999 * @param msec master secret for HMAC calculation
1000 * @param serial number for the @a smac calculation 1000 * @param serial number for the @a smac calculation
1001 * @param kid[out] where to write the key ID 1001 * @param[out] kid where to write the key ID
1002 */ 1002 */
1003static void 1003static void
1004get_kid (const struct GNUNET_HashCode *msec, 1004get_kid (const struct GNUNET_HashCode *msec,
@@ -1130,8 +1130,8 @@ sender_destroy (struct SenderAddress *sender)
1130 * 1130 *
1131 * @param msec master secret for calculation 1131 * @param msec master secret for calculation
1132 * @param serial number for the @a smac calculation 1132 * @param serial number for the @a smac calculation
1133 * @param key[out] where to write the decryption key 1133 * @param[out] key where to write the decryption key
1134 * @param iv[out] where to write the IV 1134 * @param[out] iv where to write the IV
1135 */ 1135 */
1136static void 1136static void
1137get_iv_key (const struct GNUNET_HashCode *msec, 1137get_iv_key (const struct GNUNET_HashCode *msec,
@@ -1237,7 +1237,7 @@ check_timeouts (void *cls)
1237/** 1237/**
1238 * Calculate cmac from master in @a ss. 1238 * Calculate cmac from master in @a ss.
1239 * 1239 *
1240 * @param ss[in,out] data structure to complete 1240 * @param[in,out] ss data structure to complete
1241 */ 1241 */
1242static void 1242static void
1243calculate_cmac (struct SharedSecret *ss) 1243calculate_cmac (struct SharedSecret *ss)
@@ -1397,7 +1397,7 @@ setup_shared_secret_dec (const struct GNUNET_CRYPTO_EcdhePublicKey *ephemeral)
1397 * Setup shared secret for encryption. 1397 * Setup shared secret for encryption.
1398 * 1398 *
1399 * @param ephemeral ephemeral key we are sending to the other peer 1399 * @param ephemeral ephemeral key we are sending to the other peer
1400 * @param receiver[in,out] queue to initialize encryption key for 1400 * @param[in,out] receiver queue to initialize encryption key for
1401 * @return new shared secret 1401 * @return new shared secret
1402 */ 1402 */
1403static struct SharedSecret * 1403static struct SharedSecret *
@@ -2198,7 +2198,7 @@ setup_sender (const struct GNUNET_PeerIdentity *target,
2198/** 2198/**
2199 * Check signature from @a uc against @a ephemeral. 2199 * Check signature from @a uc against @a ephemeral.
2200 * 2200 *
2201 * @param ephermal key that is signed 2201 * @param ephemeral key that is signed
2202 * @param uc signature of claimant 2202 * @param uc signature of claimant
2203 * @return #GNUNET_OK if signature is valid 2203 * @return #GNUNET_OK if signature is valid
2204 */ 2204 */
diff --git a/src/transport/gnunet-service-tng.c b/src/transport/gnunet-service-tng.c
index ae4d65bcf..5976bd5b1 100644
--- a/src/transport/gnunet-service-tng.c
+++ b/src/transport/gnunet-service-tng.c
@@ -3296,7 +3296,7 @@ struct MonitorEvent
3296 3296
3297 3297
3298/** 3298/**
3299 * Free a @dvh. Callers MAY want to check if this was the last path to the 3299 * Free a @a dvh. Callers MAY want to check if this was the last path to the
3300 * `target`, and if so call #free_dv_route to also free the associated DV 3300 * `target`, and if so call #free_dv_route to also free the associated DV
3301 * entry in #dv_routes (if not, the associated scheduler job should eventually 3301 * entry in #dv_routes (if not, the associated scheduler job should eventually
3302 * take care of it). 3302 * take care of it).
@@ -4136,7 +4136,7 @@ client_send_response (struct PendingMessage *pm)
4136 * 4136 *
4137 * @param dv data structure to pick paths from 4137 * @param dv data structure to pick paths from
4138 * @param options constraints to satisfy 4138 * @param options constraints to satisfy
4139 * @param hops_array[out] set to the result 4139 * @param[out] hops_array set to the result
4140 * @param hops_array_length length of the @a hops_array 4140 * @param hops_array_length length of the @a hops_array
4141 * @return number of entries set in @a hops_array 4141 * @return number of entries set in @a hops_array
4142 */ 4142 */
@@ -4404,7 +4404,7 @@ check_communicator_backchannel (
4404 * Ensure ephemeral keys in our @a dv are current. If no current one exists, 4404 * Ensure ephemeral keys in our @a dv are current. If no current one exists,
4405 * set it up. 4405 * set it up.
4406 * 4406 *
4407 * @param dv[in,out] virtual link to update ephemeral for 4407 * @param[in,out] dv virtual link to update ephemeral for
4408 */ 4408 */
4409static void 4409static void
4410update_ephemeral (struct DistanceVector *dv) 4410update_ephemeral (struct DistanceVector *dv)
@@ -4637,7 +4637,7 @@ struct DVKeyState
4637 * 4637 *
4638 * @param km raw master secret 4638 * @param km raw master secret
4639 * @param iv initialization vector 4639 * @param iv initialization vector
4640 * @param key[out] symmetric cipher and HMAC state to generate 4640 * @param[out] key symmetric cipher and HMAC state to generate
4641 */ 4641 */
4642static void 4642static void
4643dv_setup_key_state_from_km (const struct GNUNET_HashCode *km, 4643dv_setup_key_state_from_km (const struct GNUNET_HashCode *km,
@@ -4679,7 +4679,7 @@ dv_setup_key_state_from_km (const struct GNUNET_HashCode *km,
4679 * @param priv_ephemeral ephemeral private key to use 4679 * @param priv_ephemeral ephemeral private key to use
4680 * @param target the target peer to encrypt to 4680 * @param target the target peer to encrypt to
4681 * @param iv unique IV to use 4681 * @param iv unique IV to use
4682 * @param key[out] set to the key material 4682 * @param[out] key set to the key material
4683 */ 4683 */
4684static void 4684static void
4685dh_key_derive_eph_pid ( 4685dh_key_derive_eph_pid (
@@ -4704,7 +4704,7 @@ dh_key_derive_eph_pid (
4704 * @param priv_ephemeral ephemeral private key to use 4704 * @param priv_ephemeral ephemeral private key to use
4705 * @param target the target peer to encrypt to 4705 * @param target the target peer to encrypt to
4706 * @param iv unique IV to use 4706 * @param iv unique IV to use
4707 * @param key[out] set to the key material 4707 * @param[out] key set to the key material
4708 */ 4708 */
4709static void 4709static void
4710dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral, 4710dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral,
@@ -4725,7 +4725,7 @@ dh_key_derive_eph_pub (const struct GNUNET_CRYPTO_EcdhePublicKey *pub_ephemeral,
4725 * material from @a key. 4725 * material from @a key.
4726 * 4726 *
4727 * @param key key material (from DH) 4727 * @param key key material (from DH)
4728 * @param hmac[out] set to the HMAC 4728 * @param[out] hmac set to the HMAC
4729 * @param data data to perform HMAC calculation over 4729 * @param data data to perform HMAC calculation over
4730 * @param data_size number of bytes in @a data 4730 * @param data_size number of bytes in @a data
4731 */ 4731 */
@@ -4743,7 +4743,7 @@ dv_hmac (const struct DVKeyState *key,
4743 * Perform backchannel encryption using symmetric secret in @a key 4743 * Perform backchannel encryption using symmetric secret in @a key
4744 * to encrypt data from @a in to @a dst. 4744 * to encrypt data from @a in to @a dst.
4745 * 4745 *
4746 * @param key[in,out] key material to use 4746 * @param[in,out] key key material to use
4747 * @param dst where to write the result 4747 * @param dst where to write the result
4748 * @param in input data to encrypt (plaintext) 4748 * @param in input data to encrypt (plaintext)
4749 * @param in_size number of bytes of input in @a in and available at @a dst 4749 * @param in_size number of bytes of input in @a in and available at @a dst
@@ -4760,9 +4760,9 @@ dv_encrypt (struct DVKeyState *key, const void *in, void *dst, size_t in_size)
4760 * Perform backchannel encryption using symmetric secret in @a key 4760 * Perform backchannel encryption using symmetric secret in @a key
4761 * to encrypt data from @a in to @a dst. 4761 * to encrypt data from @a in to @a dst.
4762 * 4762 *
4763 * @param key[in,out] key material to use 4763 * @param[in,out] key key material to use
4764 * @param ciph cipher text to decrypt 4764 * @param ciph cipher text to decrypt
4765 * @param out[out] output data to generate (plaintext) 4765 * @param[out] out output data to generate (plaintext)
4766 * @param out_size number of bytes of input in @a ciph and available in @a out 4766 * @param out_size number of bytes of input in @a ciph and available in @a out
4767 */ 4767 */
4768static void 4768static void
@@ -4815,7 +4815,7 @@ typedef void (*DVMessageHandler) (void *cls,
4815 * @param use function to call with the encapsulated message 4815 * @param use function to call with the encapsulated message
4816 * @param use_cls closure for @a use 4816 * @param use_cls closure for @a use
4817 * @param options whether path must be confirmed or not, to be passed to @a use 4817 * @param options whether path must be confirmed or not, to be passed to @a use
4818 * @param shall this TransportDVBoxMessage be forwarded without flow control. 4818 * @param without_fc shall this TransportDVBoxMessage be forwarded without flow control.
4819 * @return expected RTT for transmission, #GNUNET_TIME_UNIT_FOREVER_REL if sending failed 4819 * @return expected RTT for transmission, #GNUNET_TIME_UNIT_FOREVER_REL if sending failed
4820 */ 4820 */
4821static struct GNUNET_TIME_Relative 4821static struct GNUNET_TIME_Relative
@@ -6274,7 +6274,7 @@ handle_reliability_box (void *cls,
6274 * so, purge ancient statistics (more than GOODPUT_AGING_SLOTS before 6274 * so, purge ancient statistics (more than GOODPUT_AGING_SLOTS before
6275 * the current age) 6275 * the current age)
6276 * 6276 *
6277 * @param pd[in,out] data to update 6277 * @param[in,out] pd data to update
6278 * @param age current age 6278 * @param age current age
6279 */ 6279 */
6280static void 6280static void
@@ -6300,7 +6300,7 @@ update_pd_age (struct PerformanceData *pd, unsigned int age)
6300 * Update @a pd based on the latest @a rtt and the number of bytes 6300 * Update @a pd based on the latest @a rtt and the number of bytes
6301 * that were confirmed to be successfully transmitted. 6301 * that were confirmed to be successfully transmitted.
6302 * 6302 *
6303 * @param pd[in,out] data to update 6303 * @param[in,out] pd data to update
6304 * @param rtt latest round-trip time 6304 * @param rtt latest round-trip time
6305 * @param bytes_transmitted_ok number of bytes receiver confirmed as received 6305 * @param bytes_transmitted_ok number of bytes receiver confirmed as received
6306 */ 6306 */
@@ -7817,7 +7817,7 @@ check_dv_box (void *cls, const struct TransportDVBoxMessage *dvb)
7817 7817
7818/** 7818/**
7819 * Create a DV Box message and queue it for transmission to 7819 * Create a DV Box message and queue it for transmission to
7820 * @ea next_hop. 7820 * @a next_hop.
7821 * 7821 *
7822 * @param next_hop peer to receive the message next 7822 * @param next_hop peer to receive the message next
7823 * @param total_hops how many hops did the message take so far 7823 * @param total_hops how many hops did the message take so far
@@ -8371,7 +8371,7 @@ handle_dv_box (void *cls, const struct TransportDVBoxMessage *dvb)
8371 * Client notified us about transmission from a peer. Process the request. 8371 * Client notified us about transmission from a peer. Process the request.
8372 * 8372 *
8373 * @param cls a `struct TransportClient` which sent us the message 8373 * @param cls a `struct TransportClient` which sent us the message
8374 * @param obm the send message that was sent 8374 * @param im the send message that was sent
8375 * @return #GNUNET_YES if message is well-formed 8375 * @return #GNUNET_YES if message is well-formed
8376 */ 8376 */
8377static int 8377static int
@@ -9597,7 +9597,7 @@ struct PendingMessageScoreContext
9597 * Select the best pending message from @a vl for transmission 9597 * Select the best pending message from @a vl for transmission
9598 * via @a queue. 9598 * via @a queue.
9599 * 9599 *
9600 * @param sc[in,out] best message so far (NULL for none), plus scoring data 9600 * @param[in,out] sc best message so far (NULL for none), plus scoring data
9601 * @param queue the queue that will be used for transmission 9601 * @param queue the queue that will be used for transmission
9602 * @param vl the virtual link providing the messages 9602 * @param vl the virtual link providing the messages
9603 * @param dvh path we are currently considering, or NULL for none 9603 * @param dvh path we are currently considering, or NULL for none
diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index 345a0d949..93790e293 100644
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -2120,7 +2120,7 @@ free_blacklist_entry (void *cls,
2120 * Set traffic metric to manipulate 2120 * Set traffic metric to manipulate
2121 * 2121 *
2122 * @param cls closure 2122 * @param cls closure
2123 * @param message containing information 2123 * @param tm message containing information
2124 */ 2124 */
2125static void 2125static void
2126handle_client_set_metric (void *cls, const struct TrafficMetricMessage *tm) 2126handle_client_set_metric (void *cls, const struct TrafficMetricMessage *tm)
@@ -2486,11 +2486,6 @@ GST_blacklist_test_allowed (const struct GNUNET_PeerIdentity *peer,
2486} 2486}
2487 2487
2488 2488
2489/**
2490 * Cancel a blacklist check.
2491 *
2492 * @param bc check to cancel
2493 */
2494void 2489void
2495GST_blacklist_test_cancel (struct GST_BlacklistCheck *bc) 2490GST_blacklist_test_cancel (struct GST_BlacklistCheck *bc)
2496{ 2491{
diff --git a/src/transport/gnunet-service-transport_ats.c b/src/transport/gnunet-service-transport_ats.c
index 130311e15..2438a0a48 100644
--- a/src/transport/gnunet-service-transport_ats.c
+++ b/src/transport/gnunet-service-transport_ats.c
@@ -477,13 +477,6 @@ GST_ats_add_inbound_address (const struct GNUNET_HELLO_Address *address,
477} 477}
478 478
479 479
480/**
481 * Notify ATS about the new address including the network this address is
482 * located in. The address must NOT be inbound and must be new to ATS.
483 *
484 * @param address the address
485 * @param prop performance information
486 */
487void 480void
488GST_ats_add_address (const struct GNUNET_HELLO_Address *address, 481GST_ats_add_address (const struct GNUNET_HELLO_Address *address,
489 const struct GNUNET_ATS_Properties *prop) 482 const struct GNUNET_ATS_Properties *prop)
@@ -755,13 +748,6 @@ GST_ats_update_distance (const struct GNUNET_HELLO_Address *address,
755} 748}
756 749
757 750
758/**
759 * Notify ATS about @a delay changes to properties of an @a address.
760 * Does nothing if the @a address is not known to us.
761 *
762 * @param address the address
763 * @param delay new delay value
764 */
765void 751void
766GST_ats_update_delay (const struct GNUNET_HELLO_Address *address, 752GST_ats_update_delay (const struct GNUNET_HELLO_Address *address,
767 struct GNUNET_TIME_Relative delay) 753 struct GNUNET_TIME_Relative delay)
diff --git a/src/transport/gnunet-service-transport_ats.h b/src/transport/gnunet-service-transport_ats.h
index d536714ec..ca972d1cc 100644
--- a/src/transport/gnunet-service-transport_ats.h
+++ b/src/transport/gnunet-service-transport_ats.h
@@ -110,7 +110,7 @@ GST_ats_add_inbound_address (const struct GNUNET_HELLO_Address *address,
110 110
111 111
112/** 112/**
113 * Notify ATS about a new address including the network this address is 113 * Notify ATS about a new address including the network the address is
114 * located in. The address must NOT be inbound and must be new to ATS. 114 * located in. The address must NOT be inbound and must be new to ATS.
115 * 115 *
116 * @param address the address 116 * @param address the address
@@ -154,7 +154,6 @@ GST_ats_update_utilization (const struct GNUNET_HELLO_Address *address,
154 * Does nothing if the @a address is not known to us. 154 * Does nothing if the @a address is not known to us.
155 * 155 *
156 * @param address the address 156 * @param address the address
157 * @param session the session
158 * @param delay new delay value 157 * @param delay new delay value
159 */ 158 */
160void 159void
diff --git a/src/transport/gnunet-service-transport_hello.c b/src/transport/gnunet-service-transport_hello.c
index 472c77c27..1e5e8a225 100644
--- a/src/transport/gnunet-service-transport_hello.c
+++ b/src/transport/gnunet-service-transport_hello.c
@@ -334,16 +334,6 @@ GST_hello_modify_addresses (int addremove,
334} 334}
335 335
336 336
337/**
338 * Test if a particular address is one of ours.
339 *
340 * @param address address to test
341 * @param sig location where to cache PONG signatures for this address [set]
342 * @param sig_expiration how long until the current 'sig' expires?
343 * (ZERO if sig was never created) [set]
344 * @return #GNUNET_YES if this is one of our addresses,
345 * #GNUNET_NO if not
346 */
347int 337int
348GST_hello_test_address (const struct GNUNET_HELLO_Address *address, 338GST_hello_test_address (const struct GNUNET_HELLO_Address *address,
349 struct GNUNET_CRYPTO_EddsaSignature **sig, 339 struct GNUNET_CRYPTO_EddsaSignature **sig,
diff --git a/src/transport/gnunet-service-transport_manipulation.c b/src/transport/gnunet-service-transport_manipulation.c
index 04d1774c0..9f39b2dca 100644
--- a/src/transport/gnunet-service-transport_manipulation.c
+++ b/src/transport/gnunet-service-transport_manipulation.c
@@ -168,7 +168,7 @@ static struct GNUNET_SCHEDULER_Task *generic_send_delay_task;
168/** 168/**
169 * Set traffic metric to manipulate 169 * Set traffic metric to manipulate
170 * 170 *
171 * @param message containing information 171 * @param tm message containing information
172 */ 172 */
173void 173void
174GST_manipulation_set_metric (const struct TrafficMetricMessage *tm) 174GST_manipulation_set_metric (const struct TrafficMetricMessage *tm)
@@ -349,7 +349,7 @@ GST_manipulation_send (const struct GNUNET_PeerIdentity *target,
349 * 349 *
350 * @param address binary address 350 * @param address binary address
351 * @param session the session 351 * @param session the session
352 * @param prop[IN|OUT] metrics to modify 352 * @param[in,out] prop metrics to modify
353 */ 353 */
354void 354void
355GST_manipulation_manipulate_metrics (const struct GNUNET_HELLO_Address *address, 355GST_manipulation_manipulate_metrics (const struct GNUNET_HELLO_Address *address,
diff --git a/src/transport/gnunet-service-transport_neighbours.c b/src/transport/gnunet-service-transport_neighbours.c
index ca1b4d1da..e61441d9f 100644
--- a/src/transport/gnunet-service-transport_neighbours.c
+++ b/src/transport/gnunet-service-transport_neighbours.c
@@ -1768,16 +1768,6 @@ GST_neighbours_calculate_receive_delay (const struct
1768} 1768}
1769 1769
1770 1770
1771/**
1772 * Transmit a message to the given target using the active connection.
1773 *
1774 * @param target destination
1775 * @param msg message to send
1776 * @param msg_size number of bytes in msg
1777 * @param timeout when to fail with timeout
1778 * @param cont function to call when done
1779 * @param cont_cls closure for @a cont
1780 */
1781void 1771void
1782GST_neighbours_send (const struct GNUNET_PeerIdentity *target, 1772GST_neighbours_send (const struct GNUNET_PeerIdentity *target,
1783 const void *msg, 1773 const void *msg,
@@ -3019,13 +3009,6 @@ GST_neighbours_notify_data_sent (const struct GNUNET_HELLO_Address *address,
3019} 3009}
3020 3010
3021 3011
3022/**
3023 * Master task run for every neighbour. Performs all of the time-related
3024 * activities (keep alive, send next message, disconnect if idle, finish
3025 * clean up after disconnect).
3026 *
3027 * @param cls the 'struct NeighbourMapEntry' for which we are running
3028 */
3029static void 3012static void
3030master_task (void *cls) 3013master_task (void *cls)
3031{ 3014{
@@ -3646,13 +3629,6 @@ delayed_disconnect (void *cls)
3646} 3629}
3647 3630
3648 3631
3649/**
3650 * We received a quota message from the given peer,
3651 * validate and process.
3652 *
3653 * @param peer sender of the message
3654 * @param msg the quota message
3655 */
3656void 3632void
3657GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer, 3633GST_neighbours_handle_quota_message (const struct GNUNET_PeerIdentity *peer,
3658 const struct GNUNET_MessageHeader *msg) 3634 const struct GNUNET_MessageHeader *msg)
diff --git a/src/transport/gnunet-service-transport_neighbours.h b/src/transport/gnunet-service-transport_neighbours.h
index 13aeab4e6..7ce911aa1 100644
--- a/src/transport/gnunet-service-transport_neighbours.h
+++ b/src/transport/gnunet-service-transport_neighbours.h
@@ -292,7 +292,7 @@ GST_neighbour_get_current_address (const struct GNUNET_PeerIdentity *peer);
292 292
293 293
294/** 294/**
295 * We received a quoat message from the given peer, 295 * We received a quota message from the given peer,
296 * validate and process. 296 * validate and process.
297 * 297 *
298 * @param peer sender of the message 298 * @param peer sender of the message
diff --git a/src/transport/gnunet-service-transport_plugins.c b/src/transport/gnunet-service-transport_plugins.c
index c88532806..218ef80ab 100644
--- a/src/transport/gnunet-service-transport_plugins.c
+++ b/src/transport/gnunet-service-transport_plugins.c
@@ -83,7 +83,6 @@ static struct TransportPlugin *plugins_tail;
83 * 83 *
84 * @param cls closure 84 * @param cls closure
85 * @param address address to update metrics for 85 * @param address address to update metrics for
86 * @param session the session
87 * @param distance new distance 86 * @param distance new distance
88 */ 87 */
89static void 88static void
@@ -121,18 +120,6 @@ plugin_env_address_to_type (void *cls,
121} 120}
122 121
123 122
124/**
125 * Load and initialize all plugins. The respective functions will be
126 * invoked by the plugins when the respective events happen. The
127 * closure will be set to a 'const char*' containing the name of the
128 * plugin that caused the call.
129 *
130 * @param recv_cb function to call when data is received
131 * @param address_cb function to call when our public addresses changed
132 * @param session_start_cb function to call when a session was created
133 * @param session_end_cb function to call when a session was terminated
134 * @param address_type_cb function to call when a address type is requested
135 */
136void 123void
137GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb, 124GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb,
138 GNUNET_TRANSPORT_AddressNotification address_cb, 125 GNUNET_TRANSPORT_AddressNotification address_cb,
@@ -431,12 +418,6 @@ GST_plugins_a2s (const struct GNUNET_HELLO_Address *address)
431} 418}
432 419
433 420
434/**
435 * Register callback with all plugins to monitor their status.
436 *
437 * @param cb callback to register, NULL to unsubscribe
438 * @param cb_cls closure for @a cb
439 */
440void 421void
441GST_plugins_monitor_subscribe (GNUNET_TRANSPORT_SessionInfoCallback cb, 422GST_plugins_monitor_subscribe (GNUNET_TRANSPORT_SessionInfoCallback cb,
442 void *cb_cls) 423 void *cb_cls)
diff --git a/src/transport/gnunet-service-transport_plugins.h b/src/transport/gnunet-service-transport_plugins.h
index 0e69da074..fdd819fc5 100644
--- a/src/transport/gnunet-service-transport_plugins.h
+++ b/src/transport/gnunet-service-transport_plugins.h
@@ -40,13 +40,9 @@
40 * plugin that caused the call. 40 * plugin that caused the call.
41 * 41 *
42 * @param recv_cb function to call when data is received 42 * @param recv_cb function to call when data is received
43 * @param register_quota_cb function to call to register a quota callback
44 * @param unregister_quota_cb function to call to unregister a quota callback
45 * @param address_cb function to call when our public addresses changed 43 * @param address_cb function to call when our public addresses changed
46 * @param session_start_cb function to call when a session was created 44 * @param session_start_cb function to call when a session was created
47 * @param session_end_cb function to call when a session was terminated 45 * @param session_end_cb function to call when a session was terminated
48 * @param address_type_cb function to call when a address type is requested
49 * @param metric_update_cb function to call when address metrics change
50 */ 46 */
51void 47void
52GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb, 48GST_plugins_load (GNUNET_TRANSPORT_PluginReceiveCallback recv_cb,
diff --git a/src/transport/plugin_transport_http_client.c b/src/transport/plugin_transport_http_client.c
index 476a3cd52..82468992b 100644
--- a/src/transport/plugin_transport_http_client.c
+++ b/src/transport/plugin_transport_http_client.c
@@ -556,7 +556,6 @@ client_reschedule_session_timeout (struct GNUNET_ATS_Session *s)
556 * Task performing curl operations 556 * Task performing curl operations
557 * 557 *
558 * @param cls plugin as closure 558 * @param cls plugin as closure
559 * @param tc gnunet scheduler task context
560 */ 559 */
561static void 560static void
562client_run (void *cls); 561client_run (void *cls);
@@ -1289,11 +1288,6 @@ client_receive (void *stream,
1289} 1288}
1290 1289
1291 1290
1292/**
1293 * Task performing curl operations
1294 *
1295 * @param cls plugin as closure
1296 */
1297static void 1291static void
1298client_run (void *cls) 1292client_run (void *cls)
1299{ 1293{
diff --git a/src/transport/plugin_transport_http_common.c b/src/transport/plugin_transport_http_common.c
index 75bf8b74a..40353daeb 100644
--- a/src/transport/plugin_transport_http_common.c
+++ b/src/transport/plugin_transport_http_common.c
@@ -407,20 +407,6 @@ http_common_dns_ip_lookup (const char *name,
407} 407}
408 408
409 409
410/**
411 * Convert the transports address to a nice, human-readable
412 * format.
413 *
414 * @param cls closure
415 * @param type name of the transport that generated the address
416 * @param addr one of the addresses of the host, NULL for the last address
417 * the specific address format depends on the transport
418 * @param addrlen length of the @a addr
419 * @param numeric should (IP) addresses be displayed in numeric form?
420 * @param timeout after how long should we give up?
421 * @param asc function to call on each string
422 * @param asc_cls closure for @a asc
423 */
424void 410void
425http_common_plugin_address_pretty_printer (void *cls, const char *type, 411http_common_plugin_address_pretty_printer (void *cls, const char *type,
426 const void *addr, 412 const void *addr,
@@ -597,17 +583,6 @@ http_common_plugin_address_to_url (void *cls,
597} 583}
598 584
599 585
600/**
601 * Function called for a quick conversion of the binary address to
602 * a numeric address. Note that the caller must not free the
603 * address and that the next call to this function is allowed
604 * to override the address again.
605 *
606 * @param plugin the name of the plugin
607 * @param addr binary address
608 * @param addrlen length of the address
609 * @return string representing the same address
610 */
611const char * 586const char *
612http_common_plugin_address_to_string (const char *plugin, 587http_common_plugin_address_to_string (const char *plugin,
613 const void *addr, 588 const void *addr,
@@ -642,18 +617,6 @@ http_common_plugin_address_to_string (const char *plugin,
642} 617}
643 618
644 619
645/**
646 * Function called to convert a string address to
647 * a binary address.
648 *
649 * @param cls closure ('struct Plugin*')
650 * @param addr string address
651 * @param addrlen length of the @a addr
652 * @param buf location to store the buffer
653 * If the function returns #GNUNET_SYSERR, its contents are undefined.
654 * @param added length of created address
655 * @return #GNUNET_OK on success, #GNUNET_SYSERR on failure
656 */
657int 620int
658http_common_plugin_string_to_address (void *cls, 621http_common_plugin_string_to_address (void *cls,
659 const char *addr, 622 const char *addr,
@@ -721,14 +684,6 @@ http_common_plugin_string_to_address (void *cls,
721} 684}
722 685
723 686
724/**
725 * Create a HTTP address from a socketaddr
726 *
727 * @param protocol protocol
728 * @param addr sockaddr * address
729 * @param addrlen length of the address
730 * @return the HttpAddress
731 */
732struct HttpAddress * 687struct HttpAddress *
733http_common_address_from_socket (const char *protocol, 688http_common_address_from_socket (const char *protocol,
734 const struct sockaddr *addr, 689 const struct sockaddr *addr,
diff --git a/src/transport/plugin_transport_http_common.h b/src/transport/plugin_transport_http_common.h
index 299dc0e68..7a532249d 100644
--- a/src/transport/plugin_transport_http_common.h
+++ b/src/transport/plugin_transport_http_common.h
@@ -137,7 +137,7 @@ http_split_address (const char *addr);
137 * @param type name of the transport that generated the address 137 * @param type name of the transport that generated the address
138 * @param addr one of the addresses of the host, NULL for the last address 138 * @param addr one of the addresses of the host, NULL for the last address
139 * the specific address format depends on the transport 139 * the specific address format depends on the transport
140 * @param addrlen length of the address 140 * @param addrlen length of @a addr
141 * @param numeric should (IP) addresses be displayed in numeric form? 141 * @param numeric should (IP) addresses be displayed in numeric form?
142 * @param timeout after how long should we give up? 142 * @param timeout after how long should we give up?
143 * @param asc function to call on each string 143 * @param asc function to call on each string
@@ -178,7 +178,7 @@ http_common_plugin_address_to_string (const char *plugin,
178 * 178 *
179 * @param cls closure (`struct Plugin*`) 179 * @param cls closure (`struct Plugin*`)
180 * @param addr string address 180 * @param addr string address
181 * @param addrlen length of the address 181 * @param addrlen length of @a addr
182 * @param buf location to store the buffer 182 * @param buf location to store the buffer
183 * If the function returns #GNUNET_SYSERR, its contents are undefined. 183 * If the function returns #GNUNET_SYSERR, its contents are undefined.
184 * @param added length of created address 184 * @param added length of created address
@@ -198,7 +198,7 @@ http_common_plugin_string_to_address (void *cls,
198 * @param protocol protocol 198 * @param protocol protocol
199 * @param addr `sockaddr *` address 199 * @param addr `sockaddr *` address
200 * @param addrlen length of the @a addr 200 * @param addrlen length of the @a addr
201 * @return the string 201 * @return A pointer to a `struct HttpAddress` derived from @a addr
202 */ 202 */
203struct HttpAddress * 203struct HttpAddress *
204http_common_address_from_socket (const char *protocol, 204http_common_address_from_socket (const char *protocol,
diff --git a/src/transport/plugin_transport_http_server.c b/src/transport/plugin_transport_http_server.c
index 78b030e9a..3ad2356b0 100644
--- a/src/transport/plugin_transport_http_server.c
+++ b/src/transport/plugin_transport_http_server.c
@@ -2563,7 +2563,7 @@ server_remove_address (void *cls,
2563 * Our external IP address/port mapping has changed. 2563 * Our external IP address/port mapping has changed.
2564 * 2564 *
2565 * @param cls closure, the 'struct LocalAddrList' 2565 * @param cls closure, the 'struct LocalAddrList'
2566 * @param app_ctx[in,out] location where the app can store stuff 2566 * @param[in,out] app_ctx location where the app can store stuff
2567 * on add and retrieve it on remove 2567 * on add and retrieve it on remove
2568 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean 2568 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean
2569 * the previous (now invalid) one 2569 * the previous (now invalid) one
diff --git a/src/transport/plugin_transport_tcp.c b/src/transport/plugin_transport_tcp.c
index ac4cc672f..ceae64709 100644
--- a/src/transport/plugin_transport_tcp.c
+++ b/src/transport/plugin_transport_tcp.c
@@ -1418,7 +1418,7 @@ notify_session_monitor (struct Plugin *plugin,
1418 * Our external IP address/port mapping has changed. 1418 * Our external IP address/port mapping has changed.
1419 * 1419 *
1420 * @param cls closure, the `struct Plugin` 1420 * @param cls closure, the `struct Plugin`
1421 * @param app_ctx[in,out] location where the app can store stuff 1421 * @param[in,out] app_ctx location where the app can store stuff
1422 * on add and retrieve it on remove 1422 * on add and retrieve it on remove
1423 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean 1423 * @param add_remove #GNUNET_YES to mean the new public IP address, #GNUNET_NO to mean
1424 * the previous (now invalid) one 1424 * the previous (now invalid) one
diff --git a/src/transport/plugin_transport_udp.c b/src/transport/plugin_transport_udp.c
index 2db31caa3..0d3ca449d 100644
--- a/src/transport/plugin_transport_udp.c
+++ b/src/transport/plugin_transport_udp.c
@@ -1254,7 +1254,7 @@ udp_plugin_check_address (void *cls, const void *addr, size_t addrlen)
1254 * Our external IP address/port mapping has changed. 1254 * Our external IP address/port mapping has changed.
1255 * 1255 *
1256 * @param cls closure, the `struct Plugin` 1256 * @param cls closure, the `struct Plugin`
1257 * @param app_ctx[in,out] location where the app can store stuff 1257 * @param[in,out] app_ctx location where the app can store stuff
1258 * on add and retrieve it on remove 1258 * on add and retrieve it on remove
1259 * @param add_remove #GNUNET_YES to mean the new public IP address, 1259 * @param add_remove #GNUNET_YES to mean the new public IP address,
1260 * #GNUNET_NO to mean the previous (now invalid) one 1260 * #GNUNET_NO to mean the previous (now invalid) one
diff --git a/src/transport/tcp_server_legacy.c b/src/transport/tcp_server_legacy.c
index f4d48d4f6..bb572c843 100644
--- a/src/transport/tcp_server_legacy.c
+++ b/src/transport/tcp_server_legacy.c
@@ -699,11 +699,6 @@ GNUNET_SERVER_suspend (struct GNUNET_SERVER_Handle *server)
699} 699}
700 700
701 701
702/**
703 * Resume accepting connections from the listen socket.
704 *
705 * @param server server to stop accepting connections.
706 */
707void 702void
708GNUNET_SERVER_resume (struct GNUNET_SERVER_Handle *server) 703GNUNET_SERVER_resume (struct GNUNET_SERVER_Handle *server)
709{ 704{
@@ -1620,21 +1615,6 @@ transmit_ready_callback_wrapper (void *cls, size_t size, void *buf)
1620} 1615}
1621 1616
1622 1617
1623/**
1624 * Notify us when the server has enough space to transmit
1625 * a message of the given size to the given client.
1626 *
1627 * @param client client to transmit message to
1628 * @param size requested amount of buffer space
1629 * @param timeout after how long should we give up (and call
1630 * notify with buf NULL and size 0)?
1631 * @param callback function to call when space is available
1632 * @param callback_cls closure for @a callback
1633 * @return non-NULL if the notify callback was queued; can be used
1634 * to cancel the request using
1635 * #GNUNET_SERVER_notify_transmit_ready_cancel().
1636 * NULL if we are already going to notify someone else (busy)
1637 */
1638struct GNUNET_SERVER_TransmitHandle * 1618struct GNUNET_SERVER_TransmitHandle *
1639GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client, 1619GNUNET_SERVER_notify_transmit_ready (struct GNUNET_SERVER_Client *client,
1640 size_t size, 1620 size_t size,
diff --git a/src/transport/transport-testing-cmds.h b/src/transport/transport-testing-cmds.h
index 5a3fb22d6..c577feb34 100644
--- a/src/transport/transport-testing-cmds.h
+++ b/src/transport/transport-testing-cmds.h
@@ -227,9 +227,9 @@ GNUNET_TRANSPORT_cmd_stop_peer (const char *label,
227 * 227 *
228 * @param label name for command 228 * @param label name for command
229 * @param start_peer_label Label of the cmd to start a peer. 229 * @param start_peer_label Label of the cmd to start a peer.
230 * @param create_peer_label Label of the cmd which started the test system. 230 * @param create_label Label of the cmd which started the test system.
231 * @param num Number globally identifying the node. 231 * @param num Number globally identifying the node.
232 * @param The topology for the test setup. 232 * @param topology The topology for the test setup.
233 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd. 233 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd.
234 * @return command. 234 * @return command.
235 */ 235 */
@@ -248,9 +248,9 @@ GNUNET_TRANSPORT_cmd_connect_peers (
248 * 248 *
249 * @param label name for command. 249 * @param label name for command.
250 * @param start_peer_label Label of the cmd to start a peer. 250 * @param start_peer_label Label of the cmd to start a peer.
251 * @param create_peer_label Label of the cmd which started the test system. 251 * @param create_label Label of the cmd which started the test system.
252 * @param num Number globally identifying the node. 252 * @param num Number globally identifying the node.
253 * @param The topology for the test setup. 253 * @param topology The topology for the test setup.
254 * @return command. 254 * @return command.
255 */ 255 */
256struct GNUNET_TESTING_Command 256struct GNUNET_TESTING_Command
@@ -271,7 +271,7 @@ GNUNET_TRANSPORT_cmd_send_simple (const char *label,
271 * @param num Number globally identifying the node. 271 * @param num Number globally identifying the node.
272 * @param node_n The number of the node in a network namespace. 272 * @param node_n The number of the node in a network namespace.
273 * @param namespace_n The number of the network namespace. 273 * @param namespace_n The number of the network namespace.
274 * @param The topology for the test setup. 274 * @param topology The topology for the test setup.
275 * @return command. 275 * @return command.
276 */ 276 */
277struct GNUNET_TESTING_Command 277struct GNUNET_TESTING_Command
diff --git a/src/transport/transport-testing-communicator.c b/src/transport/transport-testing-communicator.c
index ce4af01f2..1bf88bb3d 100644
--- a/src/transport/transport-testing-communicator.c
+++ b/src/transport/transport-testing-communicator.c
@@ -232,7 +232,7 @@ check_communicator_backchannel (void *cls,
232 * Pass the message to the client. 232 * Pass the message to the client.
233 * 233 *
234 * @param cls Closure - communicator handle 234 * @param cls Closure - communicator handle
235 * @param msg Message 235 * @param bc_msg Message
236 */ 236 */
237static void 237static void
238handle_communicator_backchannel (void *cls, 238handle_communicator_backchannel (void *cls,
@@ -283,7 +283,7 @@ handle_communicator_backchannel (void *cls,
283 * Address of our peer added. Test message is well-formed. 283 * Address of our peer added. Test message is well-formed.
284 * 284 *
285 * @param cls the client 285 * @param cls the client
286 * @param aam the send message that was sent 286 * @param msg the send message that was sent
287 * @return #GNUNET_OK if message is well-formed 287 * @return #GNUNET_OK if message is well-formed
288 */ 288 */
289static int 289static int
@@ -365,7 +365,7 @@ check_incoming_msg (void *cls,
365 * Pass the message to the client. 365 * Pass the message to the client.
366 * 366 *
367 * @param cls Closure - communicator handle 367 * @param cls Closure - communicator handle
368 * @param msg Message 368 * @param inc_msg Message
369 */ 369 */
370static void 370static void
371handle_incoming_msg (void *cls, 371handle_incoming_msg (void *cls,
@@ -1146,15 +1146,6 @@ GNUNET_TRANSPORT_TESTING_transport_communicator_open_queue (
1146} 1146}
1147 1147
1148 1148
1149/**
1150 * @brief Instruct communicator to send data
1151 *
1152 * @param tc_queue The queue to use for sending
1153 * @param cont function to call when done sending
1154 * @param cont_cls closure for @a cont
1155 * @param payload Data to send
1156 * @param payload_size Size of the @a payload
1157 */
1158void 1149void
1159GNUNET_TRANSPORT_TESTING_transport_communicator_send 1150GNUNET_TRANSPORT_TESTING_transport_communicator_send
1160 (struct GNUNET_TRANSPORT_TESTING_TransportCommunicatorHandle *tc_h, 1151 (struct GNUNET_TRANSPORT_TESTING_TransportCommunicatorHandle *tc_h,
diff --git a/src/transport/transport-testing-filenames.c b/src/transport/transport-testing-filenames.c
index 7c136b690..70c1ee55a 100644
--- a/src/transport/transport-testing-filenames.c
+++ b/src/transport/transport-testing-filenames.c
@@ -61,13 +61,6 @@ extract_filename (const char *file)
61} 61}
62 62
63 63
64/**
65 * Extracts the test filename from an absolute file name and removes
66 * the extension
67 *
68 * @param file absolute file name
69 * @return the result
70 */
71char * 64char *
72GNUNET_TRANSPORT_TESTING_get_test_name (const char *file) 65GNUNET_TRANSPORT_TESTING_get_test_name (const char *file)
73{ 66{
@@ -96,12 +89,6 @@ GNUNET_TRANSPORT_TESTING_get_test_name (const char *file)
96} 89}
97 90
98 91
99/**
100 * Extracts the filename from an absolute file name and removes the extension
101 *
102 * @param file absolute file name
103 * @return the result
104 */
105char * 92char *
106GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file) 93GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file)
107{ 94{
@@ -115,13 +102,6 @@ GNUNET_TRANSPORT_TESTING_get_test_source_name (const char *file)
115} 102}
116 103
117 104
118/**
119 * Extracts the plugin name from an absolute file name and the test name
120 *
121 * @param file absolute file name
122 * @param test test name
123 * @return the result
124 */
125char * 105char *
126GNUNET_TRANSPORT_TESTING_get_test_plugin_name (const char *file, 106GNUNET_TRANSPORT_TESTING_get_test_plugin_name (const char *file,
127 const char *test) 107 const char *test)
@@ -161,14 +141,6 @@ suc:
161} 141}
162 142
163 143
164/**
165 * This function takes the filename (e.g. argv[0), removes a "lt-"-prefix and
166 * if existing ".exe"-prefix and adds the peer-number
167 *
168 * @param file filename of the test, e.g. argv[0]
169 * @param count peer number
170 * @return the result
171 */
172char * 144char *
173GNUNET_TRANSPORT_TESTING_get_config_name (const char *file, 145GNUNET_TRANSPORT_TESTING_get_config_name (const char *file,
174 int count) 146 int count)
diff --git a/src/transport/transport-testing-main.c b/src/transport/transport-testing-main.c
index 20c58eeee..8d1727d77 100644
--- a/src/transport/transport-testing-main.c
+++ b/src/transport/transport-testing-main.c
@@ -253,7 +253,7 @@ my_nc (void *cls,
253 * 253 *
254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` 254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *`
255 * @param peer peer we got disconnected from 255 * @param peer peer we got disconnected from
256 * @param custom_cls return value from @my_nc 256 * @param custom_cls return value from @a my_nc
257 */ 257 */
258static void 258static void
259my_nd (void *cls, 259my_nd (void *cls,
diff --git a/src/transport/transport-testing-main2.c b/src/transport/transport-testing-main2.c
index 62aa3ceb7..de0b7f4cd 100644
--- a/src/transport/transport-testing-main2.c
+++ b/src/transport/transport-testing-main2.c
@@ -253,7 +253,7 @@ my_nc (void *cls,
253 * 253 *
254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` 254 * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *`
255 * @param peer peer we got disconnected from 255 * @param peer peer we got disconnected from
256 * @param custom_cls return value from @my_nc 256 * @param custom_cls return value from @a my_nc
257 */ 257 */
258static void 258static void
259my_nd (void *cls, 259my_nd (void *cls,
diff --git a/src/transport/transport-testing2.c b/src/transport/transport-testing2.c
index 6d41ec098..f0dee7388 100644
--- a/src/transport/transport-testing2.c
+++ b/src/transport/transport-testing2.c
@@ -379,19 +379,6 @@ retrieve_hello (void *cls)
379} 379}
380 380
381 381
382/**
383 * Start a peer with the given configuration
384 * @param tth the testing handle
385 * @param cfgname configuration file
386 * @param peer_id a unique number to identify the peer
387 * @param handlers functions for receiving messages
388 * @param nc connect callback
389 * @param nd disconnect callback
390 * @param cb_cls closure for callback
391 * @param start_cb start callback
392 * @param start_cb_cls closure for callback
393 * @return the peer context
394 */
395struct GNUNET_TRANSPORT_TESTING_PeerContext * 382struct GNUNET_TRANSPORT_TESTING_PeerContext *
396GNUNET_TRANSPORT_TESTING_start_peer (struct 383GNUNET_TRANSPORT_TESTING_start_peer (struct
397 GNUNET_TRANSPORT_TESTING_Handle *tth, 384 GNUNET_TRANSPORT_TESTING_Handle *tth,
@@ -545,14 +532,6 @@ GNUNET_TRANSPORT_TESTING_start_peer (struct
545} 532}
546 533
547 534
548/**
549 * Stops and restarts the given peer, sleeping (!) for 5s in between.
550 *
551 * @param p the peer
552 * @param restart_cb callback to call when restarted
553 * @param restart_cb_cls callback closure
554 * @return #GNUNET_OK in success otherwise #GNUNET_SYSERR
555 */
556int 535int
557GNUNET_TRANSPORT_TESTING_restart_peer (struct 536GNUNET_TRANSPORT_TESTING_restart_peer (struct
558 GNUNET_TRANSPORT_TESTING_PeerContext *p, 537 GNUNET_TRANSPORT_TESTING_PeerContext *p,
@@ -751,11 +730,6 @@ GNUNET_TRANSPORT_TESTING_stop_peer (struct
751 }*/ 730 }*/
752 731
753 732
754/**
755 * Offer the current HELLO of P2 to P1.
756 *
757 * @param cls our `struct GNUNET_TRANSPORT_TESTING_ConnectRequest`
758 */
759static void 733static void
760offer_hello (void *cls) 734offer_hello (void *cls)
761{ 735{
@@ -859,13 +833,6 @@ GNUNET_TRANSPORT_TESTING_connect_peers (struct
859} 833}
860 834
861 835
862/**
863 * Cancel the request to connect two peers
864 * Tou MUST cancel the request if you stop the peers before the peers connected successfully
865 *
866 * @param tth transport testing handle
867 * @param cc a connect request handle
868 */
869void 836void
870GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct 837GNUNET_TRANSPORT_TESTING_connect_peers_cancel (struct
871 GNUNET_TRANSPORT_TESTING_ConnectRequest 838 GNUNET_TRANSPORT_TESTING_ConnectRequest
diff --git a/src/transport/transport-testing2.h b/src/transport/transport-testing2.h
index e2167ca7e..b5db28500 100644
--- a/src/transport/transport-testing2.h
+++ b/src/transport/transport-testing2.h
@@ -288,7 +288,7 @@ GNUNET_TRANSPORT_TESTING_done (struct GNUNET_TRANSPORT_TESTING_Handle *tth);
288 * 288 *
289 * @param tth the testing handle 289 * @param tth the testing handle
290 * @param cfgname configuration file 290 * @param cfgname configuration file
291 * @param peer_id the peer_id 291 * @param peer_id an identification number for the peer
292 * @param handlers functions for receiving messages 292 * @param handlers functions for receiving messages
293 * @param nc connect callback 293 * @param nc connect callback
294 * @param nd disconnect callback 294 * @param nd disconnect callback
diff --git a/src/transport/transport_api2_communication.c b/src/transport/transport_api2_communication.c
index 5bcfb30c7..b79f0d8bf 100644
--- a/src/transport/transport_api2_communication.c
+++ b/src/transport/transport_api2_communication.c
@@ -802,24 +802,6 @@ reconnect (struct GNUNET_TRANSPORT_CommunicatorHandle *ch)
802} 802}
803 803
804 804
805/**
806 * Connect to the transport service.
807 *
808 * @param cfg configuration to use
809 * @param config_section section of the configuration to use for options
810 * @param addr_prefix address prefix for addresses supported by this
811 * communicator, could be NULL for incoming-only communicators
812 * @param cc what characteristics does the communicator have?
813 * @param mtu maximum message size supported by communicator, 0 if
814 * sending is not supported, SIZE_MAX for no MTU
815 * @param mq_init function to call to initialize a message queue given
816 * the address of another peer, can be NULL if the
817 * communicator only supports receiving messages
818 * @param mq_init_cls closure for @a mq_init
819 * @param notify_cb function to pass backchannel messages to communicator
820 * @param notify_cb_cls closure for @a notify_cb
821 * @return NULL on error
822 */
823struct GNUNET_TRANSPORT_CommunicatorHandle * 805struct GNUNET_TRANSPORT_CommunicatorHandle *
824GNUNET_TRANSPORT_communicator_connect ( 806GNUNET_TRANSPORT_communicator_connect (
825 const struct GNUNET_CONFIGURATION_Handle *cfg, 807 const struct GNUNET_CONFIGURATION_Handle *cfg,
@@ -880,26 +862,6 @@ GNUNET_TRANSPORT_communicator_disconnect (
880/* ************************* Receiving *************************** */ 862/* ************************* Receiving *************************** */
881 863
882 864
883/**
884 * Notify transport service that the communicator has received
885 * a message.
886 *
887 * @param ch connection to transport service
888 * @param sender presumed sender of the message (details to be checked
889 * by higher layers)
890 * @param msg the message
891 * @param expected_addr_validity how long does the communicator believe it
892 * will continue to be able to receive messages from the same address
893 * on which it received this message?
894 * @param cb function to call once handling the message is done, NULL if
895 * flow control is not supported by this communicator
896 * @param cb_cls closure for @a cb
897 * @return #GNUNET_OK if all is well, #GNUNET_NO if the message was
898 * immediately dropped due to memory limitations (communicator
899 * should try to apply back pressure),
900 * #GNUNET_SYSERR if the message could not be delivered because
901 * the transport service is not yet up
902 */
903int 865int
904GNUNET_TRANSPORT_communicator_receive ( 866GNUNET_TRANSPORT_communicator_receive (
905 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 867 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -970,25 +932,6 @@ GNUNET_TRANSPORT_communicator_receive (
970/* ************************* Discovery *************************** */ 932/* ************************* Discovery *************************** */
971 933
972 934
973/**
974 * Notify transport service that an MQ became available due to an
975 * "inbound" connection or because the communicator discovered the
976 * presence of another peer.
977 *
978 * @param ch connection to transport service
979 * @param peer peer with which we can now communicate
980 * @param address address in human-readable format, 0-terminated, UTF-8
981 * @param mtu maximum message size supported by queue, 0 if
982 * sending is not supported, SIZE_MAX for no MTU
983 * @param q_len number of messages that can be send through this queue
984 * @param priority queue priority. Queues with highest priority should be
985 * used
986 * @param nt which network type does the @a address belong to?
987 * @param cc what characteristics does the communicator have?
988 * @param cs what is the connection status of the queue?
989 * @param mq message queue of the @a peer
990 * @return API handle identifying the new MQ
991 */
992struct GNUNET_TRANSPORT_QueueHandle * 935struct GNUNET_TRANSPORT_QueueHandle *
993GNUNET_TRANSPORT_communicator_mq_add ( 936GNUNET_TRANSPORT_communicator_mq_add (
994 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 937 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -1023,15 +966,6 @@ GNUNET_TRANSPORT_communicator_mq_add (
1023} 966}
1024 967
1025 968
1026/**
1027 * Notify transport service that an MQ was updated
1028 *
1029 * @param ch connection to transport service
1030 * @param qh the queue to update
1031 * @param q_len number of messages that can be send through this queue
1032 * @param priority queue priority. Queues with highest priority should be
1033 * used
1034 */
1035void 969void
1036GNUNET_TRANSPORT_communicator_mq_update ( 970GNUNET_TRANSPORT_communicator_mq_update (
1037 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 971 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
@@ -1149,20 +1083,6 @@ GNUNET_TRANSPORT_communicator_address_remove_all (
1149/* ************************* Backchannel *************************** */ 1083/* ************************* Backchannel *************************** */
1150 1084
1151 1085
1152/**
1153 * The communicator asks the transport service to route a message via
1154 * a different path to another communicator service at another peer.
1155 * This must only be done for special control traffic (as there is no
1156 * flow control for this API), such as acknowledgements, and generally
1157 * only be done if the communicator is uni-directional (i.e. cannot
1158 * send the message back itself).
1159 *
1160 * @param ch handle of this communicator
1161 * @param pid peer to send the message to
1162 * @param comm name of the communicator to send the message to
1163 * @param header header of the message to transmit and pass via the
1164 * notify-API to @a pid's communicator @a comm
1165 */
1166void 1086void
1167GNUNET_TRANSPORT_communicator_notify ( 1087GNUNET_TRANSPORT_communicator_notify (
1168 struct GNUNET_TRANSPORT_CommunicatorHandle *ch, 1088 struct GNUNET_TRANSPORT_CommunicatorHandle *ch,
diff --git a/src/transport/transport_api_address_to_string.c b/src/transport/transport_api_address_to_string.c
index c7de39ea8..5b234f802 100644
--- a/src/transport/transport_api_address_to_string.c
+++ b/src/transport/transport_api_address_to_string.c
@@ -56,7 +56,7 @@ struct GNUNET_TRANSPORT_AddressToStringContext
56 * Function called with responses from the service. 56 * Function called with responses from the service.
57 * 57 *
58 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *` 58 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *`
59 * @param msg message with the human-readable address 59 * @param atsm message with the human-readable address
60 * @return #GNUNET_OK if message is well-formed 60 * @return #GNUNET_OK if message is well-formed
61 */ 61 */
62static int 62static int
@@ -97,7 +97,7 @@ check_reply (void *cls,
97 * Function called with responses from the service. 97 * Function called with responses from the service.
98 * 98 *
99 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *` 99 * @param cls our `struct GNUNET_TRANSPORT_AddressToStringContext *`
100 * @param msg message with the human-readable address 100 * @param atsm message with the human-readable address
101 */ 101 */
102static void 102static void
103handle_reply (void *cls, 103handle_reply (void *cls,
diff --git a/src/transport/transport_api_cmd_backchannel_check.c b/src/transport/transport_api_cmd_backchannel_check.c
index b285d7abf..1edd6cb7e 100644
--- a/src/transport/transport_api_cmd_backchannel_check.c
+++ b/src/transport/transport_api_cmd_backchannel_check.c
@@ -522,18 +522,6 @@ backchannel_check_cleanup (void *cls)
522} 522}
523 523
524 524
525/**
526 * Create command.
527 *
528 * @param label name for command.
529 * @param start_peer_label Label of the cmd to start a peer.
530 * @param create_label Label of the cmd to create the testing system.
531 * @param num Number globally identifying the node.
532 * @param node_n The number of the node in a network namespace.
533 * @param namespace_n The number of the network namespace.
534 * @param The topology for the test setup.
535 * @return command.
536 */
537struct GNUNET_TESTING_Command 525struct GNUNET_TESTING_Command
538GNUNET_TRANSPORT_cmd_backchannel_check (const char *label, 526GNUNET_TRANSPORT_cmd_backchannel_check (const char *label,
539 const char *start_peer_label, 527 const char *start_peer_label,
diff --git a/src/transport/transport_api_cmd_connecting_peers.c b/src/transport/transport_api_cmd_connecting_peers.c
index 4d9e9c3ab..a6006f698 100644
--- a/src/transport/transport_api_cmd_connecting_peers.c
+++ b/src/transport/transport_api_cmd_connecting_peers.c
@@ -220,17 +220,6 @@ connect_peers_traits (void *cls,
220} 220}
221 221
222 222
223/**
224 * Create command
225 *
226 * @param label name for command
227 * @param start_peer_label Label of the cmd to start a peer.
228 * @param create_peer_label Label of the cmd which started the test system.
229 * @param num Number globally identifying the node.
230 * @param The topology for the test setup.
231 * @param additional_connects Number of additional connects this cmd will wait for not triggered by this cmd.
232 * @return command.
233 */
234struct GNUNET_TESTING_Command 223struct GNUNET_TESTING_Command
235GNUNET_TRANSPORT_cmd_connect_peers (const char *label, 224GNUNET_TRANSPORT_cmd_connect_peers (const char *label,
236 const char *start_peer_label, 225 const char *start_peer_label,
diff --git a/src/transport/transport_api_cmd_send_simple.c b/src/transport/transport_api_cmd_send_simple.c
index a00e1b922..c71c952aa 100644
--- a/src/transport/transport_api_cmd_send_simple.c
+++ b/src/transport/transport_api_cmd_send_simple.c
@@ -137,16 +137,6 @@ send_simple_run (void *cls,
137} 137}
138 138
139 139
140/**
141 * Create command.
142 *
143 * @param label name for command.
144 * @param start_peer_label Label of the cmd to start a peer.
145 * @param start_peer_label Label of the cmd which started the test system.
146 * @param num Number globally identifying the node.
147 * @param The topology for the test setup.
148 * @return command.
149 */
150struct GNUNET_TESTING_Command 140struct GNUNET_TESTING_Command
151GNUNET_TRANSPORT_cmd_send_simple (const char *label, 141GNUNET_TRANSPORT_cmd_send_simple (const char *label,
152 const char *start_peer_label, 142 const char *start_peer_label,
diff --git a/src/transport/transport_api_core.c b/src/transport/transport_api_core.c
index 0ffaeb444..12612de09 100644
--- a/src/transport/transport_api_core.c
+++ b/src/transport/transport_api_core.c
@@ -713,7 +713,7 @@ handle_recv (void *cls, const struct InboundMessage *im)
713 * Function we use for handling incoming set quota messages. 713 * Function we use for handling incoming set quota messages.
714 * 714 *
715 * @param cls closure, a `struct GNUNET_TRANSPORT_CoreHandle *` 715 * @param cls closure, a `struct GNUNET_TRANSPORT_CoreHandle *`
716 * @param msg message received 716 * @param qm message received
717 */ 717 */
718static void 718static void
719handle_set_quota (void *cls, const struct QuotaSetMessage *qm) 719handle_set_quota (void *cls, const struct QuotaSetMessage *qm)
diff --git a/src/transport/transport_api_monitor_peers.c b/src/transport/transport_api_monitor_peers.c
index 2f0f07f23..ef1dc6087 100644
--- a/src/transport/transport_api_monitor_peers.c
+++ b/src/transport/transport_api_monitor_peers.c
@@ -389,32 +389,6 @@ do_peer_connect (void *cls)
389} 389}
390 390
391 391
392/**
393 * Return information about a specific peer or all peers currently known to
394 * transport service once or in monitoring mode. To obtain information about
395 * a specific peer, a peer identity can be passed. To obtain information about
396 * all peers currently known to transport service, NULL can be passed as peer
397 * identity.
398 *
399 * For each peer, the callback is called with information about the address used
400 * to communicate with this peer, the state this peer is currently in and the
401 * the current timeout for this state.
402 *
403 * Upon completion, the 'GNUNET_TRANSPORT_PeerIterateCallback' is called one
404 * more time with 'NULL'. After this, the operation must no longer be
405 * explicitly canceled.
406 *
407 * The #GNUNET_TRANSPORT_monitor_peers_cancel call MUST not be called in the
408 * the peer_callback!
409 *
410 * @param cfg configuration to use
411 * @param peer a specific peer identity to obtain information for,
412 * NULL for all peers
413 * @param one_shot #GNUNET_YES to return the current state and then end (with NULL+NULL),
414 * #GNUNET_NO to monitor peers continuously
415 * @param peer_callback function to call with the results
416 * @param peer_callback_cls closure for @a peer_address_callback
417 */
418struct GNUNET_TRANSPORT_PeerMonitoringContext * 392struct GNUNET_TRANSPORT_PeerMonitoringContext *
419GNUNET_TRANSPORT_monitor_peers (const struct GNUNET_CONFIGURATION_Handle *cfg, 393GNUNET_TRANSPORT_monitor_peers (const struct GNUNET_CONFIGURATION_Handle *cfg,
420 const struct GNUNET_PeerIdentity *peer, 394 const struct GNUNET_PeerIdentity *peer,
diff --git a/src/transport/transport_api_monitor_plugins.c b/src/transport/transport_api_monitor_plugins.c
index d8eddddaa..43a11442b 100644
--- a/src/transport/transport_api_monitor_plugins.c
+++ b/src/transport/transport_api_monitor_plugins.c
@@ -211,7 +211,7 @@ locate_by_id (void *cls,
211 * Function called with responses from the service. 211 * Function called with responses from the service.
212 * 212 *
213 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` 213 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *`
214 * @paramm tpmm message with event data 214 * @param tpmm message with event data
215 * @return #GNUNET_Ok if message is well-formed 215 * @return #GNUNET_Ok if message is well-formed
216 */ 216 */
217static int 217static int
@@ -243,7 +243,7 @@ check_event (void *cls,
243 * Function called with responses from the service. 243 * Function called with responses from the service.
244 * 244 *
245 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` 245 * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *`
246 * @paramm tpmm message with event data 246 * @param tpmm message with event data
247 */ 247 */
248static void 248static void
249handle_event (void *cls, 249handle_event (void *cls,
diff --git a/src/transport/transport_api_offer_hello.c b/src/transport/transport_api_offer_hello.c
index eb342f57c..1b611aa6b 100644
--- a/src/transport/transport_api_offer_hello.c
+++ b/src/transport/transport_api_offer_hello.c
@@ -125,11 +125,6 @@ GNUNET_TRANSPORT_offer_hello (const struct GNUNET_CONFIGURATION_Handle *cfg,
125} 125}
126 126
127 127
128/**
129 * Cancel the request to transport to offer the HELLO message
130 *
131 * @param ohh the handle for the operation to cancel
132 */
133void 128void
134GNUNET_TRANSPORT_offer_hello_cancel (struct 129GNUNET_TRANSPORT_offer_hello_cancel (struct
135 GNUNET_TRANSPORT_OfferHelloHandle *ohh) 130 GNUNET_TRANSPORT_OfferHelloHandle *ohh)