-removing 2nd argument from GNUNET_CLIENT_disconnect as it was virtually always GNUNET_NO --- and all other uses indicate design problems

4 files changed, 9 insertions, 9 deletions

diff --git a/src/transport/transport_api.c b/src/transport/transport_api.c
index 9ff5cec88..e7f2327d9 100644
--- a/src/transport/transport_api.c
+++ b/src/transport/transport_api.c
@@ -940,7 +940,7 @@ disconnect_and_schedule_reconnect (struct GNUNET_TRANSPORT_Handle *h)
   }
   if (NULL != h->client)
   {
-    GNUNET_CLIENT_disconnect (h->client, GNUNET_YES);
+    GNUNET_CLIENT_disconnect (h->client);
     h->client = NULL;
   }
   /* Forget about all neighbours that we used to be connected to */
diff --git a/src/transport/transport_api_address_lookup.c b/src/transport/transport_api_address_lookup.c
index 797b95f07..655be833f 100644
--- a/src/transport/transport_api_address_lookup.c
+++ b/src/transport/transport_api_address_lookup.c
@@ -155,7 +155,7 @@ static void
 reconnect (struct GNUNET_TRANSPORT_PeerIterateContext *pal_ctx)
 {
   GNUNET_assert (GNUNET_NO == pal_ctx->one_shot);
-  GNUNET_CLIENT_disconnect (pal_ctx->client, GNUNET_NO);
+  GNUNET_CLIENT_disconnect (pal_ctx->client);
   pal_ctx->client = NULL;
   pal_ctx->backoff = GNUNET_TIME_relative_max (GNUNET_TIME_UNIT_MILLISECONDS,
                                                GNUNET_TIME_relative_min (GNUNET_TIME_relative_multiply (pal_ctx->backoff, 2),
@@ -354,7 +354,7 @@ GNUNET_TRANSPORT_peer_get_active_addresses_cancel (struct
 {
   if (NULL != alc->client)
   {
-    GNUNET_CLIENT_disconnect (alc->client, GNUNET_NO);
+    GNUNET_CLIENT_disconnect (alc->client);
     alc->client = NULL;
   }
   if (GNUNET_SCHEDULER_NO_TASK != alc->reconnect_task)
diff --git a/src/transport/transport_api_address_to_string.c b/src/transport/transport_api_address_to_string.c
index 73ea09f85..237c0b657 100644
--- a/src/transport/transport_api_address_to_string.c
+++ b/src/transport/transport_api_address_to_string.c
@@ -71,7 +71,7 @@ address_response_processor (void *cls, const struct GNUNET_MessageHeader *msg)
   if (msg == NULL)
   {
     alucb->cb (alucb->cb_cls, NULL);
-    GNUNET_CLIENT_disconnect (alucb->client, GNUNET_NO);
+    GNUNET_CLIENT_disconnect (alucb->client);
     GNUNET_free (alucb);
     return;
   }
@@ -82,7 +82,7 @@ address_response_processor (void *cls, const struct GNUNET_MessageHeader *msg)
   {
     /* done! */
     alucb->cb (alucb->cb_cls, NULL);
-    GNUNET_CLIENT_disconnect (alucb->client, GNUNET_NO);
+    GNUNET_CLIENT_disconnect (alucb->client);
     GNUNET_free (alucb);
     return;
   }
@@ -92,7 +92,7 @@ address_response_processor (void *cls, const struct GNUNET_MessageHeader *msg)
     /* invalid reply */
     GNUNET_break (0);
     alucb->cb (alucb->cb_cls, NULL);
-    GNUNET_CLIENT_disconnect (alucb->client, GNUNET_NO);
+    GNUNET_CLIENT_disconnect (alucb->client);
     GNUNET_free (alucb);
     return;
   }
@@ -180,7 +180,7 @@ GNUNET_TRANSPORT_address_to_string_cancel (struct
                                            GNUNET_TRANSPORT_AddressToStringContext
                                            *alc)
 {
-  GNUNET_CLIENT_disconnect (alc->client, GNUNET_NO);
+  GNUNET_CLIENT_disconnect (alc->client);
   GNUNET_free (alc);
 }
 
diff --git a/src/transport/transport_api_blacklist.c b/src/transport/transport_api_blacklist.c
index be52623bb..04646204f 100644
--- a/src/transport/transport_api_blacklist.c
+++ b/src/transport/transport_api_blacklist.c
@@ -168,7 +168,7 @@ static void
 reconnect (struct GNUNET_TRANSPORT_Blacklist *br)
 {
   if (br->client != NULL)
-    GNUNET_CLIENT_disconnect (br->client, GNUNET_NO);
+    GNUNET_CLIENT_disconnect (br->client);
   br->client = GNUNET_CLIENT_connect ("transport", br->cfg);
   GNUNET_assert (br->client != NULL);
   br->th =
@@ -288,7 +288,7 @@ GNUNET_TRANSPORT_blacklist_cancel (struct GNUNET_TRANSPORT_Blacklist *br)
     GNUNET_CLIENT_notify_transmit_ready_cancel (br->th);
     br->th = NULL;
   }
-  GNUNET_CLIENT_disconnect (br->client, GNUNET_NO);
+  GNUNET_CLIENT_disconnect (br->client);
   GNUNET_free (br);
 }