summaryrefslogtreecommitdiff
path: root/src/transport
diff options
context:
space:
mode:
authorMartin Schanzenbach <mschanzenbach@posteo.de>2021-02-26 20:40:51 +0100
committerMartin Schanzenbach <mschanzenbach@posteo.de>2021-02-26 20:40:51 +0100
commitd3f53a314973f2b0d46a5f86d5f0dd73610eeec2 (patch)
tree921bf82e3b9e73b3ecaa72f911ff0cbb13719868 /src/transport
parentad3e581f24153c42d3c39b4af4b83b830f18fecd (diff)
-tng idling
Diffstat (limited to 'src/transport')
-rw-r--r--src/transport/gnunet-service-tng.c15
1 files changed, 2 insertions, 13 deletions
diff --git a/src/transport/gnunet-service-tng.c b/src/transport/gnunet-service-tng.c
index f5a318b96..3cba49250 100644
--- a/src/transport/gnunet-service-tng.c
+++ b/src/transport/gnunet-service-tng.c
@@ -4199,18 +4199,6 @@ queue_send_msg (struct Queue *queue,
struct GNUNET_TRANSPORT_SendMessageTo *smt;
struct GNUNET_MQ_Envelope *env;
- /**
- * FIXME: the queue idle member does not really make
- * sense in the code.
- * It is not clear what "idle" should mean? If it means
- * the queue is empty, then other code (see schedule_retransmit)
- * does not make sense at it ALWAYS expects and idle queue
- * or will refuse to transmit because it is "busy".
- * The problem is that the queue is (was) never set to
- * idle in the code. Now it is, but it is unclear if the
- * expected logic is preserved.
- */
- queue->idle = GNUNET_NO;
GNUNET_log (
GNUNET_ERROR_TYPE_DEBUG,
"Queueing %u bytes of payload for transmission <%llu> on queue %llu to %s\n",
@@ -8882,6 +8870,8 @@ transmit_on_queue (void *cls)
queue->idle = GNUNET_YES;
return;
}
+ /* There is a message pending, we are certainly not idle */
+ queue->idle = GNUNET_NO;
/* Given selection in `sc`, do transmission */
pm = sc.best;
@@ -9107,7 +9097,6 @@ handle_send_message_ack (void *cls,
qe->queue->queue_length,
tc->details.communicator.total_queue_length);
GNUNET_SERVICE_client_continue (tc->client);
- qe->queue->idle = GNUNET_YES;
/* if applicable, resume transmissions that waited on ACK */
if (COMMUNICATOR_TOTAL_QUEUE_LIMIT - 1 ==