aboutsummaryrefslogtreecommitdiff
path: root/src/util/crypto_ecc.c
diff options
context:
space:
mode:
authorFlorian Dold <florian.dold@gmail.com>2020-05-26 03:23:29 +0530
committerFlorian Dold <florian.dold@gmail.com>2020-05-26 03:23:29 +0530
commit5a69caa07f3f334a76a61f13d8336608b3c5d5e9 (patch)
tree64f0b003e7f2d1b0d82ef77f39f53c0876f10892 /src/util/crypto_ecc.c
parent2a82be115c2a47eab1fed70d8c85a8b2711f13d1 (diff)
downloadgnunet-5a69caa07f3f334a76a61f13d8336608b3c5d5e9.tar.gz
gnunet-5a69caa07f3f334a76a61f13d8336608b3c5d5e9.zip
replace Christian's FIXME with an explanation
Diffstat (limited to 'src/util/crypto_ecc.c')
-rw-r--r--src/util/crypto_ecc.c10
1 files changed, 9 insertions, 1 deletions
diff --git a/src/util/crypto_ecc.c b/src/util/crypto_ecc.c
index 96d546185..e1608ae55 100644
--- a/src/util/crypto_ecc.c
+++ b/src/util/crypto_ecc.c
@@ -544,10 +544,18 @@ void
544GNUNET_CRYPTO_eddsa_key_create (struct GNUNET_CRYPTO_EddsaPrivateKey *pk) 544GNUNET_CRYPTO_eddsa_key_create (struct GNUNET_CRYPTO_EddsaPrivateKey *pk)
545{ 545{
546 BENCHMARK_START (eddsa_key_create); 546 BENCHMARK_START (eddsa_key_create);
547 /*
548 * We do not clamp for EdDSA, since all functions that use the private key do
549 * their own clamping (just like in libsodium). What we call "private key"
550 * here, actually corresponds to the seed in libsodium.
551 *
552 * (Contrast this to ECDSA, where functions using the private key can't clamp
553 * due to properties needed for GNS. That is a worse/unsafer API, but
554 * required for the GNS constructions to work.)
555 */
547 GNUNET_CRYPTO_random_block (GNUNET_CRYPTO_QUALITY_NONCE, 556 GNUNET_CRYPTO_random_block (GNUNET_CRYPTO_QUALITY_NONCE,
548 pk, 557 pk,
549 sizeof (struct GNUNET_CRYPTO_EddsaPrivateKey)); 558 sizeof (struct GNUNET_CRYPTO_EddsaPrivateKey));
550 // FIXME: should we not do the clamping here? Or is this done elsewhere?
551 BENCHMARK_END (eddsa_key_create); 559 BENCHMARK_END (eddsa_key_create);
552} 560}
553 561