The empty path is invalid

If GNUNET_DISK_directory_create_for_file() is called with a
path like "/foo" then we will pass the empty path to
GNUNET_DISK_directory_create() and access(). The latter will
always return ENOENT.

1 files changed, 5 insertions, 0 deletions

diff --git a/src/util/disk.c b/src/util/disk.c
index 04bed6cc9..bd766a1b9 100644
--- a/src/util/disk.c
+++ b/src/util/disk.c
@@ -823,6 +823,11 @@ GNUNET_DISK_directory_create_for_file (const char *filename)
   while ((len > 0) && (rdir[len] != DIR_SEPARATOR))
     len--;
   rdir[len] = '\0';
+  /* The empty path is invalid and in this case refers to / */
+  if (0 == len) {
+    GNUNET_free (rdir);
+    rdir = GNUNET_strdup ("/");
+  }
   ret = GNUNET_DISK_directory_create (rdir);
   if ((ret == GNUNET_OK) && (0 != ACCESS (rdir, W_OK)))
     ret = GNUNET_NO;