aboutsummaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorMatthias Wachs <wachs@net.in.tum.de>2013-05-16 13:02:52 +0000
committerMatthias Wachs <wachs@net.in.tum.de>2013-05-16 13:02:52 +0000
commit39963bb835382e3de74f82d671afa4213b703fdc (patch)
treed468ed5f73d9e6e59315acfbec47b2a5ecd214f3 /src
parent3a03bbb4b950948d18e0e6c263fad2dca4e1a7c5 (diff)
downloadgnunet-39963bb835382e3de74f82d671afa4213b703fdc.tar.gz
gnunet-39963bb835382e3de74f82d671afa4213b703fdc.zip
returning here is not a good idea since:
- IPv6 socket can be opened but will be not closed if IPv4 error is handled as hard error - Plugin will return correctly with IPv6 socket open but never scheduled
Diffstat (limited to 'src')
-rw-r--r--src/transport/plugin_transport_udp.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/transport/plugin_transport_udp.c b/src/transport/plugin_transport_udp.c
index 9a32515e7..c1511889b 100644
--- a/src/transport/plugin_transport_udp.c
+++ b/src/transport/plugin_transport_udp.c
@@ -2515,6 +2515,7 @@ setup_sockets (struct Plugin *plugin,
2515 plugin->sockv6 = GNUNET_NETWORK_socket_create (PF_INET6, SOCK_DGRAM, 0); 2515 plugin->sockv6 = GNUNET_NETWORK_socket_create (PF_INET6, SOCK_DGRAM, 0);
2516 if (NULL == plugin->sockv6) 2516 if (NULL == plugin->sockv6)
2517 { 2517 {
2518 GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "socket");
2518 LOG (GNUNET_ERROR_TYPE_WARNING, "Disabling IPv6 since it is not supported on this system!\n"); 2519 LOG (GNUNET_ERROR_TYPE_WARNING, "Disabling IPv6 since it is not supported on this system!\n");
2519 plugin->enable_ipv6 = GNUNET_NO; 2520 plugin->enable_ipv6 = GNUNET_NO;
2520 } 2521 }
@@ -2588,7 +2589,8 @@ setup_sockets (struct Plugin *plugin,
2588 if (NULL == plugin->sockv4) 2589 if (NULL == plugin->sockv4)
2589 { 2590 {
2590 GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "socket"); 2591 GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "socket");
2591 return sockets_created; 2592 LOG (GNUNET_ERROR_TYPE_WARNING, "Disabling IPv4 since it is not supported on this system!\n");
2593 plugin->enable_ipv4 = GNUNET_NO;
2592 } 2594 }
2593 else 2595 else
2594 { 2596 {