diff options
author | Julius Bünger <buenger@mytum.de> | 2015-01-23 01:05:08 +0000 |
---|---|---|
committer | Julius Bünger <buenger@mytum.de> | 2015-01-23 01:05:08 +0000 |
commit | 434337b0f0c80a86c88daee571291b7f6d194563 (patch) | |
tree | 448d61bcc6845d69aa67a8b660060ea1bed9a798 /src | |
parent | 05cff1f88139935278c7954d6c09645ee54d6adb (diff) | |
download | gnunet-434337b0f0c80a86c88daee571291b7f6d194563.tar.gz gnunet-434337b0f0c80a86c88daee571291b7f6d194563.zip |
code cleanup
Diffstat (limited to 'src')
-rw-r--r-- | src/rps/gnunet-service-rps.c | 15 |
1 files changed, 7 insertions, 8 deletions
diff --git a/src/rps/gnunet-service-rps.c b/src/rps/gnunet-service-rps.c index 278276aff..6bad9cd2f 100644 --- a/src/rps/gnunet-service-rps.c +++ b/src/rps/gnunet-service-rps.c | |||
@@ -421,13 +421,13 @@ get_rand_peer_ignore_list (const struct GNUNET_PeerIdentity *peer_list, | |||
421 | struct GNUNET_PeerIdentity *tmp_peer_list; | 421 | struct GNUNET_PeerIdentity *tmp_peer_list; |
422 | struct GNUNET_PeerIdentity *peer; | 422 | struct GNUNET_PeerIdentity *peer; |
423 | 423 | ||
424 | GNUNET_assert (NULL != peer_list); | ||
425 | |||
424 | tmp_size = 0; | 426 | tmp_size = 0; |
425 | tmp_peer_list = NULL; | 427 | tmp_peer_list = NULL; |
426 | GNUNET_array_grow (tmp_peer_list, tmp_size, list_size); | 428 | GNUNET_array_grow (tmp_peer_list, tmp_size, list_size); |
427 | memcpy (tmp_peer_list, peer_list, list_size * sizeof (struct GNUNET_PeerIdentity)); | 429 | memcpy (tmp_peer_list, peer_list, list_size * sizeof (struct GNUNET_PeerIdentity)); |
428 | peer = GNUNET_new (struct GNUNET_PeerIdentity); | 430 | peer = GNUNET_new (struct GNUNET_PeerIdentity); |
429 | // FIXME if we have only NULL in gossip list this will block | ||
430 | // but then we might have a problem nevertheless | ||
431 | 431 | ||
432 | do | 432 | do |
433 | { | 433 | { |
@@ -1105,16 +1105,12 @@ do_round (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc) | |||
1105 | n_peers, alpha, gossip_list_size); | 1105 | n_peers, alpha, gossip_list_size); |
1106 | for ( i = 0 ; i < n_peers ; i++ ) | 1106 | for ( i = 0 ; i < n_peers ; i++ ) |
1107 | { | 1107 | { |
1108 | // TODO | ||
1109 | //peer = get_rand_peer_ignore_list (gossip_list, gossip_list_size, | ||
1110 | // NULL, 0); | ||
1111 | peer = &gossip_list[permut[i]]; | 1108 | peer = &gossip_list[permut[i]]; |
1112 | if (own_identity != peer) // TODO | 1109 | if (own_identity != peer) // TODO |
1113 | { // FIXME if this fails schedule/loop this for later | 1110 | { // FIXME if this fails schedule/loop this for later |
1114 | LOG (GNUNET_ERROR_TYPE_DEBUG, "Sending PUSH to peer %s of gossiped list.\n", GNUNET_i2s (peer)); | 1111 | LOG (GNUNET_ERROR_TYPE_DEBUG, "Sending PUSH to peer %s of gossiped list.\n", GNUNET_i2s (peer)); |
1115 | 1112 | ||
1116 | ev = GNUNET_MQ_msg_header (GNUNET_MESSAGE_TYPE_RPS_PP_PUSH); | 1113 | ev = GNUNET_MQ_msg_header (GNUNET_MESSAGE_TYPE_RPS_PP_PUSH); |
1117 | // FIXME sometimes it returns a pointer to a freed mq | ||
1118 | mq = get_mq (peer_map, peer); | 1114 | mq = get_mq (peer_map, peer); |
1119 | GNUNET_MQ_send (mq, ev); | 1115 | GNUNET_MQ_send (mq, ev); |
1120 | } | 1116 | } |
@@ -1418,6 +1414,7 @@ handle_client_disconnect (void *cls, | |||
1418 | { | 1414 | { |
1419 | } | 1415 | } |
1420 | 1416 | ||
1417 | |||
1421 | /** | 1418 | /** |
1422 | * Handle the channel a peer opens to us. | 1419 | * Handle the channel a peer opens to us. |
1423 | * | 1420 | * |
@@ -1450,16 +1447,18 @@ handle_inbound_channel (void *cls, | |||
1450 | ctx->recv_channel = channel; | 1447 | ctx->recv_channel = channel; |
1451 | } | 1448 | } |
1452 | 1449 | ||
1453 | // FIXME there might already be an established channel | 1450 | ctx->peer_flags |= LIVING; |
1454 | 1451 | ||
1455 | //ctx->peer_flags = IN_OTHER_GOSSIP_LIST; | 1452 | //ctx->peer_flags = IN_OTHER_GOSSIP_LIST; |
1456 | ctx->mq = NULL; // TODO create mq? | 1453 | ctx->mq = NULL; |
1457 | 1454 | ||
1458 | (void) GNUNET_CONTAINER_multipeermap_put (peer_map, initiator, ctx, | 1455 | (void) GNUNET_CONTAINER_multipeermap_put (peer_map, initiator, ctx, |
1459 | GNUNET_CONTAINER_MULTIHASHMAPOPTION_REPLACE); | 1456 | GNUNET_CONTAINER_MULTIHASHMAPOPTION_REPLACE); |
1457 | |||
1460 | return NULL; // TODO | 1458 | return NULL; // TODO |
1461 | } | 1459 | } |
1462 | 1460 | ||
1461 | |||
1463 | /** | 1462 | /** |
1464 | * This is called when a remote peer destroys a channel. | 1463 | * This is called when a remote peer destroys a channel. |
1465 | * | 1464 | * |