From 0f9500cc636e82b2b5841be1f69097c5cadf5055 Mon Sep 17 00:00:00 2001 From: Martin Schanzenbach Date: Tue, 12 Mar 2024 19:12:47 +0100 Subject: coverity: some fixes related to new peerstore API usage (null ptr derefs) --- src/service/fs/gnunet-service-fs_cp.c | 2 +- src/service/transport/transport-testing2.c | 1 - src/service/transport/transport_api_cmd_start_peer.c | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/src/service/fs/gnunet-service-fs_cp.c b/src/service/fs/gnunet-service-fs_cp.c index 18a25a030..df934feaf 100644 --- a/src/service/fs/gnunet-service-fs_cp.c +++ b/src/service/fs/gnunet-service-fs_cp.c @@ -409,9 +409,9 @@ peer_respect_cb (void *cls, if (NULL != record) { GNUNET_PEERSTORE_iteration_stop (cp->respect_iterate_req); + cp->respect_iterate_req = NULL; return; } - cp->respect_iterate_req = NULL; GNUNET_PEERSTORE_iteration_next (cp->respect_iterate_req, 1); } diff --git a/src/service/transport/transport-testing2.c b/src/service/transport/transport-testing2.c index 36a57b2b6..877730630 100644 --- a/src/service/transport/transport-testing2.c +++ b/src/service/transport/transport-testing2.c @@ -352,7 +352,6 @@ hello_iter_cb (void *cb_cls, p->start_cb (p->start_cb_cls); p->start_cb = NULL; } - GNUNET_PEERSTORE_iteration_next (p->pic, 1); } diff --git a/src/service/transport/transport_api_cmd_start_peer.c b/src/service/transport/transport_api_cmd_start_peer.c index 311289f92..5afbb338b 100644 --- a/src/service/transport/transport_api_cmd_start_peer.c +++ b/src/service/transport/transport_api_cmd_start_peer.c @@ -70,7 +70,6 @@ hello_iter_cb (void *cb_cls, GNUNET_PEERSTORE_iteration_stop (sps->pic); sps->pic = NULL; GNUNET_TESTING_async_finish (&sps->ac); - GNUNET_PEERSTORE_iteration_next (sps->pic, 1); } -- cgit v1.2.3