From 8233e282046e27de57de75f175e131a974087618 Mon Sep 17 00:00:00 2001 From: Alessio Vanni Date: Sat, 24 Apr 2021 17:29:42 +0200 Subject: Swap gnunet-config's default behaviour for the rewrite flag With the previous default, a configuration file could keep values different from the defaults even when the user did not explicitly edit that option, potentially leading to buggy behaviour. For example: GNUnet's version X+1 changes the default value for a certain option A, but anyone who has edited the configuration file with version X or earlier, would still have got the old default for A even when updating to version X+1. It was possible to write only the edited parts, but that required explicitly passing the `--rewrite' (or `-w') flag. The default behaviour has now been swapped so that the resulting file contains only differences, while a "frozen" configuration is generated with the `--rewrite' flag. Also, as it's a minor change: a function used internally by the logging component was using translated strings to check the requested log level. This behaviour is buggy as passing an untranslated string to e.g. `GNUNET_log_setup', while the current locale is different and a translation for that string exists, would generate a different log level than the one requested. --- doc/man/gnunet-config.1 | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) (limited to 'doc') diff --git a/doc/man/gnunet-config.1 b/doc/man/gnunet-config.1 index f6166cbca..89bc3d14b 100644 --- a/doc/man/gnunet-config.1 +++ b/doc/man/gnunet-config.1 @@ -39,7 +39,7 @@ .Op Fl s Ar SECTION | Fl -section= Ns Ar SECTION .Op Fl V Ar VALUE | Fl -value Ar VALUE .Op Fl v | -version -.Op Fl W | -rewrite +.Op Fl w | -rewrite .Sh DESCRIPTION .Nm can be used to read or modify GNUnet configuration files. @@ -69,8 +69,8 @@ Configuration value to store in the given section under the given option. Must only be given together with -s and -o options. .It Fl v | -version Print GNUnet version number. -.It Fl W | -rewrite -Consider differences to defaults only. +.It Fl w | -rewrite +Write to file the full configuration, including default values, instead of just the differences. .El .Sh SEE ALSO The full documentation for gnunet is maintained as a Texinfo manual. -- cgit v1.2.3