From 760d2d696450ef550abf99e16f4092b8050a9f4c Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Thu, 6 Sep 2012 15:51:03 +0000 Subject: fix use uninit --- src/dns/dnsstub.c | 32 ++++++++++++++++++++------------ src/dns/gnunet-service-dns.c | 1 + 2 files changed, 21 insertions(+), 12 deletions(-) (limited to 'src/dns') diff --git a/src/dns/dnsstub.c b/src/dns/dnsstub.c index 273160e8a..154d59326 100644 --- a/src/dns/dnsstub.c +++ b/src/dns/dnsstub.c @@ -280,11 +280,15 @@ GNUNET_DNSSTUB_resolve (struct GNUNET_DNSSTUB_Context *ctx, GNUNET_assert (NULL != ret); rs->rc = rc; rs->rc_cls = rc_cls; - GNUNET_NETWORK_socket_sendto (ret, - request, - request_len, - sa, - sa_len); + if (GNUNET_SYSERR == + GNUNET_NETWORK_socket_sendto (ret, + request, + request_len, + sa, + sa_len)) + GNUNET_log (GNUNET_ERROR_TYPE_WARNING, + _("Failed to send DNS request to %s\n"), + GNUNET_a2s (sa, sa_len)); return rs; } @@ -309,7 +313,7 @@ GNUNET_DNSSTUB_resolve2 (struct GNUNET_DNSSTUB_Context *ctx, int af; struct sockaddr_in v4; struct sockaddr_in6 v6; - struct sockaddr *so; + struct sockaddr *sa; socklen_t salen; struct GNUNET_NETWORK_Handle *dnsout; struct GNUNET_DNSSTUB_RequestSocket *rs; @@ -324,7 +328,7 @@ GNUNET_DNSSTUB_resolve2 (struct GNUNET_DNSSTUB_Context *ctx, #if HAVE_SOCKADDR_IN_SIN_LEN v4.sin_len = (u_char) salen; #endif - so = (struct sockaddr *) &v4; + sa = (struct sockaddr *) &v4; af = AF_INET; } else if (1 == inet_pton (AF_INET6, ctx->dns_exit, &v6.sin6_addr)) @@ -335,7 +339,7 @@ GNUNET_DNSSTUB_resolve2 (struct GNUNET_DNSSTUB_Context *ctx, #if HAVE_SOCKADDR_IN_SIN_LEN v6.sin6_len = (u_char) salen; #endif - so = (struct sockaddr *) &v6; + sa = (struct sockaddr *) &v6; af = AF_INET6; } else @@ -357,14 +361,18 @@ GNUNET_DNSSTUB_resolve2 (struct GNUNET_DNSSTUB_Context *ctx, return NULL; } memcpy (&rs->addr, - so, + sa, salen); rs->addrlen = salen; rs->rc = rc; rs->rc_cls = rc_cls; - GNUNET_NETWORK_socket_sendto (dnsout, - request, - request_len, so, salen); + if (GNUNET_SYSERR == + GNUNET_NETWORK_socket_sendto (dnsout, + request, + request_len, sa, salen)) + GNUNET_log (GNUNET_ERROR_TYPE_WARNING, + _("Failed to send DNS request to %s\n"), + GNUNET_a2s (sa, salen)); rs->timeout = GNUNET_TIME_relative_to_absolute (REQUEST_TIMEOUT); return rs; diff --git a/src/dns/gnunet-service-dns.c b/src/dns/gnunet-service-dns.c index 8fa30b335..b6d5a1967 100644 --- a/src/dns/gnunet-service-dns.c +++ b/src/dns/gnunet-service-dns.c @@ -1252,6 +1252,7 @@ run (void *cls, struct GNUNET_SERVER_Handle *server, nc = GNUNET_SERVER_notification_context_create (server, 1); GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL, &cleanup_task, cls); + dns_exit = NULL; if ( (GNUNET_YES == GNUNET_CONFIGURATION_get_value_yesno (cfg_, "dns", "PROVIDE_EXIT")) && ( (GNUNET_OK != -- cgit v1.2.3