From 460cc837899c52fdad3d52492af932a71dd888e3 Mon Sep 17 00:00:00 2001 From: Martin Schanzenbach Date: Thu, 1 Dec 2022 12:40:05 +0900 Subject: -add FIXME to nat service _unregister; fix printf format in tcp communicator --- src/include/gnunet_nat_service.h | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/include') diff --git a/src/include/gnunet_nat_service.h b/src/include/gnunet_nat_service.h index e39e2c016..628ca2ef8 100644 --- a/src/include/gnunet_nat_service.h +++ b/src/include/gnunet_nat_service.h @@ -385,6 +385,12 @@ GNUNET_NAT_request_reversal (struct GNUNET_NAT_Handle *nh, * handle. This frees the handle, after having sent the needed * commands to close open ports. * + * FIXME: No, the implementation of this API does not do anything beyond + * cleaning up the handle. + * This is a problem for applications that use #GNUNET_NAT_AddressCallback + * and use the app_ctx to store objects, because the callback will never be + * called for cleanup on unregister. + * * @param nh the handle to unregister */ void -- cgit v1.2.3