From 7f4ddbcab8598e3d5e29c23ce883cdfa664408f1 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Sat, 18 Jul 2020 00:44:39 +0200 Subject: merge flags into enum for GNUNET_DISK_pipe() API, fixing #6188 --- src/namestore/gnunet-namestore.c | 3 +- src/namestore/gnunet-service-namestore.c | 2 +- src/namestore/plugin_rest_namestore.c | 54 +++++++++++++++----------------- 3 files changed, 29 insertions(+), 30 deletions(-) (limited to 'src/namestore') diff --git a/src/namestore/gnunet-namestore.c b/src/namestore/gnunet-namestore.c index 704a4abf7..07d045b90 100644 --- a/src/namestore/gnunet-namestore.c +++ b/src/namestore/gnunet-namestore.c @@ -1048,7 +1048,8 @@ run_with_zone_pkey (const struct GNUNET_CONFIGURATION_Handle *cfg) return; } add = 1; - typestring = GNUNET_strdup (GNUNET_GNSRECORD_number_to_typename (GNUNET_GNSRECORD_TYPE_NICK)); + typestring = GNUNET_strdup (GNUNET_GNSRECORD_number_to_typename ( + GNUNET_GNSRECORD_TYPE_NICK)); name = GNUNET_strdup (GNUNET_GNS_EMPTY_LABEL_AT); value = GNUNET_strdup (nickstring); is_public = 0; diff --git a/src/namestore/gnunet-service-namestore.c b/src/namestore/gnunet-service-namestore.c index ede566d40..bb8138e23 100644 --- a/src/namestore/gnunet-service-namestore.c +++ b/src/namestore/gnunet-service-namestore.c @@ -915,7 +915,7 @@ refresh_block (struct NamestoreClient *nc, nick = get_nick_record (zone_key); res_count = rd_count; res = (struct GNUNET_GNSRECORD_Data *) rd; /* fixme: a bit unclean... */ - if (NULL != nick && (0 != strcmp (name, GNUNET_GNS_EMPTY_LABEL_AT))) + if ((NULL != nick) && (0 != strcmp (name, GNUNET_GNS_EMPTY_LABEL_AT))) { nick->flags = (nick->flags | GNUNET_GNSRECORD_RF_PRIVATE) ^ GNUNET_GNSRECORD_RF_PRIVATE; diff --git a/src/namestore/plugin_rest_namestore.c b/src/namestore/plugin_rest_namestore.c index 4a05b2833..f1cbfb38b 100644 --- a/src/namestore/plugin_rest_namestore.c +++ b/src/namestore/plugin_rest_namestore.c @@ -536,6 +536,7 @@ namestore_list_iteration (void *cls, GNUNET_NAMESTORE_zone_iterator_next (handle->list_it, 1); } + /** * Handle lookup error * @@ -553,10 +554,10 @@ ns_lookup_error_cb (void *cls) static void ns_get_lookup_cb (void *cls, - const struct GNUNET_CRYPTO_EcdsaPrivateKey *zone, - const char *label, - unsigned int rd_len, - const struct GNUNET_GNSRECORD_Data *rd) + const struct GNUNET_CRYPTO_EcdsaPrivateKey *zone, + const char *label, + unsigned int rd_len, + const struct GNUNET_GNSRECORD_Data *rd) { struct RequestHandle *handle = cls; struct GNUNET_GNSRECORD_Data rd_filtered[rd_len]; @@ -588,8 +589,6 @@ ns_get_lookup_cb (void *cls, } - - /** * Handle namestore GET request * @@ -666,12 +665,12 @@ namestore_get (struct GNUNET_REST_RequestHandle *con_handle, } handle->record_name = GNUNET_strdup (labelname + 1); handle->ns_qe = GNUNET_NAMESTORE_records_lookup (handle->ns_handle, - handle->zone_pkey, - handle->record_name, - &ns_lookup_error_cb, - handle, - &ns_get_lookup_cb, - handle); + handle->zone_pkey, + handle->record_name, + &ns_lookup_error_cb, + handle, + &ns_get_lookup_cb, + handle); if (NULL == handle->ns_qe) { handle->emsg = GNUNET_strdup (GNUNET_REST_NAMESTORE_FAILED); @@ -681,7 +680,6 @@ namestore_get (struct GNUNET_REST_RequestHandle *con_handle, } - static void ns_lookup_cb (void *cls, const struct GNUNET_CRYPTO_EcdsaPrivateKey *zone, @@ -702,12 +700,12 @@ ns_lookup_cb (void *cls, for (j = 0; j < handle->rd_count; j++) rd_new[i + j] = handle->rd[j]; handle->ns_qe = GNUNET_NAMESTORE_records_store (handle->ns_handle, - handle->zone_pkey, - handle->record_name, - i + j, - rd_new, - &create_finished, - handle); + handle->zone_pkey, + handle->record_name, + i + j, + rd_new, + &create_finished, + handle); if (NULL == handle->ns_qe) { handle->emsg = GNUNET_strdup (GNUNET_REST_NAMESTORE_FAILED); @@ -794,12 +792,12 @@ namestore_add_or_update (struct GNUNET_REST_RequestHandle *con_handle, } handle->zone_pkey = GNUNET_IDENTITY_ego_get_private_key (ego_entry->ego); handle->ns_qe = GNUNET_NAMESTORE_records_lookup (handle->ns_handle, - handle->zone_pkey, - handle->record_name, - &ns_lookup_error_cb, - handle, - &ns_lookup_cb, - handle); + handle->zone_pkey, + handle->record_name, + &ns_lookup_error_cb, + handle, + &ns_lookup_cb, + handle); if (NULL == handle->ns_qe) { handle->emsg = GNUNET_strdup (GNUNET_REST_NAMESTORE_FAILED); @@ -898,9 +896,9 @@ namestore_delete (struct GNUNET_REST_RequestHandle *con_handle, handle->zone_pkey, handle->record_name, 0, - NULL, - &del_finished, - handle); + NULL, + &del_finished, + handle); if (NULL == handle->ns_qe) { handle->emsg = GNUNET_strdup (GNUNET_REST_NAMESTORE_FAILED); -- cgit v1.2.3