From 308d54a985e18dd8765bf9cc394c16a21d2ee456 Mon Sep 17 00:00:00 2001 From: Willow Liquorice Date: Wed, 31 Aug 2022 22:52:31 +0100 Subject: -DOC: Pass through RECLAIM subsystem --- src/reclaim/reclaim_api.c | 50 ---------------------------------------- src/reclaim/reclaim_attribute.c | 8 ------- src/reclaim/reclaim_credential.c | 43 ---------------------------------- 3 files changed, 101 deletions(-) (limited to 'src/reclaim') diff --git a/src/reclaim/reclaim_api.c b/src/reclaim/reclaim_api.c index bc6b835c9..a61505d62 100644 --- a/src/reclaim/reclaim_api.c +++ b/src/reclaim/reclaim_api.c @@ -1076,14 +1076,6 @@ GNUNET_RECLAIM_connect (const struct GNUNET_CONFIGURATION_Handle *cfg) } -/** - * Cancel an operation. Note that the operation MAY still - * be executed; this merely cancels the continuation; if the request - * was already transmitted, the service may still choose to complete - * the operation. - * - * @param op operation to cancel - */ void GNUNET_RECLAIM_cancel (struct GNUNET_RECLAIM_Operation *op) { @@ -1210,18 +1202,6 @@ GNUNET_RECLAIM_attribute_delete ( } -/** - * Store an credential. If the credential is already present, - * it is replaced with the new credential. - * - * @param h handle to the re:claimID service - * @param pkey private key of the identity - * @param attr the credential value - * @param exp_interval the relative expiration interval for the credential - * @param cont continuation to call when done - * @param cont_cls closure for @a cont - * @return handle to abort the request - */ struct GNUNET_RECLAIM_Operation * GNUNET_RECLAIM_credential_store ( struct GNUNET_RECLAIM_Handle *h, @@ -1258,17 +1238,6 @@ GNUNET_RECLAIM_credential_store ( } -/** - * Delete an credential. Tickets used to share this credential are updated - * accordingly. - * - * @param h handle to the re:claimID service - * @param pkey Private key of the identity to add an attribute to - * @param attr The credential - * @param cont Continuation to call when done - * @param cont_cls Closure for @a cont - * @return handle Used to to abort the request - */ struct GNUNET_RECLAIM_Operation * GNUNET_RECLAIM_credential_delete ( struct GNUNET_RECLAIM_Handle *h, @@ -1366,12 +1335,6 @@ GNUNET_RECLAIM_get_attributes_start ( } -/** - * Calls the record processor specified in #GNUNET_RECLAIM_get_attributes_start - * for the next record. - * - * @param it the iterator - */ void GNUNET_RECLAIM_get_attributes_next (struct GNUNET_RECLAIM_AttributeIterator *it) { @@ -1524,19 +1487,6 @@ GNUNET_RECLAIM_get_credentials_stop (struct } -/** - * Issues a ticket to another relying party. The identity may use - * @GNUNET_RECLAIM_ticket_consume to consume the ticket - * and retrieve the attributes specified in the attribute list. - * - * @param h the reclaim to use - * @param iss the issuing identity (= the user) - * @param rp the subject of the ticket (= the relying party) - * @param attrs the attributes that the relying party is given access to - * @param cb the callback - * @param cb_cls the callback closure - * @return handle to abort the operation - */ struct GNUNET_RECLAIM_Operation * GNUNET_RECLAIM_ticket_issue ( struct GNUNET_RECLAIM_Handle *h, diff --git a/src/reclaim/reclaim_attribute.c b/src/reclaim/reclaim_attribute.c index 560267578..5d7adb7e6 100644 --- a/src/reclaim/reclaim_attribute.c +++ b/src/reclaim/reclaim_attribute.c @@ -282,14 +282,6 @@ GNUNET_RECLAIM_attribute_new (const char *attr_name, } -/** - * Add a new attribute to a claim list - * - * @param attr_name the name of the new attribute claim - * @param type the type of the claim - * @param data claim payload - * @param data_size claim payload size - */ void GNUNET_RECLAIM_attribute_list_add ( struct GNUNET_RECLAIM_AttributeList *al, diff --git a/src/reclaim/reclaim_credential.c b/src/reclaim/reclaim_credential.c index b4aeedf29..b1312f403 100644 --- a/src/reclaim/reclaim_credential.c +++ b/src/reclaim/reclaim_credential.c @@ -250,15 +250,6 @@ GNUNET_RECLAIM_credential_value_to_string (uint32_t type, } -/** - * Create a new credential. - * - * @param attr_name the credential name - * @param type the credential type - * @param data the credential value - * @param data_size the credential value size - * @return the new credential - */ struct GNUNET_RECLAIM_Credential * GNUNET_RECLAIM_credential_new (const char *attr_name, uint32_t type, @@ -339,13 +330,6 @@ GNUNET_RECLAIM_credential_list_serialize ( } -/** - * Deserialize an credential list - * - * @param data the serialized attribute list - * @param data_size the length of the serialized data - * @return a GNUNET_IDENTITY_PROVIDER_AttributeList, must be free'd by caller - */ struct GNUNET_RECLAIM_CredentialList * GNUNET_RECLAIM_credential_list_deserialize (const char *data, size_t data_size) { @@ -454,13 +438,6 @@ GNUNET_RECLAIM_credential_serialize_get_size ( } -/** - * Serialize an credential - * - * @param attr the credential to serialize - * @param result the serialized credential - * @return length of serialized data - */ size_t GNUNET_RECLAIM_credential_serialize ( const struct GNUNET_RECLAIM_Credential *credential, @@ -627,12 +604,6 @@ GNUNET_RECLAIM_presentation_typename_to_number (const char *typename) } -/** - * Convert an presentation type number to the corresponding presentation type string - * - * @param type number of a type - * @return corresponding typestring, NULL on error - */ const char * GNUNET_RECLAIM_presentation_number_to_typename (uint32_t type) { @@ -758,13 +729,6 @@ GNUNET_RECLAIM_presentation_list_serialize_get_size ( } -/** - * Serialize an attribute list - * - * @param attrs the attribute list to serialize - * @param result the serialized attribute - * @return length of serialized data - */ size_t GNUNET_RECLAIM_presentation_list_serialize ( const struct GNUNET_RECLAIM_PresentationList *presentations, @@ -900,13 +864,6 @@ GNUNET_RECLAIM_presentation_serialize_get_size ( } -/** - * Serialize an presentation - * - * @param attr the presentation to serialize - * @param result the serialized presentation - * @return length of serialized data - */ size_t GNUNET_RECLAIM_presentation_serialize ( const struct GNUNET_RECLAIM_Presentation *presentation, -- cgit v1.2.3 From e13e66d0dc6a79f6dfe469ba075f307c006fdb66 Mon Sep 17 00:00:00 2001 From: Willow Liquorice Date: Fri, 2 Sep 2022 22:13:05 +0100 Subject: -DOC: Numerous small fixes to clean up short warning categories --- src/cadet/cadet_api_drop_message.c | 2 +- src/core/gnunet-service-core_kx.c | 3 ++- src/include/gnunet_messenger_service.h | 2 +- src/include/gnunet_mq_lib.h | 1 + src/messenger/gnunet-service-messenger_ego_store.h | 2 +- src/messenger/gnunet-service-messenger_message_kind.h | 2 +- src/my/my_result_helper.c | 2 +- src/reclaim/did.h | 4 ++-- 8 files changed, 10 insertions(+), 8 deletions(-) (limited to 'src/reclaim') diff --git a/src/cadet/cadet_api_drop_message.c b/src/cadet/cadet_api_drop_message.c index 2b031b5c0..e172418c4 100644 --- a/src/cadet/cadet_api_drop_message.c +++ b/src/cadet/cadet_api_drop_message.c @@ -27,7 +27,7 @@ /** - * Drop the next cadet message of a given type.. + * Drop the next cadet message of a given type. * * @param mq message queue * @param ccn client channel number. diff --git a/src/core/gnunet-service-core_kx.c b/src/core/gnunet-service-core_kx.c index c5992a824..da62b6458 100644 --- a/src/core/gnunet-service-core_kx.c +++ b/src/core/gnunet-service-core_kx.c @@ -488,7 +488,8 @@ derive_aes_key (const struct GNUNET_PeerIdentity *sender, * @param iv initialization vector to use * @param in ciphertext * @param out plaintext - * @param size size of @a in/@a out + * @param size size of @a in / @a out + * * @return #GNUNET_OK on success */ static int diff --git a/src/include/gnunet_messenger_service.h b/src/include/gnunet_messenger_service.h index f8bbc7398..ff503de52 100644 --- a/src/include/gnunet_messenger_service.h +++ b/src/include/gnunet_messenger_service.h @@ -792,7 +792,7 @@ const struct GNUNET_IDENTITY_PublicKey* GNUNET_MESSENGER_contact_get_key (const struct GNUNET_MESSENGER_Contact *contact); /** - * Send a message into a room. If you opened the room all entered members will receive the + * Send a message into a room. If you opened the room all entered members will receive the * message. If you entered the room through a door all so entered doors will receive the * message as well. All members receiving the message will also propagate this message recursively * as long as the message is unknown to them. diff --git a/src/include/gnunet_mq_lib.h b/src/include/gnunet_mq_lib.h index bf2902707..a6bd58558 100644 --- a/src/include/gnunet_mq_lib.h +++ b/src/include/gnunet_mq_lib.h @@ -601,6 +601,7 @@ struct GNUNET_MQ_MessageHandler * "context"), * GNUNET_MQ_handler_end() * }; + * * * @param name unique basename for the functions * @param code message type constant diff --git a/src/messenger/gnunet-service-messenger_ego_store.h b/src/messenger/gnunet-service-messenger_ego_store.h index 4ed2bbf6d..a08310aa3 100644 --- a/src/messenger/gnunet-service-messenger_ego_store.h +++ b/src/messenger/gnunet-service-messenger_ego_store.h @@ -180,7 +180,7 @@ delete_store_ego (struct GNUNET_MESSENGER_EgoStore *store, /** * Updates the location of a registered EGO in a store to - * a different one under a specific new_identifier replacing + * a different one under a specific new_identifier replacing * its old one. * * @param[in/out] store EGO-store diff --git a/src/messenger/gnunet-service-messenger_message_kind.h b/src/messenger/gnunet-service-messenger_message_kind.h index 508f19074..d07680dfc 100644 --- a/src/messenger/gnunet-service-messenger_message_kind.h +++ b/src/messenger/gnunet-service-messenger_message_kind.h @@ -150,7 +150,7 @@ create_message_invite (const struct GNUNET_PeerIdentity *door, const struct GNUNET_HashCode *key); /** - * Creates and allocates a new text message containing a string representing text. + * Creates and allocates a new text message containing a string representing text. * (all values are stored as copy) * * @param[in] text Text diff --git a/src/my/my_result_helper.c b/src/my/my_result_helper.c index 99b4229a4..b80f1c333 100644 --- a/src/my/my_result_helper.c +++ b/src/my/my_result_helper.c @@ -531,7 +531,7 @@ pre_extract_string (void *cls, /** - * Check size of extracted fixed size data from a Mysql database @a + * Check size of extracted fixed size data from a Mysql database * * @param cls closure * @param[in,out] rs diff --git a/src/reclaim/did.h b/src/reclaim/did.h index fc465da3b..42f65db26 100644 --- a/src/reclaim/did.h +++ b/src/reclaim/did.h @@ -25,7 +25,7 @@ /** * Create a DID string from an ego in the format - * did:gns: + * did:gns:\ * * @param ego the Ego to use * @return the DID string @@ -36,7 +36,7 @@ DID_ego_to_did (struct GNUNET_IDENTITY_Ego *ego); /** * Extract the public key from a DID - * in the format did:gns: + * in the format did:gns:\ * * @param did the DID parse * @param pk where to store the public key -- cgit v1.2.3 From d4f25caabd6098a2cbb713c9cd8228c1f9a26fe4 Mon Sep 17 00:00:00 2001 From: Willow Liquorice Date: Fri, 2 Sep 2022 22:45:52 +0100 Subject: -DOC: Minor fixes to doc comments (mostly correcting typos) to resolve 'unknown command' warnings --- src/block/bg_bf.c | 2 +- src/cadet/gnunet-service-cadet_channel.c | 4 ++-- src/cadet/gnunet-service-cadet_peer.c | 4 ++-- src/cadet/gnunet-service-cadet_tunnels.c | 2 +- src/dht/gnunet-service-dht_neighbours.h | 2 +- src/include/gnunet_ats_service.h | 2 +- src/include/gnunet_block_group_lib.h | 2 +- src/include/gnunet_block_lib.h | 2 +- src/include/gnunet_configuration_lib.h | 2 +- src/include/gnunet_crypto_lib.h | 2 +- src/include/gnunet_curl_lib.h | 8 ++++---- src/include/gnunet_dhtu_plugin.h | 2 +- src/include/gnunet_my_lib.h | 10 +++++----- src/include/gnunet_pq_lib.h | 8 ++++---- src/include/gnunet_sq_lib.h | 2 +- src/namestore/gnunet-namestore-fcfsd.c | 2 +- src/nse/gnunet-service-nse.c | 2 +- src/reclaim/gnunet-service-reclaim.c | 14 +++++++------- src/reclaim/gnunet-service-reclaim_tickets.c | 2 +- src/regex/gnunet-service-regex.c | 2 +- src/sq/sq_query_helper.c | 2 +- src/transport/gnunet-service-tng.c | 4 ++-- src/transport/transport-testing-main.c | 2 +- src/transport/transport-testing-main2.c | 2 +- src/transport/transport_api_monitor_plugins.c | 4 ++-- src/util/configuration.c | 4 ++-- src/util/gnunet-service-resolver.c | 2 +- 27 files changed, 48 insertions(+), 48 deletions(-) (limited to 'src/reclaim') diff --git a/src/block/bg_bf.c b/src/block/bg_bf.c index b79ea3c55..c8269498e 100644 --- a/src/block/bg_bf.c +++ b/src/block/bg_bf.c @@ -226,7 +226,7 @@ GNUNET_BLOCK_GROUP_bf_create (void *cls, * @param bg block group to use for testing * @param hc hash of element to evaluate * @return #GNUNET_YES if @a hc is (likely) a duplicate - * #GNUNET_NO if @a hc was definitively not in @bg (but now is) + * #GNUNET_NO if @a hc was definitively not in @a bg (but now is) */ enum GNUNET_GenericReturnValue GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg, diff --git a/src/cadet/gnunet-service-cadet_channel.c b/src/cadet/gnunet-service-cadet_channel.c index f742ba4a7..78658c296 100644 --- a/src/cadet/gnunet-service-cadet_channel.c +++ b/src/cadet/gnunet-service-cadet_channel.c @@ -1157,7 +1157,7 @@ GCCH_handle_channel_open_ack ( * @param cls closure, to a flag where we indicate duplicate packets * @param m1 a message of to sort * @param m2 another message to sort - * @return #GNUNET_YES if @e1 < @e2, otherwise #GNUNET_NO + * @return #GNUNET_YES if @a e1 < @a e2, otherwise #GNUNET_NO */ static int is_before (void *cls, @@ -1645,7 +1645,7 @@ GCCH_handle_remote_destroy ( * @param cls closure, to a flag where we indicate duplicate packets * @param crm1 an element of to sort * @param crm2 another element to sort - * @return #GNUNET_YES if @e1 < @e2, otherwise #GNUNET_NO + * @return #GNUNET_YES if @a e1 < @a e2, otherwise #GNUNET_NO */ static int cmp_crm_by_next_retry (void *cls, diff --git a/src/cadet/gnunet-service-cadet_peer.c b/src/cadet/gnunet-service-cadet_peer.c index 99669eb05..3fb0eed94 100644 --- a/src/cadet/gnunet-service-cadet_peer.c +++ b/src/cadet/gnunet-service-cadet_peer.c @@ -211,7 +211,7 @@ struct CadetPeer /** * Sum over all of the offsets of all of the paths in the @a path_heads DLLs. - * Used to speed-up @GCP_get_desirability_of_path() calculation. + * Used to speed-up #GCP_get_desirability_of_path() calculation. */ unsigned int off_sum; @@ -225,7 +225,7 @@ struct CadetPeer unsigned int mqm_ready_counter; /** - * Current length of the @e path_heads and @path_tails arrays. + * Current length of the @e path_heads and @e path_tails arrays. * The arrays should be grown as needed. */ unsigned int path_dll_length; diff --git a/src/cadet/gnunet-service-cadet_tunnels.c b/src/cadet/gnunet-service-cadet_tunnels.c index 9653fd3ec..ca91a0e01 100644 --- a/src/cadet/gnunet-service-cadet_tunnels.c +++ b/src/cadet/gnunet-service-cadet_tunnels.c @@ -169,7 +169,7 @@ struct CadetTunnelAxolotl * 32-byte chain keys (used for forward-secrecy) for * receiving messages. Updated for every message. If * messages are skipped, the respective derived MKs - * (and the current @HKr) are kept in the @e skipped_head DLL. + * (and the current @e HKr) are kept in the @e skipped_head DLL. */ struct GNUNET_CRYPTO_SymmetricSessionKey CKr; diff --git a/src/dht/gnunet-service-dht_neighbours.h b/src/dht/gnunet-service-dht_neighbours.h index 96db21b9b..2aa304242 100644 --- a/src/dht/gnunet-service-dht_neighbours.h +++ b/src/dht/gnunet-service-dht_neighbours.h @@ -150,7 +150,7 @@ GDS_try_connect (void *cls, * @param cls the closure, must be a `struct GDS_Underlay` * @param target handle to the target, * pointer will remain valid until @e disconnect_cb is called - * @para pid peer identity, + * @param pid peer identity, * pointer will remain valid until @e disconnect_cb is called * @param[out] ctx storage space for DHT to use in association with this target */ diff --git a/src/include/gnunet_ats_service.h b/src/include/gnunet_ats_service.h index 11a65c4f5..60154d04d 100644 --- a/src/include/gnunet_ats_service.h +++ b/src/include/gnunet_ats_service.h @@ -344,7 +344,7 @@ GNUNET_ATS_address_add_session (struct GNUNET_ATS_AddressRecord *ar, * @param session session handle * @return #GNUNET_YES if the @a ar was destroyed because * it was an incoming address, - * #GNUNET_NO if the @ar was kept because we can + * #GNUNET_NO if the @a ar was kept because we can * use it still to establish a new session */ int diff --git a/src/include/gnunet_block_group_lib.h b/src/include/gnunet_block_group_lib.h index d242ceefb..53827f5f4 100644 --- a/src/include/gnunet_block_group_lib.h +++ b/src/include/gnunet_block_group_lib.h @@ -90,7 +90,7 @@ GNUNET_BLOCK_GROUP_bf_create (void *cls, * @param bg block group to use for testing * @param hc hash of element to evaluate * @return #GNUNET_YES if @a hc is (likely) a duplicate - * #GNUNET_NO if @a hc was definitively not in @bg (but now is) + * #GNUNET_NO if @a hc was definitively not in @a bg (but now is) */ enum GNUNET_GenericReturnValue GNUNET_BLOCK_GROUP_bf_test_and_set (struct GNUNET_BLOCK_Group *bg, diff --git a/src/include/gnunet_block_lib.h b/src/include/gnunet_block_lib.h index fe6c99613..a9a5ec8af 100644 --- a/src/include/gnunet_block_lib.h +++ b/src/include/gnunet_block_lib.h @@ -272,7 +272,7 @@ GNUNET_BLOCK_group_set_seen (struct GNUNET_BLOCK_Group *bg, /** * Try merging two block groups. Afterwards, @a bg1 should remain - * valid and contain the rules from both @a bg1 and @bg2, and + * valid and contain the rules from both @a bg1 and @a bg2, and * @a bg2 should be destroyed (as part of this call). The latter * should happen even if merging is not supported. * diff --git a/src/include/gnunet_configuration_lib.h b/src/include/gnunet_configuration_lib.h index ac0013e94..2d26f3c05 100644 --- a/src/include/gnunet_configuration_lib.h +++ b/src/include/gnunet_configuration_lib.h @@ -174,7 +174,7 @@ GNUNET_CONFIGURATION_serialize_diagnostics ( * @param mem the memory block of serialized configuration * @param size the size of the memory block * @param source_filename source filename, will be used - * to resolve relative @INLINE@ statements + * to resolve relative \@INLINE\@ statements * @return #GNUNET_OK on success, #GNUNET_SYSERR on error */ enum GNUNET_GenericReturnValue diff --git a/src/include/gnunet_crypto_lib.h b/src/include/gnunet_crypto_lib.h index 7ff50dda1..cb0b0d9a3 100644 --- a/src/include/gnunet_crypto_lib.h +++ b/src/include/gnunet_crypto_lib.h @@ -2432,7 +2432,7 @@ GNUNET_CRYPTO_paillier_encrypt ( * @param private_key Private key to use for decryption. * @param public_key Public key to use for decryption. * @param ciphertext Ciphertext to decrypt. - * @param[out] m Decryption of @a ciphertext with @private_key. + * @param[out] m Decryption of @a ciphertext with @a private_key. */ void GNUNET_CRYPTO_paillier_decrypt ( diff --git a/src/include/gnunet_curl_lib.h b/src/include/gnunet_curl_lib.h index b5d62ba0f..fdd05600c 100644 --- a/src/include/gnunet_curl_lib.h +++ b/src/include/gnunet_curl_lib.h @@ -224,7 +224,7 @@ typedef void * be executed AND cleaned up * @param jcc callback to invoke upon completion * @param jcc_cls closure for @a jcc - * @return NULL on error (in this case, @eh is still released!) + * @return NULL on error (in this case, @a eh is still released!) */ struct GNUNET_CURL_Job * GNUNET_CURL_job_add (struct GNUNET_CURL_Context *ctx, @@ -246,7 +246,7 @@ GNUNET_CURL_job_add (struct GNUNET_CURL_Context *ctx, * be executed AND cleaned up * @param jcc callback to invoke upon completion * @param jcc_cls closure for @a jcc - * @return NULL on error (in this case, @eh is still released!) + * @return NULL on error (in this case, @a eh is still released!) */ struct GNUNET_CURL_Job * GNUNET_CURL_job_add_with_ct_json (struct GNUNET_CURL_Context *ctx, @@ -304,7 +304,7 @@ GNUNET_CURL_set_tlscert (struct GNUNET_CURL_Context *ctx, * @param job_headers extra headers to add for this request * @param jcc callback to invoke upon completion * @param jcc_cls closure for @a jcc - * @return NULL on error (in this case, @eh is still released!) + * @return NULL on error (in this case, @a eh is still released!) */ struct GNUNET_CURL_Job * GNUNET_CURL_job_add2 (struct GNUNET_CURL_Context *ctx, @@ -327,7 +327,7 @@ GNUNET_CURL_job_add2 (struct GNUNET_CURL_Context *ctx, * @param max_reply_size largest acceptable response body * @param jcc callback to invoke upon completion * @param jcc_cls closure for @a jcc - * @return NULL on error (in this case, @eh is still released!) + * @return NULL on error (in this case, @a eh is still released!) */ struct GNUNET_CURL_Job * GNUNET_CURL_job_add_raw (struct GNUNET_CURL_Context *ctx, diff --git a/src/include/gnunet_dhtu_plugin.h b/src/include/gnunet_dhtu_plugin.h index fa0b5f667..81b0f1d7b 100644 --- a/src/include/gnunet_dhtu_plugin.h +++ b/src/include/gnunet_dhtu_plugin.h @@ -119,7 +119,7 @@ struct GNUNET_DHTU_PluginEnvironment * @param cls the closure * @param target handle to the target, * pointer will remain valid until @e disconnect_cb is called - * @para pid peer identity, + * @param pid peer identity, * pointer will remain valid until @e disconnect_cb is called * @param[out] ctx storage space for DHT to use in association with this target */ diff --git a/src/include/gnunet_my_lib.h b/src/include/gnunet_my_lib.h index 0c95d50d0..74f8353e0 100644 --- a/src/include/gnunet_my_lib.h +++ b/src/include/gnunet_my_lib.h @@ -126,7 +126,7 @@ struct GNUNET_MY_QueryParam * @a ptr_size bytes.FG * * @param ptr pointer to the query parameter to pass - * @oaran ptr_size number of bytes in @a ptr + * @param ptr_size number of bytes in @a ptr */ struct GNUNET_MY_QueryParam GNUNET_MY_query_param_fixed_size (const void *ptr, @@ -262,7 +262,7 @@ struct GNUNET_MY_ResultSpec * MySQL, store in already allocated buffer at @a ptr. * * @spec ptr where to write the result - * @oaran ptr_size number of bytes available at @a ptr + * @param ptr_size number of bytes available at @a ptr */ struct GNUNET_MY_ResultSpec GNUNET_MY_result_spec_fixed_size (void *ptr, @@ -271,7 +271,7 @@ GNUNET_MY_result_spec_fixed_size (void *ptr, /** * Generate query parameter for a string * - *@param ptr pointer to the string query parameter to pass + * @param ptr pointer to the string query parameter to pass */ struct GNUNET_MY_QueryParam GNUNET_MY_query_param_string (const char *ptr); @@ -339,7 +339,7 @@ GNUNET_MY_query_param_uint16 (const uint16_t *x); /** * Generate query parameter for an uint32_t in host byte order * - *@param x pointer to the query parameter to pass + * @param x pointer to the query parameter to pass */ struct GNUNET_MY_QueryParam GNUNET_MY_query_param_uint32 (const uint32_t *x); @@ -347,7 +347,7 @@ GNUNET_MY_query_param_uint32 (const uint32_t *x); /** * Generate query parameter for an uint64_t in host byte order * - *@param x pointer to the query parameter to pass + * @param x pointer to the query parameter to pass */ struct GNUNET_MY_QueryParam GNUNET_MY_query_param_uint64 (const uint64_t *x); diff --git a/src/include/gnunet_pq_lib.h b/src/include/gnunet_pq_lib.h index 2263704aa..c4fec0a10 100644 --- a/src/include/gnunet_pq_lib.h +++ b/src/include/gnunet_pq_lib.h @@ -118,7 +118,7 @@ GNUNET_PQ_query_param_null (void); * @a ptr_size bytes. * * @param ptr pointer to the query parameter to pass - * @oaran ptr_size number of bytes in @a ptr + * @param ptr_size number of bytes in @a ptr * @return query parameter to use */ struct GNUNET_PQ_QueryParam @@ -895,14 +895,14 @@ enum GNUNET_PQ_Options * configuration. Initialize logging via GNUnet's log routines and disable * Postgres's logger. Also ensures that the statements in @a load_path and @a * es are executed whenever we (re)connect to the database, and that the - * prepared statements in @a ps are "ready". If statements in @es fail that + * prepared statements in @a ps are "ready". If statements in @a es fail that * were created with #GNUNET_PQ_make_execute(), then the entire operation * fails. * * In @a load_path, a list of "$XXXX.sql" files is expected where $XXXX * must be a sequence of contiguous integer values starting at 0000. * These files are then loaded in sequence using "psql $config_str" before - * running statements from @e es. The directory is inspected again on + * running statements from @a es. The directory is inspected again on * reconnect. * * @param config_str configuration to use @@ -939,7 +939,7 @@ GNUNET_PQ_exec_sql (struct GNUNET_PQ_Context *db, * configuration. Initialize logging via GNUnet's log routines and disable * Postgres's logger. Also ensures that the statements in @a load_path and @a * es are executed whenever we (re)connect to the database, and that the - * prepared statements in @a ps are "ready". If statements in @es fail that + * prepared statements in @a ps are "ready". If statements in @a es fail that * were created with #GNUNET_PQ_make_execute(), then the entire operation * fails. * diff --git a/src/include/gnunet_sq_lib.h b/src/include/gnunet_sq_lib.h index 51713e755..3406b9031 100644 --- a/src/include/gnunet_sq_lib.h +++ b/src/include/gnunet_sq_lib.h @@ -91,7 +91,7 @@ struct GNUNET_SQ_QueryParam * @a ptr_size bytes. * * @param ptr pointer to the query parameter to pass - * @oaran ptr_size number of bytes in @a ptr + * @param ptr_size number of bytes in @a ptr */ struct GNUNET_SQ_QueryParam GNUNET_SQ_query_param_fixed_size (const void *ptr, diff --git a/src/namestore/gnunet-namestore-fcfsd.c b/src/namestore/gnunet-namestore-fcfsd.c index 7e96ffa43..4a9c6e874 100644 --- a/src/namestore/gnunet-namestore-fcfsd.c +++ b/src/namestore/gnunet-namestore-fcfsd.c @@ -1137,7 +1137,7 @@ run_service (void *cls, * The main function of the fcfs daemon. * * @param argc number of arguments from the command line - * @parsm argv the command line arguments + * @param argv the command line arguments * @return 0 successful exit, a different value otherwise */ int diff --git a/src/nse/gnunet-service-nse.c b/src/nse/gnunet-service-nse.c index 56014752d..ee1cb025f 100644 --- a/src/nse/gnunet-service-nse.c +++ b/src/nse/gnunet-service-nse.c @@ -1199,7 +1199,7 @@ handle_core_connect (void *cls, * * @param cls closure * @param peer peer identity this notification is about - * @parma internal_cls the `struct NSEPeerEntry` for the @a peer + * @param internal_cls the `struct NSEPeerEntry` for the @a peer */ static void handle_core_disconnect (void *cls, diff --git a/src/reclaim/gnunet-service-reclaim.c b/src/reclaim/gnunet-service-reclaim.c index 84a98d1e4..9f035f1bd 100644 --- a/src/reclaim/gnunet-service-reclaim.c +++ b/src/reclaim/gnunet-service-reclaim.c @@ -723,8 +723,8 @@ issue_ticket_result_cb (void *cls, /** * Check issue ticket message * - * @cls unused - * @im message to check + * @param cls unused + * @param im message to check * @return GNUNET_OK if message is ok */ static int @@ -937,7 +937,7 @@ check_consume_ticket_message (void *cls, const struct ConsumeTicketMessage *cm) * Handle a consume ticket message * * @param cls our client handle - * @cm the message to handle + * @param cm the message to handle */ static void handle_consume_ticket_message (void *cls, const struct ConsumeTicketMessage *cm) @@ -1686,8 +1686,8 @@ attr_delete_cont (void *cls, int32_t success, const char *emsg) /** * Check attribute delete message format * - * @cls unused - * @dam message to check + * @param cls unused + * @param dam message to check */ static int check_attribute_delete_message (void *cls, @@ -1777,8 +1777,8 @@ cred_delete_cont (void *cls, int32_t success, const char *emsg) /** * Check credential delete message format * - * @cls unused - * @dam message to check + * @param cls unused + * @param dam message to check */ static int check_credential_delete_message (void *cls, diff --git a/src/reclaim/gnunet-service-reclaim_tickets.c b/src/reclaim/gnunet-service-reclaim_tickets.c index 23b617a7f..c961ba5b2 100644 --- a/src/reclaim/gnunet-service-reclaim_tickets.c +++ b/src/reclaim/gnunet-service-reclaim_tickets.c @@ -1671,7 +1671,7 @@ cleanup_iter (struct RECLAIM_TICKETS_Iterator *iter) /** - * Return each record of type @GNUNET_GNSRECORD_TYPE_RECLAIM_TICKET + * Return each record of type #GNUNET_GNSRECORD_TYPE_RECLAIM_TICKET * to the caller and proceed with the iteration. * FIXME: Should we _not_ proceed automatically here? * diff --git a/src/regex/gnunet-service-regex.c b/src/regex/gnunet-service-regex.c index deaa6112e..dc61b9135 100644 --- a/src/regex/gnunet-service-regex.c +++ b/src/regex/gnunet-service-regex.c @@ -124,7 +124,7 @@ reannounce (void *cls) * * @param cls identification of the client * @param am the actual message - * @return #GNUNET_OK if @am is well-formed + * @return #GNUNET_OK if @a am is well-formed */ static int check_announce (void *cls, diff --git a/src/sq/sq_query_helper.c b/src/sq/sq_query_helper.c index 1f7662b95..ead1b5bdd 100644 --- a/src/sq/sq_query_helper.c +++ b/src/sq/sq_query_helper.c @@ -60,7 +60,7 @@ bind_fixed_blob (void *cls, * @a ptr_size bytes. * * @param ptr pointer to the query parameter to pass - * @oaran ptr_size number of bytes in @a ptr + * @param ptr_size number of bytes in @a ptr */ struct GNUNET_SQ_QueryParam GNUNET_SQ_query_param_fixed_size (const void *ptr, diff --git a/src/transport/gnunet-service-tng.c b/src/transport/gnunet-service-tng.c index 7efe07fda..7ea34735b 100644 --- a/src/transport/gnunet-service-tng.c +++ b/src/transport/gnunet-service-tng.c @@ -3247,7 +3247,7 @@ struct MonitorEvent /** - * Free a @dvh. Callers MAY want to check if this was the last path to the + * Free a @a dvh. Callers MAY want to check if this was the last path to the * `target`, and if so call #free_dv_route to also free the associated DV * entry in #dv_routes (if not, the associated scheduler job should eventually * take care of it). @@ -7550,7 +7550,7 @@ check_dv_box (void *cls, const struct TransportDVBoxMessage *dvb) /** * Create a DV Box message and queue it for transmission to - * @ea next_hop. + * @a next_hop. * * @param next_hop peer to receive the message next * @param total_hops how many hops did the message take so far diff --git a/src/transport/transport-testing-main.c b/src/transport/transport-testing-main.c index 20c58eeee..8d1727d77 100644 --- a/src/transport/transport-testing-main.c +++ b/src/transport/transport-testing-main.c @@ -253,7 +253,7 @@ my_nc (void *cls, * * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` * @param peer peer we got disconnected from - * @param custom_cls return value from @my_nc + * @param custom_cls return value from @a my_nc */ static void my_nd (void *cls, diff --git a/src/transport/transport-testing-main2.c b/src/transport/transport-testing-main2.c index 62aa3ceb7..de0b7f4cd 100644 --- a/src/transport/transport-testing-main2.c +++ b/src/transport/transport-testing-main2.c @@ -253,7 +253,7 @@ my_nc (void *cls, * * @param cls our `struct GNUNET_TRANSPORT_TESTING_InternalPeerContext *` * @param peer peer we got disconnected from - * @param custom_cls return value from @my_nc + * @param custom_cls return value from @a my_nc */ static void my_nd (void *cls, diff --git a/src/transport/transport_api_monitor_plugins.c b/src/transport/transport_api_monitor_plugins.c index d8eddddaa..43a11442b 100644 --- a/src/transport/transport_api_monitor_plugins.c +++ b/src/transport/transport_api_monitor_plugins.c @@ -211,7 +211,7 @@ locate_by_id (void *cls, * Function called with responses from the service. * * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` - * @paramm tpmm message with event data + * @param tpmm message with event data * @return #GNUNET_Ok if message is well-formed */ static int @@ -243,7 +243,7 @@ check_event (void *cls, * Function called with responses from the service. * * @param cls our `struct GNUNET_TRANSPORT_PluginMonitor *` - * @paramm tpmm message with event data + * @param tpmm message with event data */ static void handle_event (void *cls, diff --git a/src/util/configuration.c b/src/util/configuration.c index 27e6cf612..5c415aff7 100644 --- a/src/util/configuration.c +++ b/src/util/configuration.c @@ -91,7 +91,7 @@ struct ConfigSection /** * Is the configuration section marked as inaccessible? * - * This can happen if the section name is used in an @inline-secret@ + * This can happen if the section name is used in an \@inline-secret\@ * directive, but the referenced file can't be found or accessed. */ bool inaccessible; @@ -135,7 +135,7 @@ struct ConfigFile /** * Was this configuration file parsed via - * @inline-secret@? + * \@inline-secret\@? */ char *hint_restrict_section; diff --git a/src/util/gnunet-service-resolver.c b/src/util/gnunet-service-resolver.c index 9bde04117..8a89fbb37 100644 --- a/src/util/gnunet-service-resolver.c +++ b/src/util/gnunet-service-resolver.c @@ -314,7 +314,7 @@ extract_search_domain (const char *line, size_t line_len) * Reads the list of nameservers from /etc/resolve.conf * * @param server_addrs[out] a list of null-terminated server address strings - * @return the number of server addresses in @server_addrs, -1 on error + * @return the number of server addresses in @a server_addrs, -1 on error */ static int lookup_dns_servers (char ***server_addrs) -- cgit v1.2.3 From 752df719ef55e74a78d2ab3c0c971ff7cfe8d6d3 Mon Sep 17 00:00:00 2001 From: Willow Liquorice Date: Sun, 4 Sep 2022 02:58:27 +0100 Subject: -DOC: Another comment stripping pass through RECLAIM --- src/reclaim/gnunet-service-reclaim_tickets.c | 9 --------- src/reclaim/oidc_helper.h | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) (limited to 'src/reclaim') diff --git a/src/reclaim/gnunet-service-reclaim_tickets.c b/src/reclaim/gnunet-service-reclaim_tickets.c index c961ba5b2..3fc885aaf 100644 --- a/src/reclaim/gnunet-service-reclaim_tickets.c +++ b/src/reclaim/gnunet-service-reclaim_tickets.c @@ -568,7 +568,6 @@ rvk_ns_err (void *cls) * want to revoke. * When we are done, we need to update any other ticket which * included references to any of the changed attributes. - * (Implementation further below) * * @param rvk handle to the operation */ @@ -757,14 +756,6 @@ rvk_move_attr_cb (void *cls, } -/** - * We change every attribute ID of the ticket attributes we - * want to revoke. - * When we are done, we need to update any other ticket which - * included references to any of the changed attributes. - * - * @param rvk handle to the operation - */ static void move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rvk) { diff --git a/src/reclaim/oidc_helper.h b/src/reclaim/oidc_helper.h index b134c71ad..21c7aa86e 100644 --- a/src/reclaim/oidc_helper.h +++ b/src/reclaim/oidc_helper.h @@ -162,7 +162,7 @@ OIDC_access_token_new (const struct GNUNET_RECLAIM_Ticket *ticket); * Parse an access token */ int -OIDC_access_token_parse (const char*token, +OIDC_access_token_parse (const char *token, struct GNUNET_RECLAIM_Ticket **ticket); -- cgit v1.2.3 From 2803abe19c6c65c1a98a9b69cef27b5dc363f93e Mon Sep 17 00:00:00 2001 From: Willow Liquorice Date: Wed, 7 Sep 2022 20:50:41 +0100 Subject: -DOC: Documentation cleanup pass through RECLAIM subsystem --- src/include/gnunet_reclaim_lib.h | 14 +++++++------- src/include/gnunet_reclaim_service.h | 6 +++--- src/reclaim/gnunet-service-reclaim.c | 2 +- src/reclaim/gnunet-service-reclaim_tickets.c | 10 +++++----- src/reclaim/oidc_helper.c | 11 ----------- src/reclaim/oidc_helper.h | 4 ++-- src/reclaim/reclaim_api.c | 19 +++--------------- src/reclaim/reclaim_attribute.c | 25 ++++-------------------- src/reclaim/reclaim_credential.c | 29 ++++++---------------------- 9 files changed, 31 insertions(+), 89 deletions(-) (limited to 'src/reclaim') diff --git a/src/include/gnunet_reclaim_lib.h b/src/include/gnunet_reclaim_lib.h index 0d5ef59b7..35b58cd0e 100644 --- a/src/include/gnunet_reclaim_lib.h +++ b/src/include/gnunet_reclaim_lib.h @@ -515,7 +515,7 @@ GNUNET_RECLAIM_attribute_number_to_typename (uint32_t type); /** * Get required size for serialization buffer * - * @param attrs the attribute list to serialize + * @param credentials the attribute list to serialize * @return the required buffer size */ size_t @@ -524,9 +524,9 @@ GNUNET_RECLAIM_credential_list_serialize_get_size ( /** - * Destroy claim list + * Destroy credential list * - * @param attrs list to destroy + * @param credentials list to destroy */ void GNUNET_RECLAIM_credential_list_destroy ( @@ -551,15 +551,15 @@ GNUNET_RECLAIM_credential_list_add ( /** - * Serialize an attribute list + * Serialize a credential list * - * @param attrs the attribute list to serialize - * @param result the serialized attribute + * @param credentials the credential list to serialize + * @param result the serialized credential * @return length of serialized data */ size_t GNUNET_RECLAIM_credential_list_serialize ( - const struct GNUNET_RECLAIM_CredentialList *attrs, + const struct GNUNET_RECLAIM_CredentialList *credentials, char *result); diff --git a/src/include/gnunet_reclaim_service.h b/src/include/gnunet_reclaim_service.h index b80436e6b..e9e0f144d 100644 --- a/src/include/gnunet_reclaim_service.h +++ b/src/include/gnunet_reclaim_service.h @@ -200,7 +200,7 @@ GNUNET_RECLAIM_attribute_store ( * * @param h handle to the re:claimID service * @param pkey private key of the identity - * @param attr the credential value + * @param credential the credential value * @param exp_interval the relative expiration interval for the credential * @param cont continuation to call when done * @param cont_cls closure for @a cont @@ -349,7 +349,7 @@ GNUNET_RECLAIM_get_credentials_start ( * Calls the record processor specified in #GNUNET_RECLAIM_get_credentials_start * for the next record. * - * @param it the iterator + * @param ait the iterator */ void GNUNET_RECLAIM_get_credentials_next ( @@ -361,7 +361,7 @@ GNUNET_RECLAIM_get_credentials_next ( * be called on any iteration that has not yet completed prior to calling * #GNUNET_RECLAIM_disconnect. * - * @param it the iterator + * @param ait the iterator */ void GNUNET_RECLAIM_get_credentials_stop ( diff --git a/src/reclaim/gnunet-service-reclaim.c b/src/reclaim/gnunet-service-reclaim.c index 9f035f1bd..5290621d6 100644 --- a/src/reclaim/gnunet-service-reclaim.c +++ b/src/reclaim/gnunet-service-reclaim.c @@ -522,7 +522,7 @@ cleanup_adh (struct AttributeDeleteHandle *adh) /** * Cleanup attribute store handle * - * @param handle handle to clean up + * @param ash handle to clean up */ static void cleanup_as_handle (struct AttributeStoreHandle *ash) diff --git a/src/reclaim/gnunet-service-reclaim_tickets.c b/src/reclaim/gnunet-service-reclaim_tickets.c index 3fc885aaf..a17dfb0e2 100644 --- a/src/reclaim/gnunet-service-reclaim_tickets.c +++ b/src/reclaim/gnunet-service-reclaim_tickets.c @@ -485,7 +485,7 @@ rvk_ticket_update_finished (void *cls) * @param cls handle to the operation * @param zone ticket issuer private key * @param label ticket rnd - * @param rd_cound size of record set + * @param rd_count size of record set * @param rd record set */ static void @@ -569,7 +569,7 @@ rvk_ns_err (void *cls) * When we are done, we need to update any other ticket which * included references to any of the changed attributes. * - * @param rvk handle to the operation + * @param rh handle to the operation */ static void move_attrs (struct RECLAIM_TICKETS_RevokeHandle *rh); @@ -835,7 +835,7 @@ remove_ticket_cont (void *cls, int32_t success, const char *emsg) * @param cls handle to the operation * @param zone the issuer key * @param label ticket rnd - * @param rd_cound size of record set + * @param rd_count size of record set * @param rd record set */ static void @@ -986,7 +986,7 @@ cleanup_cth (struct RECLAIM_TICKETS_ConsumeHandle *cth) * We found an attribute record. * * @param cls handle to the operation - * @param rd_cound size of record set + * @param rd_count size of record set * @param rd record set */ static void @@ -1074,7 +1074,7 @@ abort_parallel_lookups (void *cls) * attribute record under the referenced label. * * @param cls handle to the operation - * @param rd_cound size of the record set + * @param rd_count size of the record set * @param rd record set */ static void diff --git a/src/reclaim/oidc_helper.c b/src/reclaim/oidc_helper.c index c87514a6b..647ebe302 100644 --- a/src/reclaim/oidc_helper.c +++ b/src/reclaim/oidc_helper.c @@ -424,17 +424,6 @@ generate_id_token_body (const struct GNUNET_IDENTITY_PublicKey *aud_key, } -/** - * Create a JWT using RSA256 algorithm from attributes - * - * @param aud_key the public of the audience - * @param sub_key the public key of the subject - * @param attrs the attribute list - * @param presentations credential presentation list (may be empty) - * @param expiration_time the validity of the token - * @param secret_rsa_key the key used to sign the JWT - * @return a new base64-encoded JWT string. - */ char * OIDC_generate_id_token_rsa (const struct GNUNET_IDENTITY_PublicKey *aud_key, const struct GNUNET_IDENTITY_PublicKey *sub_key, diff --git a/src/reclaim/oidc_helper.h b/src/reclaim/oidc_helper.h index 21c7aa86e..81eadf2ed 100644 --- a/src/reclaim/oidc_helper.h +++ b/src/reclaim/oidc_helper.h @@ -50,14 +50,14 @@ enum OIDC_VerificationOptions }; /** - * Create a JWT using RSA256 from attributes + * Create a JWT using RSA256 algorithm from attributes * * @param aud_key the public of the audience * @param sub_key the public key of the subject * @param attrs the attribute list * @param presentations credential presentation list (may be empty) * @param expiration_time the validity of the token - * @param secret_key the key used to sign the JWT + * @param secret_rsa_key the key used to sign the JWT * @return a new base64-encoded JWT string. */ char * diff --git a/src/reclaim/reclaim_api.c b/src/reclaim/reclaim_api.c index a61505d62..6f55d62e4 100644 --- a/src/reclaim/reclaim_api.c +++ b/src/reclaim/reclaim_api.c @@ -1206,7 +1206,7 @@ struct GNUNET_RECLAIM_Operation * GNUNET_RECLAIM_credential_store ( struct GNUNET_RECLAIM_Handle *h, const struct GNUNET_IDENTITY_PrivateKey *pkey, - const struct GNUNET_RECLAIM_Credential *attr, + const struct GNUNET_RECLAIM_Credential *credential, const struct GNUNET_TIME_Relative *exp_interval, GNUNET_RECLAIM_ContinuationWithStatus cont, void *cont_cls) @@ -1221,7 +1221,7 @@ GNUNET_RECLAIM_credential_store ( op->cls = cont_cls; op->r_id = h->r_id_gen++; GNUNET_CONTAINER_DLL_insert_tail (h->op_head, h->op_tail, op); - attr_len = GNUNET_RECLAIM_credential_serialize_get_size (attr); + attr_len = GNUNET_RECLAIM_credential_serialize_get_size (credential); op->env = GNUNET_MQ_msg_extra (sam, attr_len, GNUNET_MESSAGE_TYPE_RECLAIM_CREDENTIAL_STORE); @@ -1229,7 +1229,7 @@ GNUNET_RECLAIM_credential_store ( sam->id = htonl (op->r_id); sam->exp = GNUNET_htonll (exp_interval->rel_value_us); - GNUNET_RECLAIM_credential_serialize (attr, (char *) &sam[1]); + GNUNET_RECLAIM_credential_serialize (credential, (char *) &sam[1]); sam->attr_len = htons (attr_len); if (NULL != h->mq) @@ -1439,12 +1439,6 @@ GNUNET_RECLAIM_get_credentials_start ( } -/** - * Calls the record processor specified in #GNUNET_RECLAIM_get_credential_start - * for the next record. - * - * @param it the iterator - */ void GNUNET_RECLAIM_get_credentials_next (struct GNUNET_RECLAIM_CredentialIterator *ait) @@ -1460,13 +1454,6 @@ GNUNET_RECLAIM_get_credentials_next (struct } -/** - * Stops iteration and releases the handle for further calls. Must - * be called on any iteration that has not yet completed prior to calling - * #GNUNET_RECLAIM_disconnect. - * - * @param it the iterator - */ void GNUNET_RECLAIM_get_credentials_stop (struct GNUNET_RECLAIM_CredentialIterator *ait) diff --git a/src/reclaim/reclaim_attribute.c b/src/reclaim/reclaim_attribute.c index 5d7adb7e6..b5c41b2d1 100644 --- a/src/reclaim/reclaim_attribute.c +++ b/src/reclaim/reclaim_attribute.c @@ -325,16 +325,9 @@ GNUNET_RECLAIM_attribute_list_serialize_get_size ( } -/** - * Serialize an attribute list - * - * @param attrs the attribute list to serialize - * @param result the serialized attribute - * @return length of serialized data - */ size_t GNUNET_RECLAIM_attribute_list_serialize ( - const struct GNUNET_RECLAIM_AttributeList *al, + const struct GNUNET_RECLAIM_AttributeList *attrs, char *result) { struct GNUNET_RECLAIM_AttributeListEntry *ale; @@ -343,7 +336,7 @@ GNUNET_RECLAIM_attribute_list_serialize ( char *write_ptr; write_ptr = result; total_len = 0; - for (ale = al->list_head; NULL != ale; ale = ale->next) + for (ale = attrs->list_head; NULL != ale; ale = ale->next) { GNUNET_assert (NULL != ale->attribute); len = GNUNET_RECLAIM_attribute_serialize (ale->attribute, write_ptr); @@ -396,21 +389,16 @@ GNUNET_RECLAIM_attribute_list_deserialize (const char *data, size_t data_size) } -/** - * Make a (deep) copy of a claim list - * @param attrs claim list to copy - * @return copied claim list - */ struct GNUNET_RECLAIM_AttributeList * GNUNET_RECLAIM_attribute_list_dup ( - const struct GNUNET_RECLAIM_AttributeList *al) + const struct GNUNET_RECLAIM_AttributeList *attrs) { struct GNUNET_RECLAIM_AttributeListEntry *ale; struct GNUNET_RECLAIM_AttributeListEntry *result_ale; struct GNUNET_RECLAIM_AttributeList *result; result = GNUNET_new (struct GNUNET_RECLAIM_AttributeList); - for (ale = al->list_head; NULL != ale; ale = ale->next) + for (ale = attrs->list_head; NULL != ale; ale = ale->next) { result_ale = GNUNET_new (struct GNUNET_RECLAIM_AttributeListEntry); GNUNET_assert (NULL != ale->attribute); @@ -433,11 +421,6 @@ GNUNET_RECLAIM_attribute_list_dup ( } -/** - * Destroy claim list - * - * @param attrs list to destroy - */ void GNUNET_RECLAIM_attribute_list_destroy ( struct GNUNET_RECLAIM_AttributeList *al) diff --git a/src/reclaim/reclaim_credential.c b/src/reclaim/reclaim_credential.c index b1312f403..6dc1a1fcf 100644 --- a/src/reclaim/reclaim_credential.c +++ b/src/reclaim/reclaim_credential.c @@ -301,13 +301,6 @@ GNUNET_RECLAIM_credential_list_serialize_get_size ( } -/** - * Serialize an attribute list - * - * @param attrs the attribute list to serialize - * @param result the serialized attribute - * @return length of serialized data - */ size_t GNUNET_RECLAIM_credential_list_serialize ( const struct GNUNET_RECLAIM_CredentialList *credentials, @@ -399,19 +392,14 @@ GNUNET_RECLAIM_credential_list_dup ( } -/** - * Destroy credential list - * - * @param attrs list to destroy - */ void GNUNET_RECLAIM_credential_list_destroy ( - struct GNUNET_RECLAIM_CredentialList *al) + struct GNUNET_RECLAIM_CredentialList *credentials) { struct GNUNET_RECLAIM_CredentialListEntry *ale; struct GNUNET_RECLAIM_CredentialListEntry *tmp_ale; - for (ale = al->list_head; NULL != ale;) + for (ale = credentials->list_head; NULL != ale;) { if (NULL != ale->credential) GNUNET_free (ale->credential); @@ -419,7 +407,7 @@ GNUNET_RECLAIM_credential_list_destroy ( ale = ale->next; GNUNET_free (tmp_ale); } - GNUNET_free (al); + GNUNET_free (credentials); } @@ -826,19 +814,14 @@ GNUNET_RECLAIM_presentation_list_dup ( } -/** - * Destroy presentation list - * - * @param attrs list to destroy - */ void GNUNET_RECLAIM_presentation_list_destroy ( - struct GNUNET_RECLAIM_PresentationList *al) + struct GNUNET_RECLAIM_PresentationList *presentations) { struct GNUNET_RECLAIM_PresentationListEntry *ale; struct GNUNET_RECLAIM_PresentationListEntry *tmp_ale; - for (ale = al->list_head; NULL != ale;) + for (ale = presentations->list_head; NULL != ale;) { if (NULL != ale->presentation) GNUNET_free (ale->presentation); @@ -846,7 +829,7 @@ GNUNET_RECLAIM_presentation_list_destroy ( ale = ale->next; GNUNET_free (tmp_ale); } - GNUNET_free (al); + GNUNET_free (presentations); } -- cgit v1.2.3