From adbb529b74ba2cc63880c11522c09b50fef34823 Mon Sep 17 00:00:00 2001 From: Julius Bünger Date: Mon, 25 Feb 2019 20:36:44 +0100 Subject: RPS sampler: An id might be removed while a request is still pending --- src/rps/gnunet-service-rps_sampler.h | 6 ++++++ 1 file changed, 6 insertions(+) (limited to 'src/rps/gnunet-service-rps_sampler.h') diff --git a/src/rps/gnunet-service-rps_sampler.h b/src/rps/gnunet-service-rps_sampler.h index 9f60aa7c9..921570f7d 100644 --- a/src/rps/gnunet-service-rps_sampler.h +++ b/src/rps/gnunet-service-rps_sampler.h @@ -90,6 +90,12 @@ RPS_sampler_update (struct RPS_Sampler *sampler, * * Used to get rid of a PeerID. * + * FIXME: This should also consider currently pending requests + * (Pending requests already collect peerids. As long as not all + * requested IDs have been collected, they are kept. + * Ideally, the @p id should be removed from all pending requests. This + * seems quite complicated.) + * * @param sampler the sampler to reinitialise a sampler in. * @param id the id of the samplers to update. */ -- cgit v1.2.3