From 7e3cf5f461eb4fbb7581672bf0835da07c378136 Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Thu, 31 Oct 2019 13:03:48 +0100 Subject: tighten formatting rules --- src/set/gnunet-service-set.c | 3 +-- src/set/gnunet-service-set.h | 1 - src/set/gnunet-service-set_union.c | 7 +++---- src/set/gnunet-service-set_union.h | 2 -- src/set/gnunet-set-profiler.c | 2 +- src/set/ibf.c | 1 + src/set/ibf_sim.c | 4 ++-- src/set/plugin_block_set_test.c | 1 + src/set/set_api.c | 1 + 9 files changed, 10 insertions(+), 12 deletions(-) (limited to 'src/set') diff --git a/src/set/gnunet-service-set.c b/src/set/gnunet-service-set.c index 6e49599a2..8b46f68de 100644 --- a/src/set/gnunet-service-set.c +++ b/src/set/gnunet-service-set.c @@ -1775,8 +1775,7 @@ handle_client_cancel (void *cls, const struct GNUNET_SET_CancelMessage *msg) * the other peer disconnecting. The client may not know about this * yet and try to cancel the (just barely non-existent) operation. * So this is not a hard error. - */ - GNUNET_log (GNUNET_ERROR_TYPE_INFO, + */GNUNET_log (GNUNET_ERROR_TYPE_INFO, "Client canceled non-existent op %u\n", (uint32_t) ntohl (msg->request_id)); } diff --git a/src/set/gnunet-service-set.h b/src/set/gnunet-service-set.h index 402281da4..e118828be 100644 --- a/src/set/gnunet-service-set.h +++ b/src/set/gnunet-service-set.h @@ -154,7 +154,6 @@ typedef void (*OpChannelDeathImpl) (struct Operation *op); - /** * Dispatch table for a specific set operation. Every set operation * has to implement the callback in this struct. diff --git a/src/set/gnunet-service-set_union.c b/src/set/gnunet-service-set_union.c index ca4ef2092..87c6faf98 100644 --- a/src/set/gnunet-service-set_union.c +++ b/src/set/gnunet-service-set_union.c @@ -2168,8 +2168,7 @@ handle_union_p2p_done (void *cls, * We should notify the active peer once * all our demands are satisfied, so that the active * peer can quit if we gave it everything. - */ - GNUNET_CADET_receive_done (op->channel); + */GNUNET_CADET_receive_done (op->channel); maybe_finish (op); return; @@ -2182,8 +2181,7 @@ handle_union_p2p_done (void *cls, * * We'll close the channel * to the other peer once our demands are met. - */ - op->state->phase = PHASE_FINISH_CLOSING; + */op->state->phase = PHASE_FINISH_CLOSING; GNUNET_CADET_receive_done (op->channel); maybe_finish (op); return; @@ -2195,6 +2193,7 @@ handle_union_p2p_done (void *cls, } } + /** * Handle a over message from a remote peer * diff --git a/src/set/gnunet-service-set_union.h b/src/set/gnunet-service-set_union.h index 5da5b7254..2c0262f07 100644 --- a/src/set/gnunet-service-set_union.h +++ b/src/set/gnunet-service-set_union.h @@ -151,7 +151,6 @@ handle_union_p2p_inquiry (void *cls, const struct InquiryMessage *msg); - /** * Handle a request for full set transmission. * @@ -163,7 +162,6 @@ handle_union_p2p_request_full (void *cls, const struct GNUNET_MessageHeader *mh); - /** * Handle a "full done" message. * diff --git a/src/set/gnunet-set-profiler.c b/src/set/gnunet-set-profiler.c index 81263966a..3014861a6 100644 --- a/src/set/gnunet-set-profiler.c +++ b/src/set/gnunet-set-profiler.c @@ -138,7 +138,7 @@ statistics_done (void *cls, static void check_all_done (void) { - if ((info1.done == GNUNET_NO)||(info2.done == GNUNET_NO)) + if ((info1.done == GNUNET_NO) || (info2.done == GNUNET_NO)) return; GNUNET_CONTAINER_multihashmap_iterate (info1.received, map_remove_iterator, diff --git a/src/set/ibf.c b/src/set/ibf.c index 7c7adaa3c..1532afceb 100644 --- a/src/set/ibf.c +++ b/src/set/ibf.c @@ -45,6 +45,7 @@ ibf_key_from_hashcode (const struct GNUNET_HashCode *hash) return *(struct IBF_Key *) hash; } + /** * Create a hashcode from a key, by replicating the key * until the hascode is filled diff --git a/src/set/ibf_sim.c b/src/set/ibf_sim.c index 226a9d751..6415d00e1 100644 --- a/src/set/ibf_sim.c +++ b/src/set/ibf_sim.c @@ -93,8 +93,7 @@ main (int argc, char **argv) get 990/1000 elements on average over 1 million runs; key idea being to stop short of the 'last' possible IBF as otherwise a "lowball" per-chance would unduely influence the - result */ - if ((j > 0) && + result */if ((j > 0) && (buckets[j - 1] > MAX_IBF_DECODE)) { ret *= (1 << (j + 1)); @@ -136,6 +135,7 @@ main (int argc, char **argv) return 0; } + /* TODO: should calculate stddev of the results to also be able to say something about the stability of the results, outside of large-scale averages -- gaining 8% precision at the expense of diff --git a/src/set/plugin_block_set_test.c b/src/set/plugin_block_set_test.c index a9da9d549..1de086092 100644 --- a/src/set/plugin_block_set_test.c +++ b/src/set/plugin_block_set_test.c @@ -119,4 +119,5 @@ libgnunet_plugin_block_set_test_done (void *cls) return NULL; } + /* end of plugin_block_set_test.c */ diff --git a/src/set/set_api.c b/src/set/set_api.c index 961bfdba9..ce4b1c965 100644 --- a/src/set/set_api.c +++ b/src/set/set_api.c @@ -1257,4 +1257,5 @@ GNUNET_SET_element_hash (const struct GNUNET_SET_Element *element, GNUNET_CRYPTO_hash_context_finish (ctx, ret_hash); } + /* end of set_api.c */ -- cgit v1.2.3