aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
-rw-r--r--ChangeLog3
-rw-r--r--src/plugins/ole2_extractor.c9
2 files changed, 9 insertions, 3 deletions
diff --git a/ChangeLog b/ChangeLog
index 91568ae..64d461a 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,6 +1,7 @@
1Thu Dec 20 22:48:47 CET 2018 1Thu Dec 20 22:48:47 CET 2018
2 Fix #5493: possible out-of-bounds read in libextractor_common 2 Fix #5493: possible out-of-bounds read in libextractor_common
3 in case of iconv() failure. -CG 3 in case of iconv() failure.
4 Fix #5494: NULL dereference in OLE2 extractor (for malformed input). -CG
4 5
5Sun Dec 2 12:05:33 CET 2018 6Sun Dec 2 12:05:33 CET 2018
6 Fix #5488: do not export non-public functions from API. -CG 7 Fix #5488: do not export non-public functions from API. -CG
diff --git a/src/plugins/ole2_extractor.c b/src/plugins/ole2_extractor.c
index 53fa1b9..a48b726 100644
--- a/src/plugins/ole2_extractor.c
+++ b/src/plugins/ole2_extractor.c
@@ -173,7 +173,7 @@ struct ProcContext
173 EXTRACTOR_MetaDataProcessor proc; 173 EXTRACTOR_MetaDataProcessor proc;
174 174
175 /** 175 /**
176 * Closure for 'proc'. 176 * Closure for @e proc.
177 */ 177 */
178 void *proc_cls; 178 void *proc_cls;
179 179
@@ -213,7 +213,12 @@ process_metadata (gpointer key,
213 213
214 if (G_VALUE_TYPE(gval) == G_TYPE_STRING) 214 if (G_VALUE_TYPE(gval) == G_TYPE_STRING)
215 { 215 {
216 contents = strdup (g_value_get_string (gval)); 216 const char *gvals;
217
218 gvals = g_value_get_string (gval);
219 if (NULL == gvals)
220 return;
221 contents = strdup (gvals);
217 } 222 }
218 else 223 else
219 { 224 {