Adjusted namestore calls

Signed-off-by: TheJackiMonster <thejackimonster@gmail.com>

5 files changed, 170 insertions, 73 deletions

diff --git a/src/gnunet_chat_context.c b/src/gnunet_chat_context.c
index fe15307..e0d7082 100644
--- a/src/gnunet_chat_context.c
+++ b/src/gnunet_chat_context.c
@@ -276,9 +276,9 @@ context_write_records (struct GNUNET_CHAT_Context *context)
       context->handle->namestore,
       zone,
       label,
-      error_context_write_records,
+      error_context_open_records,
       context,
-      monitor_context_write_records,
+      monitor_context_open_records,
       context
   );
 
@@ -303,35 +303,16 @@ context_delete_records (struct GNUNET_CHAT_Context *context)
       context->room
   );
 
-  const char *type_string = "chat";
-
-  switch (context->type)
-  {
-    case GNUNET_CHAT_CONTEXT_TYPE_CONTACT:
-      type_string = "contact";
-      break;
-    case GNUNET_CHAT_CONTEXT_TYPE_GROUP:
-      type_string = "group";
-      break;
-    default:
-      break;
-  }
-
   char *label;
-  GNUNET_asprintf (
-      &label,
-      "%s_%s",
-      type_string,
-      GNUNET_h2s(hash)
-  );
+  util_get_context_label(context->type, hash, &label);
 
-  GNUNET_NAMESTORE_records_store(
+  GNUNET_NAMESTORE_records_open(
       context->handle->namestore,
       zone,
       label,
-      0,
-      NULL,
-      cont_context_write_records,
+      error_context_open_records,
+      context,
+      monitor_context_delete_records,
       context
   );
 
diff --git a/src/gnunet_chat_context_intern.c b/src/gnunet_chat_context_intern.c
index f8c61e1..79c09a2 100644
--- a/src/gnunet_chat_context_intern.c
+++ b/src/gnunet_chat_context_intern.c
@@ -64,43 +64,50 @@ it_destroy_context_invites (GNUNET_UNUSED void *cls,
 }
 
 void
-cont_context_write_records (void *cls,
-                            GNUNET_UNUSED int32_t success,
-                            const char *emsg)
+cont_context_commit_records (void *cls,
+                             GNUNET_UNUSED int32_t success,
+                             const char *emsg)
 {
   struct GNUNET_CHAT_Context *context = cls;
 
-  if (emsg)
-    handle_send_internal_message(
-        context->handle,
-        context,
-        GNUNET_CHAT_FLAG_WARNING,
-        emsg
-    );
+  if ((!emsg) || (!(context->handle)))
+    return;
+
+  handle_send_internal_message(
+      context->handle,
+      context,
+      GNUNET_CHAT_FLAG_WARNING,
+      emsg
+  );
 }
 
 void
-error_context_write_records (void *cls)
+error_context_open_records (void *cls)
 {
   struct GNUNET_CHAT_Context *context = cls;
 
+  if (!(context->handle))
+    return;
+
   handle_send_internal_message(
       context->handle,
       context,
       GNUNET_CHAT_FLAG_WARNING,
-      _("Failed opening records!")
+      _("Namestore busy!")
   );
 }
 
 void
-monitor_context_write_records (void *cls,
-                               const struct GNUNET_IDENTITY_PrivateKey *zone,
-                               const char *label,
-                               GNUNET_UNUSED unsigned int rd_count,
-                               GNUNET_UNUSED const struct GNUNET_GNSRECORD_Data *rd)
+monitor_context_open_records (void *cls,
+                              const struct GNUNET_IDENTITY_PrivateKey *zone,
+                              const char *label,
+                              GNUNET_UNUSED unsigned int rd_count,
+                              GNUNET_UNUSED const struct GNUNET_GNSRECORD_Data *rd)
 {
   struct GNUNET_CHAT_Context *context = cls;
 
+  GNUNET_assert((context) && (context->handle));
+
   const struct GNUNET_HashCode *hash = GNUNET_MESSENGER_room_get_key(
       context->room
   );
@@ -171,7 +178,29 @@ monitor_context_write_records (void *cls,
       label,
       count,
       data,
-      cont_context_write_records,
+      cont_context_commit_records,
+      context
+  );
+}
+
+void
+monitor_context_delete_records (void *cls,
+                                const struct GNUNET_IDENTITY_PrivateKey *zone,
+                                const char *label,
+                                GNUNET_UNUSED unsigned int rd_count,
+                                GNUNET_UNUSED const struct GNUNET_GNSRECORD_Data *rd)
+{
+  struct GNUNET_CHAT_Context *context = cls;
+
+  GNUNET_assert((context) && (context->handle));
+
+  GNUNET_NAMESTORE_records_commit(
+      context->handle->namestore,
+      zone,
+      label,
+      0,
+      NULL,
+      cont_context_commit_records,
       context
   );
 }
diff --git a/src/gnunet_chat_lobby.c b/src/gnunet_chat_lobby.c
index 23c6d32..385fae8 100644
--- a/src/gnunet_chat_lobby.c
+++ b/src/gnunet_chat_lobby.c
@@ -41,6 +41,9 @@ lobby_create (struct GNUNET_CHAT_Handle *handle)
   lobby->op_create = NULL;
   lobby->op_delete = NULL;
 
+  lobby->query_open = NULL;
+  lobby->query_commit = NULL;
+
   lobby->expiration = GNUNET_TIME_absolute_get_forever_();
   lobby->callback = NULL;
   lobby->cls = NULL;
@@ -59,6 +62,12 @@ lobby_destroy (struct GNUNET_CHAT_Lobby *lobby)
   if (lobby->op_delete)
     GNUNET_IDENTITY_cancel(lobby->op_delete);
 
+  if (lobby->query_open)
+    GNUNET_NAMESTORE_cancel(lobby->query_open);
+
+  if (lobby->query_commit)
+    GNUNET_NAMESTORE_cancel(lobby->query_commit);
+
   if (lobby->uri)
     uri_destroy(lobby->uri);
 
diff --git a/src/gnunet_chat_lobby.h b/src/gnunet_chat_lobby.h
index e913134..6248a05 100644
--- a/src/gnunet_chat_lobby.h
+++ b/src/gnunet_chat_lobby.h
@@ -46,6 +46,9 @@ struct GNUNET_CHAT_Lobby
   struct GNUNET_IDENTITY_Operation *op_create;
   struct GNUNET_IDENTITY_Operation *op_delete;
 
+  struct GNUNET_NAMESTORE_QueueEntry *query_open;
+  struct GNUNET_NAMESTORE_QueueEntry *query_commit;
+
   struct GNUNET_TIME_Absolute expiration;
   GNUNET_CHAT_LobbyCallback callback;
   void *cls;
diff --git a/src/gnunet_chat_lobby_intern.c b/src/gnunet_chat_lobby_intern.c
index 31d1673..c66800c 100644
--- a/src/gnunet_chat_lobby_intern.c
+++ b/src/gnunet_chat_lobby_intern.c
@@ -25,21 +25,28 @@
 #include "gnunet_chat_context.h"
 
 void
-cont_lobby_write_records (void *cls,
-                          GNUNET_UNUSED int32_t success,
-                          const char *emsg)
+cont_lobby_commit_records (void *cls,
+                           GNUNET_UNUSED int32_t success,
+                           const char *emsg)
 {
   struct GNUNET_CHAT_Lobby *lobby = cls;
 
+  GNUNET_assert((lobby) &&
+                (lobby->handle) &&
+                (lobby->context));
+
+  lobby->query_commit = NULL;
+
   if (!emsg)
     goto call_cb;
 
-  handle_send_internal_message(
-      lobby->handle,
-      lobby->context,
-      GNUNET_CHAT_FLAG_WARNING,
-      emsg
-  );
+  if (lobby->handle)
+    handle_send_internal_message(
+        lobby->handle,
+        lobby->context,
+        GNUNET_CHAT_FLAG_WARNING,
+        emsg
+    );
 
   if (lobby->uri)
     uri_destroy(lobby->uri);
@@ -52,40 +59,41 @@ call_cb:
 }
 
 void
-cont_lobby_identity_delete (void *cls,
-                            const char *emsg)
+error_lobby_open_records (void *cls)
 {
   struct GNUNET_CHAT_Lobby *lobby = cls;
 
-  if (!emsg)
+  GNUNET_assert((lobby) &&
+                (lobby->handle) &&
+                (lobby->context));
+
+  lobby->query_open = NULL;
+
+  if (!(lobby->handle))
     return;
 
   handle_send_internal_message(
       lobby->handle,
       lobby->context,
       GNUNET_CHAT_FLAG_WARNING,
-      emsg
+      _("Namestore busy!")
   );
 }
 
 void
-cont_lobby_identity_create (void *cls,
+monitor_lobby_open_records (void *cls,
                             const struct GNUNET_IDENTITY_PrivateKey *zone,
-                            const char *emsg)
+                            const char *label,
+                            GNUNET_UNUSED unsigned int rd_count,
+                            GNUNET_UNUSED const struct GNUNET_GNSRECORD_Data *rd)
 {
   struct GNUNET_CHAT_Lobby *lobby = cls;
 
-  if (emsg)
-  {
-    handle_send_internal_message(
-        lobby->handle,
-        lobby->context,
-        GNUNET_CHAT_FLAG_WARNING,
-        emsg
-    );
+  GNUNET_assert((lobby) &&
+                (lobby->handle) &&
+                (lobby->context));
 
-    return;
-  }
+  lobby->query_open = NULL;
 
   const struct GNUNET_HashCode *key = GNUNET_MESSENGER_room_get_key(
       lobby->context->room
@@ -102,6 +110,73 @@ cont_lobby_identity_create (void *cls,
   data[0].expiration_time = lobby->expiration.abs_value_us;
   data[0].flags = GNUNET_GNSRECORD_RF_NONE;
 
+  lobby->query_commit = GNUNET_NAMESTORE_records_commit(
+      lobby->handle->namestore,
+      zone,
+      label,
+      1,
+      data,
+      cont_lobby_commit_records,
+      lobby
+  );
+}
+
+void
+cont_lobby_identity_delete (void *cls,
+                            const char *emsg)
+{
+  struct GNUNET_CHAT_Lobby *lobby = cls;
+
+  GNUNET_assert((lobby) &&
+                (lobby->handle) &&
+                (lobby->context));
+
+  lobby->op_delete = NULL;
+
+  if ((!emsg) || (!(lobby->handle)))
+    return;
+
+  handle_send_internal_message(
+      lobby->handle,
+      lobby->context,
+      GNUNET_CHAT_FLAG_WARNING,
+      emsg
+  );
+}
+
+void
+cont_lobby_identity_create (void *cls,
+                            const struct GNUNET_IDENTITY_PrivateKey *zone,
+                            const char *emsg)
+{
+  struct GNUNET_CHAT_Lobby *lobby = cls;
+
+  GNUNET_assert((lobby) &&
+                (lobby->handle) &&
+                (lobby->context));
+
+  const struct GNUNET_HashCode *key;
+
+  lobby->op_create = NULL;
+
+  if (!emsg)
+    goto continue_with_lobby;
+
+  if (lobby->handle)
+    handle_send_internal_message(
+        lobby->handle,
+        lobby->context,
+        GNUNET_CHAT_FLAG_WARNING,
+        emsg
+    );
+
+  return;
+
+continue_with_lobby:
+  key = GNUNET_MESSENGER_room_get_key(
+      lobby->context->room
+  );
+
   if (lobby->uri)
     uri_destroy(lobby->uri);
 
@@ -114,13 +189,13 @@ cont_lobby_identity_create (void *cls,
   lobby->uri = uri_create(&public_zone, label);
   GNUNET_free(label);
 
-  GNUNET_NAMESTORE_records_store(
+  lobby->query_open = GNUNET_NAMESTORE_records_open(
       lobby->handle->namestore,
       zone,
       lobby->uri->label,
-      1,
-      data,
-      cont_lobby_write_records,
+      error_lobby_open_records,
+      lobby,
+      monitor_lobby_open_records,
       lobby
   );