diff options
author | ng0 <ng0@n0.is> | 2019-08-18 11:19:40 +0000 |
---|---|---|
committer | ng0 <ng0@n0.is> | 2019-08-18 11:19:40 +0000 |
commit | c51869af5a5f1b76cce745afaf9c75ac9a502ee0 (patch) | |
tree | f30f17b312fa15ba79e8684649db9fb2e7c63c69 /src/microhttpd/mhd_send.c | |
parent | b8e368272a4416aaf078525a4043a6f87a98bfee (diff) | |
download | libmicrohttpd-c51869af5a5f1b76cce745afaf9c75ac9a502ee0.tar.gz libmicrohttpd-c51869af5a5f1b76cce745afaf9c75ac9a502ee0.zip |
mhd_send.c: for now, let EINVAL and EBADF fail hard.
Diffstat (limited to 'src/microhttpd/mhd_send.c')
-rw-r--r-- | src/microhttpd/mhd_send.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/microhttpd/mhd_send.c b/src/microhttpd/mhd_send.c index b3fb25da..862bd6e9 100644 --- a/src/microhttpd/mhd_send.c +++ b/src/microhttpd/mhd_send.c | |||
@@ -76,6 +76,7 @@ pre_cork_setsockopt (struct MHD_Connection *connection, | |||
76 | break; | 76 | break; |
77 | case EBADF: | 77 | case EBADF: |
78 | /* FIXME: should we die hard here? */ | 78 | /* FIXME: should we die hard here? */ |
79 | return MHD_ERR_BADF_; /* Fail hard */ | ||
79 | break; | 80 | break; |
80 | case EINVAL: | 81 | case EINVAL: |
81 | /* FIXME: optlen invalid, should at least log this, maybe die */ | 82 | /* FIXME: optlen invalid, should at least log this, maybe die */ |
@@ -84,6 +85,7 @@ pre_cork_setsockopt (struct MHD_Connection *connection, | |||
84 | _("optlen invalid: %s\n"), | 85 | _("optlen invalid: %s\n"), |
85 | MHD_socket_last_strerr_()); | 86 | MHD_socket_last_strerr_()); |
86 | #endif | 87 | #endif |
88 | return MHD_ERR_INVAL_; /* Fail hard */ | ||
87 | break; | 89 | break; |
88 | case EFAULT: | 90 | case EFAULT: |
89 | /* wopsie, should at leats log this, FIXME: maybe die */ | 91 | /* wopsie, should at leats log this, FIXME: maybe die */ |
@@ -162,6 +164,7 @@ post_cork_setsockopt (struct MHD_Connection *connection, | |||
162 | break; | 164 | break; |
163 | case EBADF: | 165 | case EBADF: |
164 | /* FIXME: should we die hard here? */ | 166 | /* FIXME: should we die hard here? */ |
167 | return MHD_ERR_BADF_; /* Fail hard */ | ||
165 | break; | 168 | break; |
166 | case EINVAL: | 169 | case EINVAL: |
167 | /* FIXME: optlen invalid, should at least log this, maybe die */ | 170 | /* FIXME: optlen invalid, should at least log this, maybe die */ |
@@ -170,6 +173,7 @@ post_cork_setsockopt (struct MHD_Connection *connection, | |||
170 | _("optlen invalid: %s\n"), | 173 | _("optlen invalid: %s\n"), |
171 | MHD_socket_last_strerr_()); | 174 | MHD_socket_last_strerr_()); |
172 | #endif | 175 | #endif |
176 | return MHD_ERR_INVAL_; /* Fail hard */ | ||
173 | break; | 177 | break; |
174 | case EFAULT: | 178 | case EFAULT: |
175 | /* wopsie, should at leats log this, FIXME: maybe die */ | 179 | /* wopsie, should at leats log this, FIXME: maybe die */ |