From 2027b939dd510f5d68fac853394a7b7d3fec191b Mon Sep 17 00:00:00 2001 From: Christian Grothoff Date: Wed, 5 Dec 2012 18:28:17 +0000 Subject: Matthew Mundell wrote: Hi We've been having some mysterious parameter loss of POST parameters in OpenVAS's GSA. This only happens with IE8 and Chrome. We saw this with libmicrohttpd 0.9.19 and 0.9.20. The cause looks to be an error in libmicrohttpd. Patch to 0.9.20 to resolve below. In post_process_multipart in postprocessor.c the PP_Init state calls find_boundary to find the first boundary. If there is junk before the first boundary it just reads over the junk. However, it is also reading over the actual boundary when there was too little data to determine whether the next character is the start of the boundary. In the error case Chrome seems to sends the POST request in multiple writes. The first chunk includes a single "-" from the first boundary at end of the headers. Thus libmicrohttpd has a partial boundary to deal with. I guess Chrome intends to send just the headers but gets the count wrong due to sending the initial P of the POST on its own (all the browsers do that for some reason). Firefox on the other hand sends the headers and the body in a single write, so it always works. Thanks, and thanks for libmicrohttpd! Matt --- AUTHORS | 1 + 1 file changed, 1 insertion(+) (limited to 'AUTHORS') diff --git a/AUTHORS b/AUTHORS index 9c7fe895..2041e941 100644 --- a/AUTHORS +++ b/AUTHORS @@ -39,6 +39,7 @@ Sven Geggus Steve Wolf Brecht Sanders Jan Janak +Matthew Mundell Documentation contributions also came from: Marco Maggi -- cgit v1.2.3