fix service/protocol confusion in TLSA dialog restoration

1 files changed, 5 insertions, 6 deletions

diff --git a/src/namestore/plugin_gtk_namestore_tlsa.c b/src/namestore/plugin_gtk_namestore_tlsa.c
index 1fc970e4..18ac43ac 100644
--- a/src/namestore/plugin_gtk_namestore_tlsa.c
+++ b/src/namestore/plugin_gtk_namestore_tlsa.c
@@ -134,9 +134,8 @@ get_selected_radio_value (GtkBuilder *builder,
                           const char *const*button_names)
 {
   GtkToggleButton *b;
-  int i;
 
-  for (i=0; NULL != button_names[i]; i++)
+  for (int i=0; NULL != button_names[i]; i++)
   {
     b = GTK_TOGGLE_BUTTON (gtk_builder_get_object (builder,
                                                    button_names[i]));
@@ -202,7 +201,7 @@ tlsa_load (void *cls,
   GtkTreeIter iter;
   GtkTreeModel *tm;
   unsigned int service;
-  guint service_at_iter;
+  guint protocol_at_iter;
   unsigned int record_type;
   unsigned int usage;
   unsigned int selector;
@@ -234,7 +233,7 @@ tlsa_load (void *cls,
   gtk_spin_button_set_value
     (GTK_SPIN_BUTTON (gtk_builder_get_object (builder,
                                               "edit_dialog_port_spinbutton")),
-     protocol);
+     service);
   cb = GTK_COMBO_BOX (gtk_builder_get_object (builder,
                                               "edit_dialog_protocol_combobox"));
   tm = GTK_TREE_MODEL (gtk_builder_get_object (builder,
@@ -246,9 +245,9 @@ tlsa_load (void *cls,
     {
       gtk_tree_model_get (tm,
                           &iter,
-                          1, &service_at_iter,
+                          1, &protocol_at_iter,
                           -1);
-      if (service_at_iter == service)
+      if (protocol_at_iter == protocol)
       {
         gtk_combo_box_set_active_iter (cb,
                                        &iter);