aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Grothoff <christian@grothoff.org>2012-02-01 17:07:27 +0000
committerChristian Grothoff <christian@grothoff.org>2012-02-01 17:07:27 +0000
commit3645d81a7252ceff6748fbe2f03be06e2e266f46 (patch)
tree89d8f424e067675f65d0650998075032f737cec4
parentd7432b30dd45a0178ef6401a09ffc39300d26393 (diff)
downloadgnunet-gtk-3645d81a7252ceff6748fbe2f03be06e2e266f46.tar.gz
gnunet-gtk-3645d81a7252ceff6748fbe2f03be06e2e266f46.zip
-characterizing FIXMEs
-rw-r--r--src/fs/gnunet-fs-gtk-event_handler.c30
1 files changed, 15 insertions, 15 deletions
diff --git a/src/fs/gnunet-fs-gtk-event_handler.c b/src/fs/gnunet-fs-gtk-event_handler.c
index 91c80eec..ed5f56bf 100644
--- a/src/fs/gnunet-fs-gtk-event_handler.c
+++ b/src/fs/gnunet-fs-gtk-event_handler.c
@@ -143,13 +143,13 @@ static struct PublishTab *publish_tab;
143 143
144/** 144/**
145 * Row reference for the current search context menu. 145 * Row reference for the current search context menu.
146 * FIXME: de-globalize? 146 * FIXME-UNCLEAN: de-globalize?
147 */ 147 */
148static GtkTreeRowReference *current_context_row_reference; 148static GtkTreeRowReference *current_context_row_reference;
149 149
150/** 150/**
151 * Search tab used for the current search context menu. 151 * Search tab used for the current search context menu.
152 * FIXME: de-globalize? 152 * FIXME-UNCLEAN: de-globalize?
153 */ 153 */
154static struct SearchTab *current_context_search_tab; 154static struct SearchTab *current_context_search_tab;
155 155
@@ -171,7 +171,7 @@ static struct SearchTab *current_context_search_tab;
171static char * 171static char *
172get_default_download_directory (char *buffer, size_t size) 172get_default_download_directory (char *buffer, size_t size)
173{ 173{
174 /* FIXME: implement... */ 174 /* FIXME-FEATURE: implement... */
175 return NULL; 175 return NULL;
176} 176}
177 177
@@ -212,7 +212,7 @@ get_suggested_filename_anonymity (GtkTreeModel *tm,
212 const char *basename; 212 const char *basename;
213 char *dot; 213 char *dot;
214 214
215 /* FIXME: this function is likely responsible for not always 215 /* FIXME-BUG-MAYBE: this function is likely responsible for not always
216 suggesting the best filename... To be investigated some more... */ 216 suggesting the best filename... To be investigated some more... */
217 gtk_tree_model_get (tm, iter, 0, &meta, 217 gtk_tree_model_get (tm, iter, 0, &meta,
218 15, &local_filename, 218 15, &local_filename,
@@ -609,7 +609,7 @@ search_list_popup (GtkTreeModel *tm,
609 sr, 609 sr,
610 sr->download); 610 sr->download);
611 611
612 /* FIXME: move these to some menu context struct 612 /* FIXME-UNCLEAN: move these to some menu context struct
613 (de-globalize) */ 613 (de-globalize) */
614 current_context_search_tab = tab; 614 current_context_search_tab = tab;
615 if (current_context_row_reference != NULL) 615 if (current_context_row_reference != NULL)
@@ -1033,7 +1033,7 @@ clear_downloads (GtkButton * button, gpointer user_data)
1033 tm = GTK_TREE_MODEL (tab->ts); 1033 tm = GTK_TREE_MODEL (tab->ts);
1034 if (TRUE != gtk_tree_model_get_iter_first (tm, &iter)) 1034 if (TRUE != gtk_tree_model_get_iter_first (tm, &iter))
1035 return; 1035 return;
1036 /* FIXME: this is a tree, what about cleaning up 1036 /* FIXME-BUG: this is a tree, what about cleaning up
1037 of the children? */ 1037 of the children? */
1038 do 1038 do
1039 { 1039 {
@@ -1257,7 +1257,7 @@ GNUNET_GTK_add_search_result (struct SearchTab *tab,
1257 /* opened directory file */ 1257 /* opened directory file */
1258 fsize = 0; 1258 fsize = 0;
1259 status_colour = "gray"; 1259 status_colour = "gray";
1260 mime = NULL; /* FIXME: should we set mime to directory? */ 1260 mime = NULL; /* FIXME-FEATURE-MAYBE: should we set mime to directory? */
1261 uris = GNUNET_strdup (_("no URI")); 1261 uris = GNUNET_strdup (_("no URI"));
1262 } 1262 }
1263 else 1263 else
@@ -1271,8 +1271,8 @@ GNUNET_GTK_add_search_result (struct SearchTab *tab,
1271 } 1271 }
1272 else 1272 else
1273 { 1273 {
1274 /* FIXME: create mime type for namespaces? */ 1274 /* FIXME-FEATURE-MAYBE: create mime type for namespaces? */
1275 /* FIXME: can we encounter ksk URIs here too? */ 1275 /* FIXME-BUG-MAYBE: can we encounter ksk URIs here too? */
1276 fsize = 0; 1276 fsize = 0;
1277 mime = GNUNET_strdup ("GNUnet namespace"); 1277 mime = GNUNET_strdup ("GNUnet namespace");
1278 status_colour = "lightgreen"; 1278 status_colour = "lightgreen";
@@ -1448,7 +1448,7 @@ setup_search_tab (struct GNUNET_FS_SearchContext *sc,
1448 GTK_LABEL (gtk_builder_get_object 1448 GTK_LABEL (gtk_builder_get_object
1449 (tab->builder, "_search_result_label_window_label")); 1449 (tab->builder, "_search_result_label_window_label"));
1450 1450
1451 /* FIXME: connect these signals using glade!!! */ 1451 /* FIXME-UNCLEAN: connect these signals using glade!!! */
1452 tab->close_button = 1452 tab->close_button =
1453 GTK_WIDGET (gtk_builder_get_object 1453 GTK_WIDGET (gtk_builder_get_object
1454 (tab->builder, "_search_result_label_close_button")); 1454 (tab->builder, "_search_result_label_close_button"));
@@ -1472,7 +1472,7 @@ setup_search_tab (struct GNUNET_FS_SearchContext *sc,
1472 /* patch text */ 1472 /* patch text */
1473 update_search_label (tab); 1473 update_search_label (tab);
1474 1474
1475 /* add signal handlers; FIXME: again, connect these with glade... */ 1475 /* add signal handlers; FIXME-UNCLEAN: again, connect these with glade... */
1476 tv = GTK_TREE_VIEW (gtk_builder_get_object 1476 tv = GTK_TREE_VIEW (gtk_builder_get_object
1477 (tab->builder, "_search_result_frame")); 1477 (tab->builder, "_search_result_frame"));
1478 g_signal_connect (G_OBJECT (tv), "row-activated", 1478 g_signal_connect (G_OBJECT (tv), "row-activated",
@@ -1511,7 +1511,7 @@ setup_search_tab (struct GNUNET_FS_SearchContext *sc,
1511 * find it when we get this kind of 'inner' search results (so that we 1511 * find it when we get this kind of 'inner' search results (so that we
1512 * can then place them in the tree view in the right spot). 1512 * can then place them in the tree view in the right spot).
1513 * 1513 *
1514 * FIXME: don't we need a bit more information then? Like exactly where 1514 * FIXME-BUG-MAYBE: don't we need a bit more information then? Like exactly where
1515 * this 'right spot' is? Not sure how just having 'sc' helps there, 1515 * this 'right spot' is? Not sure how just having 'sc' helps there,
1516 * as it is not a search result (!) to hang this up on! This might 1516 * as it is not a search result (!) to hang this up on! This might
1517 * essentially boil down to an issue with the FS API, not sure... 1517 * essentially boil down to an issue with the FS API, not sure...
@@ -1723,7 +1723,7 @@ add_directory_entry (void *cls, const char *filename,
1723 if (NULL == uri) 1723 if (NULL == uri)
1724 { 1724 {
1725 /* directory meta data itself */ 1725 /* directory meta data itself */
1726 /* FIXME: consider merging it with the meta data from 1726 /* FIXME-FEATURE-MAYBE: consider merging it with the meta data from
1727 the original search result... */ 1727 the original search result... */
1728 return; 1728 return;
1729 } 1729 }
@@ -1788,7 +1788,7 @@ mark_download_progress (struct DownloadEntry *de, uint64_t size,
1788 return; 1788 return;
1789 } 1789 }
1790 gtk_tree_path_free (path); 1790 gtk_tree_path_free (path);
1791 /* FIXME: update availability-score here as well! */ 1791 /* FIXME-FEATURE: update availability-score here as well! */
1792 gtk_tree_store_set (de->ts, &iter, 1792 gtk_tree_store_set (de->ts, &iter,
1793 4, (guint) ((size > 1793 4, (guint) ((size >
1794 0) ? (100 * completed / 1794 0) ? (100 * completed /
@@ -2376,7 +2376,7 @@ setup_publish (struct GNUNET_FS_PublishContext *pc, const char *fn,
2376 gtk_container_remove (GTK_CONTAINER (df), tab_label); 2376 gtk_container_remove (GTK_CONTAINER (df), tab_label);
2377 gtk_widget_destroy (GTK_WIDGET (df)); 2377 gtk_widget_destroy (GTK_WIDGET (df));
2378 2378
2379 /* FIXME: connect these signals using GLADE!!! */ 2379 /* FIXME-UNCLEAN: connect these signals using GLADE!!! */
2380 /* get refs to widgets */ 2380 /* get refs to widgets */
2381 close_button = 2381 close_button =
2382 GTK_WIDGET (gtk_builder_get_object 2382 GTK_WIDGET (gtk_builder_get_object