-sync

1 files changed, 22 insertions, 5 deletions

diff --git a/src/fs/gnunet-fs-gtk-edit_publish_dialog.c b/src/fs/gnunet-fs-gtk-edit_publish_dialog.c
index 6f8f907a..bf941106 100644
--- a/src/fs/gnunet-fs-gtk-edit_publish_dialog.c
+++ b/src/fs/gnunet-fs-gtk-edit_publish_dialog.c
@@ -285,8 +285,17 @@ metadata_selection_changed_cb (GtkTreeSelection *ts,
 }
 
 
+/**
+ * The user changed the type of a meta-data item in the meta data
+ * tree view.  Update the type and text in the list store accordingly.
+ *
+ * @param renderer widget where the change happened
+ * @param path which item was changed
+ * @param new_text new value for the item
+ * @param user_data the 'struct EditPublicationDialogContext'
+ */
 void 
-GNUNET_GTK_edit_publication_metadata_tree_view_type_renderer_edited_cb (GtkCellRendererText * renderer, 
+GNUNET_GTK_edit_publication_metadata_tree_view_type_renderer_edited_cb (GtkCellRendererText *renderer, 
                                                                         gchar * path, 
                                                                         gchar * new_text,
                                                                         gpointer user_data)
@@ -297,12 +306,19 @@ GNUNET_GTK_edit_publication_metadata_tree_view_type_renderer_edited_cb (GtkCellR
   gint type_id;
   gchar *description = NULL;
 
-  if (!gtk_tree_model_get_iter_from_string
-      (GTK_TREE_MODEL (ctx->meta_liststore), &iter, path))
+  if (! gtk_tree_model_get_iter_from_string (GTK_TREE_MODEL (ctx->meta_liststore), 
+                                             &iter, 
+                                             path))
+  {
+    GNUNET_break (0);
     return;
-
-  if (!ctx->meta_combo_selected_iter)
+  }
+  if (NULL == ctx->meta_combo_selected_iter)
+  {
+    GNUNET_break (0);
     return;
+  }
+  /* FIXME from here... */
   g_object_get (GTK_CELL_RENDERER_COMBO (gtk_builder_get_object
                                          (ctx->builder,
                                           "GNUNET_GTK_edit_publication_metadata_tree_view_type_renderer")),
@@ -326,6 +342,7 @@ GNUNET_GTK_edit_publication_metadata_tree_view_type_renderer_changed_cb (GtkCell
                                                                          gpointer user_data)
 {
   struct EditPublicationDialogContext *ctx = user_data;
+
   if (ctx->meta_combo_selected_iter)
     g_free (ctx->meta_combo_selected_iter);
   ctx->meta_combo_selected_iter = g_new0 (GtkTreeIter, 1);