diff options
author | Martin Schanzenbach <schanzen@gnunet.org> | 2022-10-01 10:42:43 +0900 |
---|---|---|
committer | Martin Schanzenbach <schanzen@gnunet.org> | 2022-10-01 10:42:43 +0900 |
commit | 6254d688ac407ec60bea0e317a15978eac60b16f (patch) | |
tree | f3ffc975211baaca72d2079124b559cba69c6668 | |
parent | dcc8fea2f83813e81ef8cead9656853c9ac4343e (diff) | |
download | gnunet-6254d688ac407ec60bea0e317a15978eac60b16f.tar.gz gnunet-6254d688ac407ec60bea0e317a15978eac60b16f.zip |
- coverity fixes
-rw-r--r-- | src/namestore/gnunet-service-namestore.c | 8 | ||||
-rw-r--r-- | src/rest/gnunet-rest-server.c | 2 |
2 files changed, 5 insertions, 5 deletions
diff --git a/src/namestore/gnunet-service-namestore.c b/src/namestore/gnunet-service-namestore.c index 36f6d337c..b860d7a3c 100644 --- a/src/namestore/gnunet-service-namestore.c +++ b/src/namestore/gnunet-service-namestore.c | |||
@@ -806,7 +806,7 @@ send_lookup_response_with_filter (struct NamestoreClient *nc, | |||
806 | rd_ser_len = GNUNET_GNSRECORD_records_get_size (res_count, res); | 806 | rd_ser_len = GNUNET_GNSRECORD_records_get_size (res_count, res); |
807 | if (rd_ser_len < 0) | 807 | if (rd_ser_len < 0) |
808 | { | 808 | { |
809 | if (rd != res) | 809 | if (rd_nf != res) |
810 | GNUNET_free (res); | 810 | GNUNET_free (res); |
811 | GNUNET_break (0); | 811 | GNUNET_break (0); |
812 | GNUNET_SERVICE_client_drop (nc->client); | 812 | GNUNET_SERVICE_client_drop (nc->client); |
@@ -814,7 +814,7 @@ send_lookup_response_with_filter (struct NamestoreClient *nc, | |||
814 | } | 814 | } |
815 | if (((size_t) rd_ser_len) >= UINT16_MAX - name_len - sizeof(*zir_msg)) | 815 | if (((size_t) rd_ser_len) >= UINT16_MAX - name_len - sizeof(*zir_msg)) |
816 | { | 816 | { |
817 | if (rd != res) | 817 | if (rd_nf != res) |
818 | GNUNET_free (res); | 818 | GNUNET_free (res); |
819 | GNUNET_break (0); | 819 | GNUNET_break (0); |
820 | GNUNET_SERVICE_client_drop (nc->client); | 820 | GNUNET_SERVICE_client_drop (nc->client); |
@@ -1827,7 +1827,7 @@ handle_tx_control (void *cls, const struct TxControlMessage *tx_msg) | |||
1827 | struct TxControlResultMessage *txr_msg; | 1827 | struct TxControlResultMessage *txr_msg; |
1828 | struct GNUNET_MQ_Envelope *env; | 1828 | struct GNUNET_MQ_Envelope *env; |
1829 | enum GNUNET_GenericReturnValue ret; | 1829 | enum GNUNET_GenericReturnValue ret; |
1830 | char *emsg; | 1830 | char *emsg = NULL; |
1831 | char *err_tmp; | 1831 | char *err_tmp; |
1832 | size_t err_len; | 1832 | size_t err_len; |
1833 | 1833 | ||
@@ -1852,7 +1852,7 @@ handle_tx_control (void *cls, const struct TxControlMessage *tx_msg) | |||
1852 | } | 1852 | } |
1853 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, | 1853 | GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, |
1854 | "TX status is %u\n", ret); | 1854 | "TX status is %u\n", ret); |
1855 | err_len = (GNUNET_YES == ret) ? 0 : strlen (emsg) + 1; | 1855 | err_len = (NULL == emsg) ? 0 : strlen (emsg) + 1; |
1856 | env = | 1856 | env = |
1857 | GNUNET_MQ_msg_extra (txr_msg, | 1857 | GNUNET_MQ_msg_extra (txr_msg, |
1858 | err_len, | 1858 | err_len, |
diff --git a/src/rest/gnunet-rest-server.c b/src/rest/gnunet-rest-server.c index 9984478ce..0aba52a11 100644 --- a/src/rest/gnunet-rest-server.c +++ b/src/rest/gnunet-rest-server.c | |||
@@ -1201,7 +1201,7 @@ run (void *cls, | |||
1201 | memset (basic_auth_secret_tmp, 0, 16); | 1201 | memset (basic_auth_secret_tmp, 0, 16); |
1202 | if (GNUNET_SYSERR == GNUNET_DISK_fn_read (basic_auth_file, | 1202 | if (GNUNET_SYSERR == GNUNET_DISK_fn_read (basic_auth_file, |
1203 | basic_auth_secret_tmp, | 1203 | basic_auth_secret_tmp, |
1204 | sizeof (basic_auth_secret_tmp))) | 1204 | sizeof (basic_auth_secret_tmp) - 1)) |
1205 | { | 1205 | { |
1206 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, | 1206 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
1207 | "Unable to read basic auth secret file.\n"); | 1207 | "Unable to read basic auth secret file.\n"); |