aboutsummaryrefslogtreecommitdiff
path: root/AUTHORS
Commit message (Collapse)AuthorAge
* -addChristian Grothoff2015-08-31
|
* Remove unused libmagic and add as Author.Bruno Cabral2013-12-20
|
* -adding Polish translationChristian Grothoff2012-12-02
|
* more pluginsChristian Grothoff2012-08-18
|
* do not use FORMAT_XML, version bumpChristian Grothoff2012-08-16
|
* LRN is refactoring the plugin API, and hell breaks looseChristian Grothoff2012-03-27
|
* emailChristian Grothoff2011-11-29
|
* Changes mp3 extractor to discard frames with frame_size <= 0.Christian Grothoff2011-11-28
| | | | | | | | | | | | | | | | Obviously, this is quite hacky, but: A) Files with 0 bitrate are rare. B) At least it won't trigger as easily on random binary data Also, makes mp3 extractor check for at least 2 valid frames in a row. That is, if frame size is not 0, then the next frame header after the first one we found must also be valid, otherwise this is not considered to be an mp3 file. This is the best i can do with such a short and simple patch, further improvements are only possible with something more complex, i think.
* first draft of MKV pluginChristian Grothoff2011-11-19
|
* new API for GNU libextractor, converted first 3 plugins as wellChristian Grothoff2009-12-13
|
* update e-mailHeikki Lindholm2009-09-24
|
* Added s3m support.Toni Ruottu2008-08-12
|
* Added xm support.Toni Ruottu2008-08-12
|
* Added it support.Toni Ruottu2008-08-10
|
* add AppleSingle/AppleDouble pluginHeikki Lindholm2008-02-13
|
* cleanupChristian Grothoff2008-02-12
|
* flac supportChristian Grothoff2007-12-27
|
* add Flash Video (.flv) extractor pluginHeikki Lindholm2007-12-26
|
* heikkiChristian Grothoff2007-12-25
|
* fixChristian Grothoff2007-04-29
|
* Added nsfe support.Toni Ruottu2007-01-06
|
* whitespaceChristian Grothoff2006-12-29
|
* OS X improvements from Heikki L.Christian Grothoff2006-12-03
|
* Added sid support.Toni Ruottu2006-11-20
|
* Added nsf support.Toni Ruottu2006-11-10
|
* thumbnail extractor based on QtNils Durner2006-06-24
|
* fixesNils Durner2006-06-24
|
* change width of module columnNils Durner2006-06-24
|
* contribsChristian Grothoff2006-04-26
|
* syncChristian Grothoff2006-03-11
|
* [bug-libextractor] [patch] fix textproc/libextractor double free() bugChristian Grothoff2005-11-09
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | From: Vasil Dimov <vd@datamax.bg> To: FreeBSD-gnats-submit@freebsd.org CC: bug-libextractor@gnu.org, kevlo@freebsd.org Date: Today 03:48:23 >Submitter-Id: current-users >Originator: Vasil Dimov >Organization: DataMax >Confidential: no >Synopsis: [patch] textproc/libextractor fix double free() bug >Severity: serious >Priority: high >Category: ports >Class: sw-bug >Release: FreeBSD 6.0-STABLE amd64 >Environment: System: FreeBSD qlovarnika.bg.datamax 6.0-STABLE FreeBSD 6.0-STABLE #0: Tue Nov 8 09:24:59 EET 2005 root@qlovarnika.bg.datamax:/usr/obj/usr/src/sys/QLOVARNIKA amd64 >Description: Problem: `make check' for textproc/libextractor fails: ... make check-TESTS lt-trivialtest in free(): error: chunk is already free Abort trap (core dumped) FAIL: trivialtest PASS: keywordlisttest lt-plugintest in free(): error: chunk is already free Abort trap (core dumped) FAIL: plugintest lt-multiload in free(): error: chunk is already free Abort trap (core dumped) FAIL: multiload ========================================= 3 of 4 tests failed Please report to bug-libextractor@gnu.org ========================================= ... (NOTE: options AJ are set via malloc.conf(3)) Lets look closer to one of the failing progs: $ cd libextractor-0.5.6a/src/test $ ./.libs/lt-trivialtest lt-trivialtest in free(): error: chunk is already free Abort trap: 6 (core dumped) $ gdb is useless here, because it segfaults itself, so I used printfs to locate the problem. the following is self-explanatory trace of the program, created by inserting printfs in the appropriate places: (the prog is being run via electricfence to make it crash as soon as possible) $ ./.libs/lt-trivialtest extractor.c:216 le_ltdl_init begin extractor.c:253 le_ltdl_init end trivialtest.c:24 main begin extractor.c:216 le_ltdl_init begin extractor.c:235 le_ltdl_init old_dlsearchpath=0x801122fcc extractor.c:237 le_ltdl_init old_dlsearchpath=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:253 le_ltdl_init end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x801122fcc ltdl.c:4060 lt_dlsetsearchpath search_path=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:274 le_ltdl_fini end trivialtest.c:28 main between extractor.c:216 le_ltdl_init begin extractor.c:235 le_ltdl_init old_dlsearchpath=0x802cd3fcc extractor.c:237 le_ltdl_init old_dlsearchpath=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:253 le_ltdl_init end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x802cd3fcc ltdl.c:4060 lt_dlsetsearchpath search_path=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:274 le_ltdl_fini end trivialtest.c:31 main end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x802cd3fcc Bus error: 10 (core dumped) $ You see, the destructor le_ltdl_fini() is being called "unexpectedly" when the program exits, but search_path=0x802cd3fcc has already been free()d by the previous invocation. Fix: it seems quite trivial, we just need to old_dlsearchpath = NULL after free()ing it - lt_dlsetsearchpath() is checking if called with NULL pointer and we are calling free() only if old_dlsearchpath is non-NULL. With the included patch, output of trivialtest looks like: $ ./.libs/lt-trivialtest extractor.c:216 le_ltdl_init begin extractor.c:253 le_ltdl_init end trivialtest.c:24 main begin extractor.c:216 le_ltdl_init begin extractor.c:235 le_ltdl_init old_dlsearchpath=0x801122fcc extractor.c:237 le_ltdl_init old_dlsearchpath=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:253 le_ltdl_init end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x801122fcc ltdl.c:4060 lt_dlsetsearchpath search_path=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:274 le_ltdl_fini end trivialtest.c:28 main between extractor.c:216 le_ltdl_init begin extractor.c:235 le_ltdl_init old_dlsearchpath=0x802cd3fcc extractor.c:237 le_ltdl_init old_dlsearchpath=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:253 le_ltdl_init end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x802cd3fcc ltdl.c:4060 lt_dlsetsearchpath search_path=/usr/lib/libextractor:/usr/local/lib/libextractor extractor.c:274 le_ltdl_fini end trivialtest.c:31 main end extractor.c:258 le_ltdl_fini begin ltdl.c:4058 lt_dlsetsearchpath search_path=0x0 ltdl.c:4060 lt_dlsetsearchpath search_path=(null) extractor.c:274 le_ltdl_fini end $ And of-course... $ make check ... ================== All 4 tests passed ================== $ >How-To-Repeat: export MALLOC_OPTIONS=AJ cd /usr/ports/textproc/libextractor make check >Fix: --- libextractor_free.diff begins here --- diff -urN --exclude=CVS libextractor.orig/Makefile libextractor/Makefile --- libextractor.orig/Makefile Sun Nov 6 02:20:45 2005 +++ libextractor/Makefile Wed Nov 9 12:55:44 2005 @@ -7,7 +7,7 @@ PORTNAME= libextractor PORTVERSION= 0.5.6a -PORTREVISION= 1 +PORTREVISION= 2 CATEGORIES= textproc MASTER_SITES= http://gnunet.org/libextractor/download/ \ ${MASTER_SITE_GNU} diff -urN --exclude=CVS libextractor.orig/files/patch-src::main::extractor.c libextractor/files/patch-src::main::extractor.c --- libextractor.orig/files/patch-src::main::extractor.c Thu Jan 1 02:00:00 1970 +++ libextractor/files/patch-src::main::extractor.c Wed Nov 9 12:02:48 2005 @@ -0,0 +1,14 @@ +--- src/main/extractor.c.orig Wed Nov 9 11:57:54 2005 ++++ src/main/extractor.c Wed Nov 9 11:58:31 2005 +@@ -246,8 +246,10 @@ + + void __attribute__ ((destructor)) le_ltdl_fini(void) { + lt_dlsetsearchpath(old_dlsearchpath); +- if (old_dlsearchpath != NULL) ++ if (old_dlsearchpath != NULL) { + free(old_dlsearchpath); ++ old_dlsearchpath = NULL; ++ } + #ifdef MINGW + ShutdownWinEnv(); + #endif --- libextractor_free.diff ends here --- _______________________________________________ bug-libextractor mailing list bug-libextractor@gnu.org http://lists.gnu.org/mailman/listinfo/bug-libextractor
* syncChristian Grothoff2005-09-23
|
* language detection code from libkat 0.6.3Christian Grothoff2005-09-14
|
* fixChristian Grothoff2005-08-13
|
* updateChristian Grothoff2005-07-04
|
* Huggel's patch -- verbatim, still needs workChristian Grothoff2005-07-03
|
* updateChristian Grothoff2005-05-31
|
* upChristian Grothoff2005-05-06
|
* new translationChristian Grothoff2005-04-05
|
* libextractor 0.4.2 releaseChristian Grothoff2005-02-24
|
* upNils Durner2005-02-12
|
* Importing libextractor.Christian Grothoff2005-01-21
generated by cgit v1.2.3 (git 2.39.1) at 2024-05-26 06:32:56 +0000