taler-typescript-core

commit 2f2280e73500305a74bb52245c8f4c948ba395e8
parent aadf3b24db2ff7fb9a502a027721b4d7a4919eb6
Author: Sebastian <sebasjm@taler-systems.com>
Date:   Tue, 21 Jul 2026 15:19:18 -0300

memo should not be used conditionally

Diffstat:
M
packages/taler-auditor-webui/src/paths/default/index.tsx
 | 
5
+++--
M
packages/taler-auditor-webui/src/paths/finance/ListPage.tsx
 | 
7
++-----

2 files changed, 5 insertions(+), 7 deletions(-)
diff --git a/packages/taler-auditor-webui/src/paths/default/index.tsx b/packages/taler-auditor-webui/src/paths/default/index.tsx
@@ -56,6 +56,9 @@ export default function DefaultList({ onLoadError, onNotFound }: Props): VNode {
   const [notif, setNotif] = useState<Notification | undefined>(undefined);
   const { i18n } = useTranslationContext();
 
+  let data = result.loading || !result.ok ? undefined : result.data;
+  const value = useMemo(() => ({ data }), [data]);
+  
   if (result.loading) return <Loading />;
   if (!result.ok) {
     if (
@@ -66,8 +69,6 @@ export default function DefaultList({ onLoadError, onNotFound }: Props): VNode {
     return onLoadError(result);
   }
 
-  let data = result.data;
-  const value = useMemo(() => ({ data }), [data]);
 
   function onReturn(): void {
     route(Paths.detail_view);
diff --git a/packages/taler-auditor-webui/src/paths/finance/ListPage.tsx b/packages/taler-auditor-webui/src/paths/finance/ListPage.tsx
@@ -50,7 +50,6 @@ export function ListPage(data: any): VNode {
     "Reserves history fee revenue",
     "Reserves open fee revenue",
   ];
-  let i = 0;
 
   return (
     <Fragment>
@@ -212,8 +211,7 @@ export function ListPage(data: any): VNode {
                         .slice(1, key.length);
 
                     if (coinBalances.includes(balanceName)) {
-                      let value = balances[i].balance_value.replace(":", " ");
-                      i = i + 1;
+                      let value = x.balance_value.replace(":", " ");
                       return (
                         <tr class="is-link">
                           <td>{balanceName}</td>
@@ -249,8 +247,7 @@ export function ListPage(data: any): VNode {
                         .slice(1, key.length);
 
                     if (reserveBalances.includes(balanceName)) {
-                      let value = balances[i].balance_value.replace(":", " ");
-                      i = i + 1;
+                      let value = x.balance_value.replace(":", " ");
                       return (
                         <tr class="is-link">
                           <td>{balanceName}</td>