more libeufin-bank error codes

2 files changed, 32 insertions, 14 deletions

diff --git a/gnu-taler-error-codes/registry.rec b/gnu-taler-error-codes/registry.rec
index f37d2d3..b63d803 100644
--- a/gnu-taler-error-codes/registry.rec
+++ b/gnu-taler-error-codes/registry.rec
@@ -2306,6 +2306,16 @@ Name: BANK_ADMIN_CREDITOR
 Description: The client tried to create a transaction that credit the admin account.
 HttpStatus: 409
 
+Value: 5143
+Name: BANK_CHALLENGE_NOT_FOUND
+Description: The referenced challenge was not found.
+HttpStatus: 404
+
+Value: 5144
+Name: BANK_TAN_CHALLENGE_EXPIRED
+Description: The referenced challenge has expired.
+HttpStatus: 409
+
 # 6000 - 6999: Reserved for sync
 # 6000 - 6099: Reserved for SYNC_GENERIC
 
diff --git a/gnu-taler-error-codes/taler_error_codes.rst b/gnu-taler-error-codes/taler_error_codes.rst
index fde39b6..b81138f 100644
--- a/gnu-taler-error-codes/taler_error_codes.rst
+++ b/gnu-taler-error-codes/taler_error_codes.rst
@@ -1327,43 +1327,43 @@ Entries
    * - MERCHANT_PRIVATE_POST_ORDERS_INSTANCE_CONFIGURATION_LACKS_WIRE
      - 2500
      - 404 (NOT_FOUND)
-     - The backend lacks a wire transfer method configuration option for the given instance. Thus, this instance is unavailable (not findable for creating new orders).
+     - The merchant instance has no active bank accounts configured. However, at least one bank account must be available to create new orders.
    * - MERCHANT_PRIVATE_POST_ORDERS_NO_LOCALTIME
      - 2501
      - 500 (INTERNAL_SERVER_ERROR)
-     - The proposal had no timestamp and the backend failed to obtain the local time. Likely to be an internal error.
+     - The proposal had no timestamp and the merchant backend failed to obtain the current local time.
    * - MERCHANT_PRIVATE_POST_ORDERS_PROPOSAL_PARSE_ERROR
      - 2502
      - 400 (BAD_REQUEST)
-     - The order provided to the backend could not be parsed, some required fields were missing or ill-formed.
+     - The order provided to the backend could not be parsed; likely some required fields were missing or ill-formed.
    * - MERCHANT_PRIVATE_POST_ORDERS_ALREADY_EXISTS
      - 2503
      - 409 (CONFLICT)
-     - The backend encountered an error: the proposal already exists.
+     - A conflicting order (sharing the same order identifier) already exists at this merchant backend instance.
    * - MERCHANT_PRIVATE_POST_ORDERS_REFUND_AFTER_WIRE_DEADLINE
      - 2504
      - 400 (BAD_REQUEST)
-     - The request is invalid: the wire deadline is before the refund deadline.
+     - The order creation request is invalid because the given wire deadline is before the refund deadline.
    * - MERCHANT_PRIVATE_POST_ORDERS_DELIVERY_DATE_IN_PAST
      - 2505
      - 400 (BAD_REQUEST)
-     - The request is invalid: a delivery date was given, but it is in the past.
+     - The order creation request is invalid because the delivery date given is in the past.
    * - MERCHANT_PRIVATE_POST_ORDERS_WIRE_DEADLINE_IS_NEVER
      - 2506
      - 400 (BAD_REQUEST)
-     - The request is invalid: the wire deadline for the order would be "never".
+     - The order creation request is invalid because a wire deadline of "never" is not allowed.
    * - MERCHANT_PRIVATE_POST_ORDERS_PAY_DEADLINE_IN_PAST
      - 2507
      - 400 (BAD_REQUEST)
-     - The request is invalid: a payment deadline was given, but it is in the past.
+     - The order ceration request is invalid because the given payment deadline is in the past.
    * - MERCHANT_PRIVATE_POST_ORDERS_REFUND_DEADLINE_IN_PAST
      - 2508
      - 400 (BAD_REQUEST)
-     - The request is invalid: a refund deadline was given, but it is in the past.
+     - The order creation request is invalid because the given refund deadline is in the past.
    * - MERCHANT_PRIVATE_POST_ORDERS_NO_EXCHANGES_FOR_WIRE_METHOD
      - 2509
      - 409 (CONFLICT)
-     - The backend does not trust any exchange that would allow funds to be wired to any bank account of this instance using the selected wire method. Note that right now, we do not support the use of exchange bank accounts with mandatory currency conversion.
+     - The backend does not trust any exchange that would allow funds to be wired to any bank account of this instance using the wire method specified with the order. Note that right now, we do not support the use of exchange bank accounts with mandatory currency conversion.
    * - MERCHANT_PRIVATE_PATCH_ORDERS_ID_FORGET_PATH_SYNTAX_INCORRECT
      - 2510
      - 400 (BAD_REQUEST)
@@ -1375,7 +1375,7 @@ Entries
    * - MERCHANT_PRIVATE_DELETE_ORDERS_AWAITING_PAYMENT
      - 2520
      - 409 (CONFLICT)
-     - The order provided to the backend could not be deleted, our offer is still valid and awaiting payment.
+     - The order provided to the backend could not be deleted, our offer is still valid and awaiting payment. Deletion may work later after the offer has expired if it remains unpaid.
    * - MERCHANT_PRIVATE_DELETE_ORDERS_ALREADY_PAID
      - 2521
      - 409 (CONFLICT)
@@ -1383,15 +1383,15 @@ Entries
    * - MERCHANT_PRIVATE_POST_ORDERS_ID_REFUND_INCONSISTENT_AMOUNT
      - 2530
      - 409 (CONFLICT)
-     - The amount to be refunded is inconsistent: either is lower than the previous amount being awarded, or it is too big to be paid back. In this second case, the fault stays on the business dept. side.
+     - The amount to be refunded is inconsistent: either is lower than the previous amount being awarded, or it exceeds the original price paid by the customer.
    * - MERCHANT_PRIVATE_POST_ORDERS_ID_REFUND_ORDER_UNPAID
      - 2531
      - 409 (CONFLICT)
-     - The frontend gave an unpaid order id to issue the refund to.
+     - Only paid orders can be refunded, and the frontend specified an unpaid order to issue a refund for.
    * - MERCHANT_PRIVATE_POST_ORDERS_ID_REFUND_NOT_ALLOWED_BY_CONTRACT
      - 2532
      - 403 (FORBIDDEN)
-     - The refund delay was set to 0 and thus no refunds are allowed for this order.
+     - The refund delay was set to 0 and thus no refunds are ever allowed for this order.
    * - MERCHANT_PRIVATE_POST_TRANSFERS_EXCHANGE_UNKNOWN
      - 2550
      - 502 (BAD_GATEWAY)
@@ -1748,6 +1748,14 @@ Entries
      - 5142
      - 409 (CONFLICT)
      - The client tried to create a transaction that credit the admin account.
+   * - BANK_CHALLENGE_NOT_FOUND
+     - 5143
+     - 404 (NOT_FOUND)
+     - The referenced challenge was not found.
+   * - BANK_TAN_CHALLENGE_EXPIRED
+     - 5144
+     - 409 (CONFLICT)
+     - The referenced challenge has expired.
    * - SYNC_ACCOUNT_UNKNOWN
      - 6100
      - 404 (NOT_FOUND)