-minor bugfixes

2 files changed, 27 insertions, 17 deletions

diff --git a/src/fs/gnunet-fs-gtk_publish-dialog.c b/src/fs/gnunet-fs-gtk_publish-dialog.c
index 045ff3b8..aa25440a 100644
--- a/src/fs/gnunet-fs-gtk_publish-dialog.c
+++ b/src/fs/gnunet-fs-gtk_publish-dialog.c
@@ -775,7 +775,7 @@ GNUNET_GTK_master_publish_dialog_updateable_checkbox_toggled_cb (
  * Generates an update id from a new id.
  *
  * @param new_text new id for which to generate update id.
- * @return new update id (free with g_free ()).
+ * @return new update id (free with g_free()).
  */
 static gchar *
 generate_update_id (const gchar *new_text)
@@ -806,6 +806,7 @@ generate_update_id (const gchar *new_text)
   return new_update_id;
 }
 
+
 /**
  * Checks whether existing update id was generated or not.
  * Generates an update id from the previous id, then checks if
@@ -819,11 +820,14 @@ generate_update_id (const gchar *new_text)
  *         FALSE otherwise
  */
 static gboolean
-update_id_is_autofilled (const gchar *existing_update_id, gchar *previous_id)
+update_id_is_autofilled (const gchar *existing_update_id, 
+                         const gchar *previous_id)
 {
   gboolean result;
+  gchar *gen_update_id;
+
   result = TRUE;
-  gchar *gen_update_id = generate_update_id (previous_id);
+  gen_update_id = generate_update_id (previous_id);
   if (0 != strcmp (gen_update_id, existing_update_id))
     result = FALSE;
   g_free (gen_update_id);
@@ -848,13 +852,17 @@ maybe_change_update_id (struct MainPublishingDialogContext *ctx,
   new_update_id = NULL;
   existing_update_id = gtk_entry_get_text (GTK_ENTRY (ctx->update_id_entry));
 
-  if (((NULL == ctx->previous_id) && ('\0' == existing_update_id[0]))
-      || update_id_is_autofilled (existing_update_id, ctx->previous_id))
+  if ( ( (NULL == ctx->previous_id) && 
+         ('\0' == existing_update_id[0]) ) || 
+       ( (NULL != ctx->previous_id) &&
+         update_id_is_autofilled (existing_update_id, 
+                                  ctx->previous_id) ) )
     new_update_id = generate_update_id (new_text);
-  if (new_update_id)
+  if (NULL != new_update_id)
+  {
     gtk_entry_set_text (GTK_ENTRY (ctx->update_id_entry), new_update_id);
-  g_free (new_update_id);
-
+    g_free (new_update_id);
+  }
   g_free (ctx->previous_id);
   ctx->previous_id = g_strdup (new_text);
 }
@@ -866,17 +874,16 @@ maybe_change_update_id (struct MainPublishingDialogContext *ctx,
  * Updates execute/cancel buttons sensitivity.
  *
  * @param widget the entry that was changed
- * @param user_data context
+ * @param user_data our `struct MainPublishingDialogContext`
  */
 void
-GNUNET_GTK_master_publish_dialog_identifier_entry_changed_cb (
-    GtkWidget *widget, gpointer user_data)
+GNUNET_GTK_master_publish_dialog_identifier_entry_changed_cb (GtkWidget *widget, 
+                                                              gpointer user_data)
 {
   struct MainPublishingDialogContext *ctx = user_data;
   const gchar *new_text;
 
   new_text = gtk_entry_get_text (GTK_ENTRY (widget));
-
   if (NULL == new_text)
     return;
   maybe_change_update_id (ctx, new_text);
diff --git a/src/setup/gnunet-setup-gns.c b/src/setup/gnunet-setup-gns.c
index e96e8973..ad028be1 100644
--- a/src/setup/gnunet-setup-gns.c
+++ b/src/setup/gnunet-setup-gns.c
@@ -1641,17 +1641,20 @@ GNUNET_setup_gns_pseu_entry_changed_cb (GtkEditable *editable,
         break;
     if (off == rd_count)
       total++;
-    rd_new[off].record_type = GNUNET_NAMESTORE_TYPE_PSEU;
-    rd_new[off].expiration_time = UINT64_MAX;
-    rd_new[off].flags = GNUNET_NAMESTORE_RF_NONE;
-    rd_new[off].data_size = strlen (pseu) + 1;
-    rd_new[off].data = pseu;
     if ( (NULL == pseu) ||
          (0 == strlen (pseu)) )    
     {
       rd_new[off] = rd_new[rd_count - 1];
       total--;
     } 
+    else
+    {
+      rd_new[off].record_type = GNUNET_NAMESTORE_TYPE_PSEU;
+      rd_new[off].expiration_time = UINT64_MAX;
+      rd_new[off].flags = GNUNET_NAMESTORE_RF_NONE;
+      rd_new[off].data_size = strlen (pseu) + 1;
+      rd_new[off].data = pseu;
+    }
     oc = GNUNET_new (struct OperationContext);
     GNUNET_CONTAINER_DLL_insert (oc_head, oc_tail, oc);
     oc->qe = GNUNET_NAMESTORE_records_store (namestore,