LRN: two directory patches change the way "is_directory" is evaluated.

Now it must be GNUNET_YES for the execution flow to switch to a branch
where something is considered to be a directory.
The reason for that is that some functions might return GNUNET_SYSERR
when asked whether something is a directory or not. Checking this
value as "!= GNUNET_NO" will produce positive result, even though it's
not a directory.

1 files changed, 4 insertions, 4 deletions

diff --git a/src/fs/gnunet-fs-gtk_publish-dialog.c b/src/fs/gnunet-fs-gtk_publish-dialog.c
index dd34cf88..9486d363 100644
--- a/src/fs/gnunet-fs-gtk_publish-dialog.c
+++ b/src/fs/gnunet-fs-gtk_publish-dialog.c
@@ -1023,7 +1023,7 @@ add_item (struct AddDirClientContext *adcc,
   path = gtk_tree_model_get_path (GTK_TREE_MODEL (ts), item_iter);
   row_reference = gtk_tree_row_reference_new (GTK_TREE_MODEL (ts), path);
   gtk_tree_path_free (path);
-  if (item->is_directory)
+  if (item->is_directory == GNUNET_YES)
   {
     /* update meta data mime type (force to be GNUnet-directory) */
     if (NULL != item->meta)
@@ -1088,7 +1088,7 @@ add_share_items_to_treestore (struct AddDirClientContext *adcc,
   {
     add_item (adcc, ts, item, parent_iter, sibling_iter, &last_added);
     sibling_iter = &last_added;
-    if (item->is_directory) 
+    if (item->is_directory == GNUNET_YES) 
       add_share_items_to_treestore (adcc,
                                     item->children_head,
                                     sibling_iter);
@@ -1145,7 +1145,7 @@ directory_scan_cb (void *cls,
       last_pulse = GNUNET_TIME_absolute_get ();
     }
 #if VERBOSE_PROGRESS
-    if (is_directory)
+    if (is_directory == GNUNET_YES)
     {
       GNUNET_asprintf (&s, _("Scanning directory `%s'.\n"), filename);
       insert_progress_dialog_text (adcc, s);
@@ -1154,7 +1154,7 @@ directory_scan_cb (void *cls,
     else
       adcc->total++;
 #else
-    if (! is_directory)
+    if (is_directory != GNUNET_YES)
       adcc->total++;
 #endif
     break;