1 files changed, 66 insertions, 72 deletions

diff --git a/src/namestore/gnunet-namestore-gtk.c b/src/namestore/gnunet-namestore-gtk.c
index 8c3acf8a..eb13501f 100644
--- a/src/namestore/gnunet-namestore-gtk.c
+++ b/src/namestore/gnunet-namestore-gtk.c
@@ -374,14 +374,9 @@ static struct GNUNET_IDENTITY_Operation *id_op;
 static struct GNUNET_GTK_MainLoop *ml;
 
 /**
- * Name of the configuration file.
- */
-static const char *cfgName;
-
-/**
  * Our configuration.
  */
-struct GNUNET_CONFIGURATION_Handle *cfg;
+static const struct GNUNET_CONFIGURATION_Handle *cfg;
 
 /**
  * Global return value (for success/failure of gnunet-setup).
@@ -389,7 +384,6 @@ struct GNUNET_CONFIGURATION_Handle *cfg;
 static int gret;
 
 
-
 /**
  * Get an object from the main window.
  *
@@ -405,7 +399,6 @@ get_object (const char *name)
 }
 
 
-
 #if HAVE_QRENCODE_H
 #include <qrencode.h>
 #include <gdk-pixbuf/gdk-pixbuf.h>
@@ -441,7 +434,7 @@ create_qrcode (unsigned int scale)
     GNUNET_log_strerror (GNUNET_ERROR_TYPE_WARNING, "QRinput_new2");
     return NULL;
   }
-  entry = GTK_ENTRY (get_object ("gnunet_namestore_gtk_gns_pseu_entry"));
+  entry = GTK_ENTRY (get_object ("gnunet_namestore_gtk_pseu_entry"));
   pseu = gtk_entry_get_text (GTK_ENTRY(entry));
   GNUNET_asprintf (&str,
                    "gnunet://gns/%s/%s\n",
@@ -514,7 +507,7 @@ setup_qrcode ()
     GNUNET_log (GNUNET_ERROR_TYPE_WARNING, _("Failed to initialize QR-code pixbuf"));
     return;
   }
-  image = GTK_IMAGE (get_object ("gnunet_namestore_gtk_gns_qr_image"));
+  image = GTK_IMAGE (get_object ("gnunet_namestore_gtk_qr_image"));
   if (NULL == image)
   {
     GNUNET_break (0);
@@ -532,7 +525,7 @@ setup_qrcode ()
  *
  * @param dialog the dialog
  * @param response_id reason for the dialog closing
- * @param user_data the 'GtkBuilder' we used to create the dialog
+ * @param user_data the `GtkBuilder` we used to create the dialog
  */
 void
 gnunet_namestore_gtk_qr_save_as_dialog_response_cb (GtkDialog *dialog,
@@ -577,7 +570,7 @@ gnunet_namestore_gtk_qr_save_as_dialog_response_cb (GtkDialog *dialog,
  * dialog to get the desired filename and file type.
  */
 void
-gnunet_namestore_gtk_gns_qr_saveas_button_clicked_cb (GtkButton *button,
+gnunet_namestore_gtk_qr_saveas_button_clicked_cb (GtkButton *button,
                                               gpointer user_data)
 {
   GtkBuilder *builder;
@@ -586,7 +579,7 @@ gnunet_namestore_gtk_gns_qr_saveas_button_clicked_cb (GtkButton *button,
   GtkEntry *entry;
   char *suggestion;
 
-  entry = GTK_ENTRY (get_object ("gnunet_namestore_gtk_gns_pseu_entry"));
+  entry = GTK_ENTRY (get_object ("gnunet_namestore_gtk_pseu_entry"));
   pseu = gtk_entry_get_text (GTK_ENTRY(entry));
   builder =
     GNUNET_GTK_get_new_builder ("gnunet_namestore_gtk_qr_save_as_dialog.glade",
@@ -612,10 +605,10 @@ gnunet_namestore_gtk_gns_qr_saveas_button_clicked_cb (GtkButton *button,
  * Check if adding a record of the given type is Ok given the other
  * records already present for the given name.
  *
- * @param rd_count size of the 'rd' array
+ * @param rd_count size of the @a rd array
  * @param rd existing records
  * @param n_type new record to be added
- * @return GNUNET_OK if adding this record is OK, GNUNET_NO if not
+ * @return #GNUNET_OK if adding this record is OK, #GNUNET_NO if not
  */
 static int
 check_record_permitted (unsigned int rd_count,
@@ -665,8 +658,8 @@ check_record_permitted (unsigned int rd_count,
 /**
  * Function called upon completion of an operation.
  *
- * @param cls the 'struct OperationContext' of the operation that completed
- * @param success GNUNET_OK if the operation succeeded
+ * @param cls the `struct OperationContext` of the operation that completed
+ * @param success #GNUNET_OK if the operation succeeded
  * @param emsg error message if the operation failed
  */
 static void
@@ -735,13 +728,13 @@ clear_zone_view ()
   GNUNET_CONTAINER_multihashmap_iterate (n2r,
                                          &release_ri,
                                          NULL);
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_zone_selection_hbuttonbox")));
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_status_label")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_main_scrolledwindow")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_image")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_saveas_button")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_vseparator")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_pseu_hbox")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_zone_selection_hbuttonbox")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_status_label")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_scrolledwindow")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_image")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_saveas_button")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_vseparator")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_pseu_hbox")));
   gtk_tree_store_clear (ts);
 }
 
@@ -804,7 +797,7 @@ free_edit_dialog_context (struct EditDialogContext *edc)
  * Process a record that was stored in the namestore.
  *
  * @param cls closure
- * @param rd_count number of entries in 'rd' array
+ * @param rd_count number of entries in @a rd array
  * @param rd array of records with data to store
  */
 static void
@@ -853,7 +846,7 @@ merge_with_existing_records (void *cls,
  * Process an encrypted that was stored in the namestore for
  * merging.
  *
- * @param cls closure
+ * @param cls closure with the `struct MoveOperationContext`
  * @param block block to decrypt
  */
 static void
@@ -885,7 +878,7 @@ decrypt_block_for_merge (void *cls,
 
 /**
  * The edit dialog completed; update the namestore and the
- * view based on the new values in 'edc'.
+ * view based on the new values in @a edc.
  *
  * @param edc editing context information
  * @param ret return code of the dialog
@@ -1080,7 +1073,7 @@ edit_dialog_continuation (struct EditDialogContext *edc,
  * @param ri record information for this name (can be NULL
  *        if this is the first record for the name)
  * @param off offset of the record being edited in the
- *        ri's list; UINT_MAX if this is a new record
+ *        @a ri's list; UINT_MAX if this is a new record
  */
 static void
 launch_edit_dialog (gint n_type,
@@ -1174,7 +1167,7 @@ launch_edit_dialog (gint n_type,
  *
  * @param ri existing records
  * @param n_type type of the new record
- * @return GNUNET_OK if this is allowed
+ * @return #GNUNET_OK if this is allowed
  */
 static int
 check_permissions (struct RecordInfo *ri,
@@ -1210,8 +1203,8 @@ check_permissions (struct RecordInfo *ri,
  * @param user_data main window builder
  */
 void
-gnunet_namestore_gtk_gns_popup_edit_button_activate_cb (GtkWidget *widget,
-                                                gpointer user_data)
+gnunet_namestore_gtk_popup_edit_button_activate_cb (GtkWidget *widget,
+                                                        gpointer user_data)
 {
   GtkTreeSelection *sel;
   gint n_type;
@@ -1263,10 +1256,10 @@ gnunet_namestore_gtk_gns_popup_edit_button_activate_cb (GtkWidget *widget,
  * @param user_data unused
  */
 void
-gnunet_namestore_gtk_gns_type_cellrenderercombo_edited_cb (GtkCellRendererText *text,
-                                                   gchar *path_string,
-                                                   gchar *new_text,
-                                                   gpointer user_data)
+gnunet_namestore_gtk_type_cellrenderercombo_edited_cb (GtkCellRendererText *text,
+                                                           gchar *path_string,
+                                                           gchar *new_text,
+                                                           gpointer user_data)
 {
   GtkTreeIter it;
   guint type;
@@ -1322,10 +1315,10 @@ gnunet_namestore_gtk_gns_type_cellrenderercombo_edited_cb (GtkCellRendererText *
  * @param user_data unused
  */
 void
-gnunet_namestore_gtk_gns_name_cellrenderertext_edited_cb (GtkCellRendererText *renderer,
-                                                  gchar *path,
-                                                  gchar *new_text,
-                                                  gpointer user_data)
+gnunet_namestore_gtk_name_cellrenderertext_edited_cb (GtkCellRendererText *renderer,
+                                                          gchar *path,
+                                                          gchar *new_text,
+                                                          gpointer user_data)
 {
   GtkTreeIter it;
   gboolean not_dummy;
@@ -1447,8 +1440,8 @@ create_popup_menu ()
  * @return TRUE if a menu was activated
  */
 gboolean
-gnunet_namestore_gtk_gns_main_treeview_popup_menu_cb (GtkWidget *widget,
-                                              gpointer user_data)
+gnunet_namestore_gtk_treeview_popup_menu_cb (GtkWidget *widget,
+                                                      gpointer user_data)
 {
   return create_popup_menu ();
 }
@@ -1464,7 +1457,7 @@ gnunet_namestore_gtk_gns_main_treeview_popup_menu_cb (GtkWidget *widget,
  * @return TRUE if a menu was activated (event was handled)
  */
 gboolean
-gnunet_namestore_gtk_gns_main_treeview_button_press_event_cb (GtkWidget *widget,
+gnunet_namestore_gtk_treeview_button_press_event_cb (GtkWidget *widget,
                                                       GdkEventButton *event,
                                                       gpointer user_data)
 {
@@ -1488,7 +1481,7 @@ gnunet_namestore_gtk_gns_main_treeview_button_press_event_cb (GtkWidget *widget,
  * @return TRUE if the key was processed ('del')
  */
 gboolean
-gnunet_namestore_gtk_gns_main_treeview_key_press_event_cb (GtkWidget *widget,
+gnunet_namestore_gtk_treeview_key_press_event_cb (GtkWidget *widget,
                                                    GdkEventKey *event,
                                                    gpointer user_data)
 {
@@ -1614,7 +1607,7 @@ gnunet_namestore_gtk_gns_main_treeview_key_press_event_cb (GtkWidget *widget,
  * @param user_data unused
  */
 void
-gnunet_namestore_gtk_gns_pseu_entry_changed_cb (GtkEditable *editable,
+gnunet_namestore_gtk_pseu_entry_changed_cb (GtkEditable *editable,
                                         gpointer user_data)
 {
   const gchar *pseu;
@@ -1713,7 +1706,7 @@ gnunet_namestore_gtk_gns_pseu_entry_changed_cb (GtkEditable *editable,
  * @param user_data unused
  */
 void
-gnunet_namestore_gtk_gns_public_key_copy_button_clicked_cb (GtkButton *button,
+gnunet_namestore_gtk_public_key_copy_button_clicked_cb (GtkButton *button,
                                                     gpointer user_data)
 {
   GtkClipboard *cb;
@@ -1737,20 +1730,20 @@ static void
 zone_sync_proc (void *cls)
 {
   if (0 == strcmp (current_zone_option, "ZONEKEY"))
-    gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_pseu_hbox")));
+    gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_pseu_hbox")));
 #if HAVE_QRENCODE_H
   setup_qrcode ();
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_image")));
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_saveas_button")));
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_vseparator")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_image")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_saveas_button")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_vseparator")));
 #else
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_image")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_saveas_button")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_qr_vseparator")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_image")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_saveas_button")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_qr_vseparator")));
 #endif
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_status_label")));
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_main_scrolledwindow")));
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_zone_selection_hbuttonbox")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_status_label")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_scrolledwindow")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_zone_selection_hbuttonbox")));
 }
 
 
@@ -1924,7 +1917,7 @@ zone_iteration_proc (void *cls,
          (GNUNET_NAMESTORE_TYPE_PSEU == rd[c].record_type) &&
          (NULL == current_pseudonym) )
     {
-      pseu_entry = GTK_ENTRY((get_object ("gnunet_namestore_gtk_gns_pseu_entry")));
+      pseu_entry = GTK_ENTRY((get_object ("gnunet_namestore_gtk_pseu_entry")));
       gtk_entry_set_text (pseu_entry, val);
 #if HAVE_QRENCODE_H
       setup_qrcode ();
@@ -1998,7 +1991,7 @@ identity_cb (void *cls,
     show_error_message (_("Failed to load zone"),
                         emsg);
     GNUNET_free (emsg);
-    gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_zone_selection_hbuttonbox")));
+    gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_zone_selection_hbuttonbox")));
     return;
   }
   pkey = GNUNET_new (struct GNUNET_CRYPTO_EccPrivateKey);
@@ -2006,7 +1999,7 @@ identity_cb (void *cls,
   GNUNET_CRYPTO_ecc_key_get_public_for_signature (pkey, &pubkey);
   label = g_markup_printf_escaped (_("<b>Editing zone %s</b>"),
                                    GNUNET_NAMESTORE_z2s (&pubkey));
-  gtk_label_set_markup (GTK_LABEL (get_object ("gnunet_namestore_gtk_gns_zone_label")),
+  gtk_label_set_markup (GTK_LABEL (get_object ("gnunet_namestore_gtk_zone_label")),
                        label);
   g_free (label);
   /* Append a top level row and leave it empty */
@@ -2071,8 +2064,8 @@ load_zone (const char *zonename)
  * @param user_data builder, unused
  */
 void
-gnunet_namestore_gtk_gns_shorten_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
-                                                                gpointer user_data)
+gnunet_namestore_gtk_shorten_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
+                                                                        gpointer user_data)
 {
   if (gtk_toggle_button_get_active (togglebutton))
     load_zone ("gns-short");
@@ -2087,8 +2080,8 @@ gnunet_namestore_gtk_gns_shorten_zone_selection_radiobutton_toggled_cb (GtkToggl
  * @param user_data builder, unused
  */
 void
-gnunet_namestore_gtk_gns_private_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
-                                                                gpointer user_data)
+gnunet_namestore_gtk_private_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
+                                                                        gpointer user_data)
 {
   if (gtk_toggle_button_get_active (togglebutton))
     load_zone ("gns-private");
@@ -2103,8 +2096,8 @@ gnunet_namestore_gtk_gns_private_zone_selection_radiobutton_toggled_cb (GtkToggl
  * @param user_data builder, unused
  */
 void
-gnunet_namestore_gtk_gns_master_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
-                                                               gpointer user_data)
+gnunet_namestore_gtk_master_zone_selection_radiobutton_toggled_cb (GtkToggleButton *togglebutton,
+                                                                       gpointer user_data)
 {
   if (gtk_toggle_button_get_active (togglebutton))
     load_zone ("gns-master");
@@ -2118,7 +2111,8 @@ gnunet_namestore_gtk_gns_master_zone_selection_radiobutton_toggled_cb (GtkToggle
  * @param tc scheduler context
  */
 static void
-cleanup_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
+cleanup_task (void *cls,
+              const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct OperationContext *oc;
   struct MoveOperationContext *moc;
@@ -2131,8 +2125,8 @@ cleanup_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   GNUNET_GTK_main_loop_quit (ml);
 
 
-  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_status_label")));
-  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_gns_main_scrolledwindow")));
+  gtk_widget_show (GTK_WIDGET (get_object ("gnunet_namestore_gtk_status_label")));
+  gtk_widget_hide (GTK_WIDGET (get_object ("gnunet_namestore_gtk_scrolledwindow")));
   if (NULL != zmon)
   {
     GNUNET_NAMESTORE_zone_monitor_stop (zmon);
@@ -2220,26 +2214,26 @@ run (void *cls,
   GtkLabel *status_label;
 
   ml = cls;
+  cfg = GNUNET_GTK_main_loop_get_configuration (ml);
   if (GNUNET_OK != GNUNET_GTK_main_loop_build_window (ml, NULL))
     return;
 
-  cfgName = GNUNET_GTK_main_loop_get_configuration_file (ml);
-  main_window = GTK_WIDGET (get_object ("gnunet_namestore_dialog"));
+  main_window = GTK_WIDGET (get_object ("gnunet_namestore_gtk_dialog"));
   GNUNET_SCHEDULER_add_delayed (GNUNET_TIME_UNIT_FOREVER_REL,
                                 &cleanup_task, NULL);
 
   namestore = GNUNET_NAMESTORE_connect (cfg);
   if (NULL == namestore)
   {
-    status_label = GTK_LABEL (get_object ("gnunet_namestore_gtk_gns_status_label"));
+    status_label = GTK_LABEL (get_object ("gnunet_namestore_gtk_status_label"));
     label = g_markup_printf_escaped (_("<b><big>Failed to connect to namestore</b></big>"));
     gtk_label_set_markup (status_label, label);
     g_free (label);
     return;
   }
   identity = GNUNET_IDENTITY_connect (cfg, NULL, NULL);
-  ts = GTK_TREE_STORE (get_object ("gnunet_namestore_gtk_gns_treestore"));
-  tv = GTK_TREE_VIEW (get_object ("gnunet_namestore_gtk_gns_main_treeview"));
+  ts = GTK_TREE_STORE (get_object ("gnunet_namestore_gtk_treestore"));
+  tv = GTK_TREE_VIEW (get_object ("gnunet_namestore_gtk_treeview"));
   tm = GTK_TREE_MODEL (ts);
   n2r = GNUNET_CONTAINER_multihashmap_create (128, GNUNET_NO);
   load_zone ("gns-master");