added documentation for the voting protocol,

fixed some bugs detected by coverty,
implemented most of the cryptographic primitives for voting

4 files changed, 12 insertions, 5 deletions

diff --git a/test/org/gnunet/construct/ConstructTest.java b/test/org/gnunet/construct/ConstructTest.java
index 8853b1d..ed6ac51 100644
--- a/test/org/gnunet/construct/ConstructTest.java
+++ b/test/org/gnunet/construct/ConstructTest.java
@@ -45,7 +45,7 @@ public class ConstructTest {
 
         byte[] data = Construct.toBinary(im);
 
-        IntMessage im_new = Construct.parseAs(data, IntMessage.class);
+        Construct.parseAs(data, IntMessage.class);
 
         Assert.assertEquals((1+2+4+8)*2, data.length);
         Assert.assertEquals((1+2+4+8)*2, Construct.getStaticSize(im));
@@ -55,7 +55,7 @@ public class ConstructTest {
     public void test_PrivateMemberMessage() {
         PrivateMemberMessage m1 = new PrivateMemberMessage();
         byte[] data = Construct.toBinary(m1);
-        PrivateMemberMessage m2 = Construct.parseAs(data, PrivateMemberMessage.class);
+        Construct.parseAs(data, PrivateMemberMessage.class);
     }
 
 
diff --git a/test/org/gnunet/construct/FixedSizeTest.java b/test/org/gnunet/construct/FixedSizeTest.java
index 573e120..4439ad4 100644
--- a/test/org/gnunet/construct/FixedSizeTest.java
+++ b/test/org/gnunet/construct/FixedSizeTest.java
@@ -47,6 +47,6 @@ public class FixedSizeTest {
     public void test_sizeMismatch() {
         FixedSizeTestMessage m = new FixedSizeTestMessage();
         m.msgs = new Msg[]{new Msg(1), new Msg(2)};
-        byte[] bytes = Construct.toBinary(m);
+        Construct.toBinary(m);
     }
 }
diff --git a/test/org/gnunet/construct/StringTuple.java b/test/org/gnunet/construct/StringTuple.java
index 085b7a9..1820ae1 100644
--- a/test/org/gnunet/construct/StringTuple.java
+++ b/test/org/gnunet/construct/StringTuple.java
@@ -1,5 +1,8 @@
 package org.gnunet.construct;
 
+import com.google.common.base.Objects;
+import com.google.common.hash.HashCodes;
+
 /**
 * ...
 *
@@ -26,4 +29,9 @@ public class StringTuple implements Message {
         StringTuple otherT = (StringTuple) other;
         return otherT.str1.equals(this.str1) && otherT.str2.equals(this.str2);
     }
+
+    @Override
+    public int hashCode() {
+        return Objects.hashCode(str1, str2);
+    }
 }
diff --git a/test/org/gnunet/util/getopt/GetoptTest.java b/test/org/gnunet/util/getopt/GetoptTest.java
index e60757e..010c240 100644
--- a/test/org/gnunet/util/getopt/GetoptTest.java
+++ b/test/org/gnunet/util/getopt/GetoptTest.java
@@ -258,9 +258,8 @@ public class GetoptTest {
         Target t = new Target();
         Parser p = new Parser(t);
 
-        String[] rest;
 
-        rest = p.parse(new String[]{"-w", "abc"});
+        p.parse(new String[]{"-w", "abc"});
         Assert.assertEquals(5, t.intVal);
     }