PEERSTORE store function

6 files changed, 74 insertions, 16 deletions

diff --git a/src/include/gnunet_peerstore_plugin.h b/src/include/gnunet_peerstore_plugin.h
index 8dcc1ec2a..f693072c0 100644
--- a/src/include/gnunet_peerstore_plugin.h
+++ b/src/include/gnunet_peerstore_plugin.h
@@ -63,10 +63,10 @@ struct GNUNET_PEERSTORE_PluginFunctions
    */
   int
   (*store_record) (void *cls,
-          const char *sub_system,
-          const struct GNUNET_PeerIdentity *peer,
-          const void *value,
-          size_t size);
+      const struct GNUNET_PeerIdentity *peer,
+      const char *sub_system,
+      const void *value,
+      size_t size);
 
 };
 
diff --git a/src/peerstore/gnunet-service-peerstore.c b/src/peerstore/gnunet-service-peerstore.c
index d3f87c4bc..837c5ca75 100644
--- a/src/peerstore/gnunet-service-peerstore.c
+++ b/src/peerstore/gnunet-service-peerstore.c
@@ -26,6 +26,10 @@
 #include "platform.h"
 #include "gnunet_util_lib.h"
 #include "peerstore.h"
+#include "gnunet_peerstore_plugin.h"
+
+//TODO: GNUNET_SERVER_receive_done() ?
+//TODO: implement value lifetime
 
 /**
  * Our configuration.
@@ -85,21 +89,68 @@ void handle_store (void *cls,
     struct GNUNET_SERVER_Client *client,
     const struct GNUNET_MessageHeader *message)
 {
-  struct StoreRequestMessage *sreqm;
-  struct GNUNET_SERVER_TransmitContext *tc;
-  struct StoreResponseMessage *sresm;
+  struct StoreRequestMessage *req;
   uint16_t msg_size;
+  uint16_t sub_system_size;
+  uint16_t value_size;
   char *sub_system;
+  void *value;
+  struct GNUNET_SERVER_TransmitContext *tc;
+  struct StoreResponseMessage *res;
+  char *emsg;
+  size_t emsg_size = 0;
+  char *emsg_dest;
 
   msg_size = ntohs(message->size);
-  GNUNET_break_op(msg_size > sizeof(struct GNUNET_MessageHeader) + sizeof(struct StoreRequestMessage));
-  sreqm = (struct StoreRequestMessage *)&message[1];
-  sub_system = (char *)&sreqm[1];
+  if(msg_size < sizeof(struct StoreRequestMessage))
+  {
+    GNUNET_break(0);
+    GNUNET_SERVER_receive_done(client, GNUNET_SYSERR);
+    return;
+  }
+  req = (struct StoreRequestMessage *)message;
+  sub_system_size = ntohs(req->sub_system_size);
+  value_size = ntohs(req->value_size);
+  if(sub_system_size + value_size + sizeof(struct StoreRequestMessage)
+      != msg_size)
+  {
+    GNUNET_break(0);
+    GNUNET_SERVER_receive_done(client, GNUNET_SYSERR);
+    return;
+  }
+  sub_system = (char *)&req[1];
+  value = sub_system + sub_system_size;
   GNUNET_log(GNUNET_ERROR_TYPE_INFO, "Received a store request (size: %lu) for sub system `%s' and peer `%s'\n",
       msg_size,
       sub_system,
-      GNUNET_i2s (&sreqm->peer));
-  //TODO: do the actual storage
+      GNUNET_i2s (&req->peer));
+  if(GNUNET_OK != db->store_record(db->cls,
+      &req->peer,
+     sub_system,
+     value,
+     value_size))
+  {
+    GNUNET_log(GNUNET_ERROR_TYPE_ERROR, "Failed to store requested value, sqlite database error.");
+    emsg = _("Failed to store requested value, sqlite database error.");
+    emsg_size = strlen(emsg) + 1;
+  }
+  res = GNUNET_malloc(sizeof(struct StoreResponseMessage) + emsg_size);
+  res->emsg_size = htons(emsg_size);
+  res->header.size = htons(sizeof(struct StoreResponseMessage) + emsg_size);
+  res->header.type = htons(GNUNET_MESSAGE_TYPE_PEERSTORE_STORE_RESULT);
+  if(emsg_size > 0)
+  {
+    res->success = htons(GNUNET_NO);
+    emsg_dest = (char *)&res[1];
+    memcpy(emsg_dest, emsg, emsg_size);
+  }
+  else
+    res->success = htons(GNUNET_YES);
+  tc = GNUNET_SERVER_transmit_context_create (client);
+  GNUNET_SERVER_transmit_context_append_message(tc, (struct GNUNET_MessageHeader *)res);
+  GNUNET_free(res);
+  GNUNET_SERVER_transmit_context_run (tc, GNUNET_TIME_UNIT_FOREVER_REL);
+
 }
 
 /**
diff --git a/src/peerstore/peerstore_api.c b/src/peerstore/peerstore_api.c
index 959d2488a..ffe973df4 100644
--- a/src/peerstore/peerstore_api.c
+++ b/src/peerstore/peerstore_api.c
@@ -232,6 +232,7 @@ GNUNET_PEERSTORE_connect (const struct GNUNET_CONFIGURATION_Handle *cfg)
 
 /**
  * Disconnect from the PEERSTORE service
+ * Do not call in case of pending requests
  *
  * @param h handle to disconnect
  */
@@ -583,7 +584,7 @@ GNUNET_PEERSTORE_store (struct GNUNET_PEERSTORE_Handle *h,
   LOG (GNUNET_ERROR_TYPE_DEBUG,
       "Storing value (size: %lu) for subsytem `%s' and peer `%s'\n",
       size, sub_system, GNUNET_i2s (peer));
-  sub_system_size = strlen(sub_system);
+  sub_system_size = strlen(sub_system) + 1;
   request_size = sizeof(struct StoreRequestMessage) + sub_system_size + size;
   rc = GNUNET_malloc(sizeof(struct GNUNET_PEERSTORE_RequestContext) + request_size);
   rc->h = h;
diff --git a/src/peerstore/plugin_peerstore_sqlite.c b/src/peerstore/plugin_peerstore_sqlite.c
index 1695938bb..e967e2177 100644
--- a/src/peerstore/plugin_peerstore_sqlite.c
+++ b/src/peerstore/plugin_peerstore_sqlite.c
@@ -104,7 +104,7 @@ peerstore_sqlite_store_record (void *cls,
   //FIXME: check if value exists with the same key first
 
   if(SQLITE_OK != sqlite3_bind_blob(stmt, 2, peer, sizeof(struct GNUNET_PeerIdentity), SQLITE_STATIC)
-      || SQLITE_OK != sqlite3_bind_text(stmt, 1, sub_system, sizeof(sub_system), SQLITE_STATIC)
+      || SQLITE_OK != sqlite3_bind_text(stmt, 1, sub_system, strlen(sub_system) + 1, SQLITE_STATIC)
       || SQLITE_OK != sqlite3_bind_blob(stmt, 3, value, size, SQLITE_STATIC))
     LOG_SQLITE (plugin, GNUNET_ERROR_TYPE_ERROR | GNUNET_ERROR_TYPE_BULK,
                     "sqlite3_bind");
diff --git a/src/peerstore/test_peerstore_api.c b/src/peerstore/test_peerstore_api.c
index 51251d72a..8cb2c4516 100644
--- a/src/peerstore/test_peerstore_api.c
+++ b/src/peerstore/test_peerstore_api.c
@@ -30,6 +30,11 @@ static int ok = 1;
 
 struct GNUNET_PEERSTORE_Handle *h;
 
+void store_cont(void *cls, const char *emsg)
+{
+  GNUNET_PEERSTORE_disconnect(h);
+}
+
 static void
 run (void *cls,
     const struct GNUNET_CONFIGURATION_Handle *cfg,
@@ -49,9 +54,8 @@ run (void *cls,
       val,
       val_size,
       GNUNET_TIME_UNIT_FOREVER_REL,
-      NULL,
+      &store_cont,
       NULL);
-  GNUNET_PEERSTORE_disconnect(h);
 
 }
 
diff --git a/src/sensor/gnunet-service-sensor.c b/src/sensor/gnunet-service-sensor.c
index b11da6ecd..8a6b151d8 100644
--- a/src/sensor/gnunet-service-sensor.c
+++ b/src/sensor/gnunet-service-sensor.c
@@ -28,6 +28,8 @@
 #include "gnunet_util_lib.h"
 #include "sensor.h"
 
+//TODO: GNUNET_SERVER_receive_done() ?
+
 /**
  * Minimum sensor execution interval (in seconds)
  */