-clarify API

3 files changed, 6 insertions, 7 deletions

diff --git a/src/ats/gnunet-service-ats_preferences.h b/src/ats/gnunet-service-ats_preferences.h
index dc19891bb..4500dd0ff 100644
--- a/src/ats/gnunet-service-ats_preferences.h
+++ b/src/ats/gnunet-service-ats_preferences.h
@@ -76,7 +76,7 @@ GAS_preference_done (void);
  * @param cls ignored
  * @param id the peer
  * @return pointer to the values, can be indexed
- *  with GNUNET_ATS_PreferenceKind, NULL if peer does not exist
+ *  with `enum GNUNET_ATS_PreferenceKind`, never NULL
  */
 const double *
 GAS_preference_get_by_peer (void *cls,
diff --git a/src/ats/plugin_ats_mlp.c b/src/ats/plugin_ats_mlp.c
index ec53e7438..f2f961f7e 100644
--- a/src/ats/plugin_ats_mlp.c
+++ b/src/ats/plugin_ats_mlp.c
@@ -2032,7 +2032,7 @@ get_peer_pref_value (struct GAS_MLP_Handle *mlp,
                      const struct GNUNET_PeerIdentity *peer)
 {
   double res;
-  const double *preferences = NULL;
+  const double *preferences;
   int c;
 
   preferences = mlp->env->get_preferences (mlp->env->cls, peer);
diff --git a/src/ats/plugin_ats_proportional.c b/src/ats/plugin_ats_proportional.c
index b4cabb067..96ff1a0c0 100644
--- a/src/ats/plugin_ats_proportional.c
+++ b/src/ats/plugin_ats_proportional.c
@@ -542,8 +542,8 @@ distribute_bandwidth (struct GAS_PROPORTIONAL_Handle *s,
     if (GNUNET_YES != cur_address->addr->active)
       continue;
 
-    GNUNET_assert( NULL != (peer_relative_prefs = s->env->get_preferences (s->env->cls,
-                                                                           &cur_address->addr->peer)));
+    peer_relative_prefs = s->env->get_preferences (s->env->cls,
+                                                   &cur_address->addr->peer);
     relative_peer_prefence = 0.0;
     relative_peer_prefence += peer_relative_prefs[GNUNET_ATS_PREFERENCE_BANDWIDTH];
     sum_relative_peer_prefences += relative_peer_prefence;
@@ -577,9 +577,8 @@ distribute_bandwidth (struct GAS_PROPORTIONAL_Handle *s,
   {
     if (GNUNET_YES == cur_address->addr->active)
     {
-      GNUNET_assert( NULL != (peer_relative_prefs =
-                              s->env->get_preferences (s->env->cls,
-                                                       &cur_address->addr->peer)));
+      peer_relative_prefs = s->env->get_preferences (s->env->cls,
+                                                     &cur_address->addr->peer);
 
       cur_pref = peer_relative_prefs[GNUNET_ATS_PREFERENCE_BANDWIDTH];
       total_weight = net->active_addresses +