diff options
author | Martin Schanzenbach <mschanzenbach@posteo.de> | 2021-05-15 19:46:29 +0200 |
---|---|---|
committer | Martin Schanzenbach <mschanzenbach@posteo.de> | 2021-05-15 19:46:29 +0200 |
commit | 7dc8165b9b94b23cbb5bf23977d1cd7523ecb16e (patch) | |
tree | f518eaea582eb76de1b10bc21e9b28a12fda936f /src/datastore | |
parent | f7d5c045f7ada74d3227f93631247d04344923ba (diff) | |
download | gnunet-7dc8165b9b94b23cbb5bf23977d1cd7523ecb16e.tar.gz gnunet-7dc8165b9b94b23cbb5bf23977d1cd7523ecb16e.zip |
Revert "-coverity: use after free"
This reverts commit 168e501991b9506b588e1180527dad9c9662ae0c.
Diffstat (limited to 'src/datastore')
-rw-r--r-- | src/datastore/datastore_api.c | 2 | ||||
-rw-r--r-- | src/datastore/gnunet-service-datastore.c | 6 | ||||
-rw-r--r-- | src/datastore/plugin_datastore_sqlite.c | 3 |
3 files changed, 4 insertions, 7 deletions
diff --git a/src/datastore/datastore_api.c b/src/datastore/datastore_api.c index cb21c9308..d658b9c85 100644 --- a/src/datastore/datastore_api.c +++ b/src/datastore/datastore_api.c | |||
@@ -1430,7 +1430,7 @@ GNUNET_DATASTORE_get_key (struct GNUNET_DATASTORE_Handle *h, | |||
1430 | { | 1430 | { |
1431 | LOG (GNUNET_ERROR_TYPE_DEBUG, | 1431 | LOG (GNUNET_ERROR_TYPE_DEBUG, |
1432 | "Could not queue request for `%s'\n", | 1432 | "Could not queue request for `%s'\n", |
1433 | (NULL == key) ? "NULL" : GNUNET_h2s (key)); | 1433 | GNUNET_h2s (key)); |
1434 | return NULL; | 1434 | return NULL; |
1435 | } | 1435 | } |
1436 | #if INSANE_STATISTICS | 1436 | #if INSANE_STATISTICS |
diff --git a/src/datastore/gnunet-service-datastore.c b/src/datastore/gnunet-service-datastore.c index 7d07ba3b3..97888ce03 100644 --- a/src/datastore/gnunet-service-datastore.c +++ b/src/datastore/gnunet-service-datastore.c | |||
@@ -1556,8 +1556,7 @@ run (void *cls, | |||
1556 | 5); /* approx. 3% false positives at max use */ | 1556 | 5); /* approx. 3% false positives at max use */ |
1557 | refresh_bf = GNUNET_YES; | 1557 | refresh_bf = GNUNET_YES; |
1558 | } | 1558 | } |
1559 | if (NULL != pfn) | 1559 | GNUNET_free (pfn); |
1560 | GNUNET_free (pfn); | ||
1561 | } | 1560 | } |
1562 | else | 1561 | else |
1563 | { | 1562 | { |
@@ -1567,8 +1566,7 @@ run (void *cls, | |||
1567 | 5); /* approx. 3% false positives at max use */ | 1566 | 5); /* approx. 3% false positives at max use */ |
1568 | refresh_bf = GNUNET_YES; | 1567 | refresh_bf = GNUNET_YES; |
1569 | } | 1568 | } |
1570 | if (NULL != fn) | 1569 | GNUNET_free (fn); |
1571 | GNUNET_free (fn); | ||
1572 | if (NULL == filter) | 1570 | if (NULL == filter) |
1573 | { | 1571 | { |
1574 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, | 1572 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
diff --git a/src/datastore/plugin_datastore_sqlite.c b/src/datastore/plugin_datastore_sqlite.c index 40f955312..f58955b7b 100644 --- a/src/datastore/plugin_datastore_sqlite.c +++ b/src/datastore/plugin_datastore_sqlite.c | |||
@@ -729,8 +729,7 @@ sqlite_plugin_put (void *cls, | |||
729 | } | 729 | } |
730 | GNUNET_SQ_reset (plugin->dbh, stmt); | 730 | GNUNET_SQ_reset (plugin->dbh, stmt); |
731 | cont (cont_cls, key, size, ret, msg); | 731 | cont (cont_cls, key, size, ret, msg); |
732 | if (NULL != msg) | 732 | GNUNET_free (msg); |
733 | GNUNET_free (msg); | ||
734 | } | 733 | } |
735 | 734 | ||
736 | 735 | ||