diff options
author | Christian Grothoff <christian@grothoff.org> | 2013-09-21 09:50:57 +0000 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2013-09-21 09:50:57 +0000 |
commit | 632cef13b6015609f980562692df4dddf1d8e6d2 (patch) | |
tree | c4244f70dbe42c23ca3a785e6d3750db6c20a958 /src/include/gnunet_multicast_service.h | |
parent | 9db84f729ed3dc14c49dc38ec9ba4bbcade14054 (diff) | |
download | gnunet-632cef13b6015609f980562692df4dddf1d8e6d2.tar.gz gnunet-632cef13b6015609f980562692df4dddf1d8e6d2.zip |
fixing issues and comments on multicast API
Diffstat (limited to 'src/include/gnunet_multicast_service.h')
-rw-r--r-- | src/include/gnunet_multicast_service.h | 13 |
1 files changed, 10 insertions, 3 deletions
diff --git a/src/include/gnunet_multicast_service.h b/src/include/gnunet_multicast_service.h index c25d15dc9..f3c5b5d93 100644 --- a/src/include/gnunet_multicast_service.h +++ b/src/include/gnunet_multicast_service.h | |||
@@ -459,8 +459,6 @@ GNUNET_MULTICAST_replay_response2 (struct GNUNET_MULTICAST_ReplayHandle *rh, | |||
459 | * @param cfg Configuration to use. | 459 | * @param cfg Configuration to use. |
460 | * @param priv_key ECC key that will be used to sign messages for this | 460 | * @param priv_key ECC key that will be used to sign messages for this |
461 | * multicast session; public key is used to identify the multicast group; | 461 | * multicast session; public key is used to identify the multicast group; |
462 | * FIXME: we'll likely want to use NOT the p521 curve here, but a cheaper | ||
463 | * one in the future. | ||
464 | * @param last_fragment_id Last fragment ID to continue counting fragments from | 462 | * @param last_fragment_id Last fragment ID to continue counting fragments from |
465 | * when restarting the origin. 0 for a new group. | 463 | * when restarting the origin. 0 for a new group. |
466 | * @param join_cb Function called to approve / disapprove joining of a peer. | 464 | * @param join_cb Function called to approve / disapprove joining of a peer. |
@@ -489,6 +487,12 @@ GNUNET_MULTICAST_origin_start (const struct GNUNET_CONFIGURATION_Handle *cfg, | |||
489 | /** | 487 | /** |
490 | * Function called to provide data for a transmission from the origin to all | 488 | * Function called to provide data for a transmission from the origin to all |
491 | * members. | 489 | * members. |
490 | * FIXME: what if origin needs to pause transmission for a while? | ||
491 | * | ||
492 | * @param cls closure | ||
493 | * @param data_size number of bytes available in @a data | ||
494 | * @param data where to copy the message | ||
495 | * @return number of bytes copied to @a data? (FIXME: size_t?), or status code? | ||
492 | */ | 496 | */ |
493 | typedef int | 497 | typedef int |
494 | (*GNUNET_MULTICAST_OriginTransmitNotify) (void *cls, | 498 | (*GNUNET_MULTICAST_OriginTransmitNotify) (void *cls, |
@@ -510,8 +514,11 @@ struct GNUNET_MULTICAST_OriginMessageHandle; | |||
510 | * @param message_id Application layer ID for the message. Opaque to multicast. | 514 | * @param message_id Application layer ID for the message. Opaque to multicast. |
511 | * @param group_generation Group generation of the message. Documented in | 515 | * @param group_generation Group generation of the message. Documented in |
512 | * GNUNET_MULTICAST_MessageHeader. | 516 | * GNUNET_MULTICAST_MessageHeader. |
513 | * @param size Number of bytes to transmit. | 517 | * @param size Number of bytes to transmit. |
514 | * FIXME: Needed? The end of the message can be flagged with a last fragment flag. | 518 | * FIXME: Needed? The end of the message can be flagged with a last fragment flag. |
519 | * FIXME: what last fragment flag? OriginTransmitNotify is not that well documented... | ||
520 | * FIXME: size_t? If this is a total size, uint64_t might be better! | ||
521 | * FIXME: do we reserve "MAX" to indicate 'unknown'? | ||
515 | * @param notify Function to call to get the message. | 522 | * @param notify Function to call to get the message. |
516 | * @param notify_cls Closure for @a notify. | 523 | * @param notify_cls Closure for @a notify. |
517 | * @return NULL on error (i.e. request already pending). | 524 | * @return NULL on error (i.e. request already pending). |