PQ: update libgnunetpq implementation to avoid duplicated nullable tests and to allow for the actual field name to differ from the fname, as done for example by the Taler amounts which are split over two DB fields

1 files changed, 10 insertions, 9 deletions

diff --git a/src/include/gnunet_pq_lib.h b/src/include/gnunet_pq_lib.h
index c8a648032..d7fa793ca 100644
--- a/src/include/gnunet_pq_lib.h
+++ b/src/include/gnunet_pq_lib.h
@@ -245,15 +245,16 @@ GNUNET_PQ_query_param_uint64 (const uint64_t *x);
  * @param[out] dst where to store the result
  * @return
  *   #GNUNET_YES if all results could be extracted
- *   #GNUNET_SYSERR if a result was invalid (non-existing field or NULL)
+ *   #GNUNET_NO if the field was NULL
+ *   #GNUNET_SYSERR if a result was invalid (non-existing field)
  */
-typedef int
-(*GNUNET_PQ_ResultConverter) (void *cls,
-                              PGresult *result,
-                              int row,
-                              const char *fname,
-                              size_t *dst_size,
-                              void *dst);
+typedef enum GNUNET_GenericReturnValue
+(*GNUNET_PQ_ResultConverter)(void *cls,
+                             PGresult *result,
+                             int row,
+                             const char *fname,
+                             size_t *dst_size,
+                             void *dst);
 
 
 /**
@@ -310,7 +311,7 @@ struct GNUNET_PQ_ResultSpec
    * Where to store actual size of the result.
    */
   size_t *result_size;
-  
+
   /**
    * True if NULL is allowed for a value in the database.
    */