diff options
author | Christian Grothoff <christian@grothoff.org> | 2018-05-20 23:40:20 +0200 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2018-05-20 23:40:20 +0200 |
commit | d080cb1ed80a0e528b2b755ee48ca18cb670175e (patch) | |
tree | d8c0edab6035e4d38138b303566e972fbf8b8c5f /src/namestore/plugin_namestore_sqlite.c | |
parent | 0a8c135eedab5213b31c21b3d4b800e5f0f6041f (diff) | |
download | gnunet-d080cb1ed80a0e528b2b755ee48ca18cb670175e.tar.gz gnunet-d080cb1ed80a0e528b2b755ee48ca18cb670175e.zip |
check return values from GNSRECORD_record_serialize/size always
Diffstat (limited to 'src/namestore/plugin_namestore_sqlite.c')
-rw-r--r-- | src/namestore/plugin_namestore_sqlite.c | 9 |
1 files changed, 7 insertions, 2 deletions
diff --git a/src/namestore/plugin_namestore_sqlite.c b/src/namestore/plugin_namestore_sqlite.c index 34e548613..81391ce8a 100644 --- a/src/namestore/plugin_namestore_sqlite.c +++ b/src/namestore/plugin_namestore_sqlite.c | |||
@@ -313,7 +313,7 @@ namestore_sqlite_store_records (void *cls, | |||
313 | int n; | 313 | int n; |
314 | struct GNUNET_CRYPTO_EcdsaPublicKey pkey; | 314 | struct GNUNET_CRYPTO_EcdsaPublicKey pkey; |
315 | uint64_t rvalue; | 315 | uint64_t rvalue; |
316 | size_t data_size; | 316 | ssize_t data_size; |
317 | 317 | ||
318 | memset (&pkey, | 318 | memset (&pkey, |
319 | 0, | 319 | 0, |
@@ -332,6 +332,11 @@ namestore_sqlite_store_records (void *cls, | |||
332 | UINT64_MAX); | 332 | UINT64_MAX); |
333 | data_size = GNUNET_GNSRECORD_records_get_size (rd_count, | 333 | data_size = GNUNET_GNSRECORD_records_get_size (rd_count, |
334 | rd); | 334 | rd); |
335 | if (data_size < 0) | ||
336 | { | ||
337 | GNUNET_break (0); | ||
338 | return GNUNET_SYSERR; | ||
339 | } | ||
335 | if (data_size > 64 * 65536) | 340 | if (data_size > 64 * 65536) |
336 | { | 341 | { |
337 | GNUNET_break (0); | 342 | GNUNET_break (0); |
@@ -352,7 +357,7 @@ namestore_sqlite_store_records (void *cls, | |||
352 | data_size, | 357 | data_size, |
353 | data); | 358 | data); |
354 | if ( (ret < 0) || | 359 | if ( (ret < 0) || |
355 | (data_size != (size_t) ret) ) | 360 | (data_size != ret) ) |
356 | { | 361 | { |
357 | GNUNET_break (0); | 362 | GNUNET_break (0); |
358 | return GNUNET_SYSERR; | 363 | return GNUNET_SYSERR; |