diff options
author | Christian Grothoff <christian@grothoff.org> | 2015-03-01 22:54:42 +0000 |
---|---|---|
committer | Christian Grothoff <christian@grothoff.org> | 2015-03-01 22:54:42 +0000 |
commit | d9f888cdbb23b78f5936628d3adb7a77492b499c (patch) | |
tree | 8cae17769716b4030aaa872ac7a35e8888ef52e5 /src/transport/test_plugin_transport.c | |
parent | 8ea46cc3c928bd5f74859dc74f305c94b687aad2 (diff) | |
download | gnunet-d9f888cdbb23b78f5936628d3adb7a77492b499c.tar.gz gnunet-d9f888cdbb23b78f5936628d3adb7a77492b499c.zip |
major code cleanup in UDP plugin, seems to also fix bugs; specifically, I think I fixed a leak
Diffstat (limited to 'src/transport/test_plugin_transport.c')
-rw-r--r-- | src/transport/test_plugin_transport.c | 35 |
1 files changed, 20 insertions, 15 deletions
diff --git a/src/transport/test_plugin_transport.c b/src/transport/test_plugin_transport.c index df7c7b23f..84c9362e9 100644 --- a/src/transport/test_plugin_transport.c +++ b/src/transport/test_plugin_transport.c | |||
@@ -342,16 +342,16 @@ test_addr_string (void *cls, | |||
342 | if (NULL == w->addrstring) | 342 | if (NULL == w->addrstring) |
343 | { | 343 | { |
344 | GNUNET_break(0); | 344 | GNUNET_break(0); |
345 | GNUNET_log(GNUNET_ERROR_TYPE_ERROR, | 345 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
346 | "Plugin cannot convert address to string!\n"); | 346 | "Plugin cannot convert address to string!\n"); |
347 | end_badly_now (); | 347 | end_badly_now (); |
348 | return; | 348 | return; |
349 | } | 349 | } |
350 | GNUNET_log(GNUNET_ERROR_TYPE_INFO, | 350 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, |
351 | "Plugin added address `%s'\n", | 351 | "Plugin added address `%s'\n", |
352 | w->addrstring); | 352 | w->addrstring); |
353 | GNUNET_log(GNUNET_ERROR_TYPE_INFO, | 353 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, |
354 | "Testing address_to_string: OK\n"); | 354 | "Testing address_to_string: OK\n"); |
355 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, | 355 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, |
356 | "Testing: string_to_address \n"); | 356 | "Testing: string_to_address \n"); |
357 | s2a = NULL; | 357 | s2a = NULL; |
@@ -385,14 +385,16 @@ test_addr_string (void *cls, | |||
385 | } | 385 | } |
386 | else if (0 != memcmp (s2a, w->address->address, s2a_len)) | 386 | else if (0 != memcmp (s2a, w->address->address, s2a_len)) |
387 | { | 387 | { |
388 | GNUNET_log(GNUNET_ERROR_TYPE_ERROR, | 388 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
389 | "Plugin creates different address length when converting back and forth %i!\n", | 389 | "Plugin creates different address length when converting back and forth %i!\n", |
390 | memcmp (s2a, w->address->address, s2a_len)); | 390 | memcmp (s2a, |
391 | w->address->address, | ||
392 | s2a_len)); | ||
391 | } | 393 | } |
392 | else | 394 | else |
393 | { | 395 | { |
394 | GNUNET_log(GNUNET_ERROR_TYPE_INFO, | 396 | GNUNET_log (GNUNET_ERROR_TYPE_INFO, |
395 | "Testing string_to_address: OK\n"); | 397 | "Testing string_to_address: OK\n"); |
396 | } | 398 | } |
397 | GNUNET_free(s2a); | 399 | GNUNET_free(s2a); |
398 | 400 | ||
@@ -406,10 +408,13 @@ test_addr_string (void *cls, | |||
406 | &address_pretty_printer_cb, w); | 408 | &address_pretty_printer_cb, w); |
407 | 409 | ||
408 | if (GNUNET_OK != | 410 | if (GNUNET_OK != |
409 | api->check_address (api->cls, w->address->address, w->address->address_length)) | 411 | api->check_address (api->cls, |
412 | w->address->address, | ||
413 | w->address->address_length)) | ||
410 | { | 414 | { |
411 | GNUNET_break(0); | 415 | GNUNET_break (0); |
412 | GNUNET_log(GNUNET_ERROR_TYPE_ERROR, "Plugin refuses added address!\n"); | 416 | GNUNET_log (GNUNET_ERROR_TYPE_ERROR, |
417 | "Plugin refuses added address!\n"); | ||
413 | end_badly_now (); | 418 | end_badly_now (); |
414 | return; | 419 | return; |
415 | } | 420 | } |