diff options
-rw-r--r-- | src/include/gnunet_reclaim_attribute_lib.h | 6 | ||||
-rw-r--r-- | src/include/gnunet_reclaim_attribute_plugin.h | 10 |
2 files changed, 14 insertions, 2 deletions
diff --git a/src/include/gnunet_reclaim_attribute_lib.h b/src/include/gnunet_reclaim_attribute_lib.h index 34429da51..8476e77fc 100644 --- a/src/include/gnunet_reclaim_attribute_lib.h +++ b/src/include/gnunet_reclaim_attribute_lib.h | |||
@@ -348,6 +348,12 @@ GNUNET_RECLAIM_ATTRIBUTE_number_to_typename (uint32_t type); | |||
348 | 348 | ||
349 | /** | 349 | /** |
350 | * Get required size for serialization buffer | 350 | * Get required size for serialization buffer |
351 | * FIXME: | ||
352 | * 1. The naming convention is violated here. | ||
353 | * It should GNUNET_RECLAIM_ATTRIBUTE_<lowercase from here>. | ||
354 | * It might make sense to refactor attestations into a separate folder. | ||
355 | * 2. The struct should be called GNUNET_RECLAIM_ATTESTATION_Data or | ||
356 | * GNUNET_RECLAIM_ATTRIBUTE_Attestation depending on location in source. | ||
351 | * | 357 | * |
352 | * @param attr the attestation to serialize | 358 | * @param attr the attestation to serialize |
353 | * @return the required buffer size | 359 | * @return the required buffer size |
diff --git a/src/include/gnunet_reclaim_attribute_plugin.h b/src/include/gnunet_reclaim_attribute_plugin.h index bdd815dcf..e61cca5b2 100644 --- a/src/include/gnunet_reclaim_attribute_plugin.h +++ b/src/include/gnunet_reclaim_attribute_plugin.h | |||
@@ -136,8 +136,14 @@ struct GNUNET_RECLAIM_ATTRIBUTE_PluginFunctions | |||
136 | GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename; | 136 | GNUNET_RECLAIM_ATTRIBUTE_NumberToTypenameFunction number_to_typename; |
137 | 137 | ||
138 | /** | 138 | /** |
139 | * Attestation Conversion to string. | 139 | * FIXME: It is odd that attestation functions are withing the attribute |
140 | */ | 140 | * plugin. An attribute type may be backed by an attestation, but not |
141 | * necessarily. | ||
142 | * Maybe it would make more sense to refactor this into an attestation | ||
143 | * plugin? | ||
144 | * | ||
145 | * Attestation Conversion to string. | ||
146 | */ | ||
141 | GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest; | 147 | GNUNET_RECLAIM_ATTRIBUTE_ValueToStringFunction value_to_string_attest; |
142 | 148 | ||
143 | /** | 149 | /** |