libextractor

GNU libextractor
Log | Files | Refs | Submodules | README | LICENSE

commit 687420ec088ed4b4d13182a59715515f0f2673dc
parent 9d3a1c70a327acc057060a64ed7280d5177af712
Author: Christian Grothoff <christian@grothoff.org>
Date:   Sun, 12 Apr 2009 18:02:27 +0000

Hi Christian

In my testing of exiv2extractor.cc when linking with the system libexiv2,
with the symbol SUPPRESS_WARNINGS undefined, I found exceptions were being
thrown, due to the names of some of the tags changing since 0.7. Here are
the changes required:

--- exiv2extractor.cc    2009-04-11 17:47:27.000000000 -0700
+++ exiv2extractor.cc    2009-04-12 10:35:09.000000000 -0700
@@ -189,7 +188,7 @@
         // Flash bias
         // Todo: Implement this for other cameras
         newResult = addExiv2Tag(exifData,
-                                "Exif.CanonCs2.FlashBias",
+                                "Exif.CanonSi.FlashBias",
                                 EXTRACTOR_FLASH_BIAS,
                                 result);
         if (newResult == result) {
@@ -273,7 +272,7 @@
         // Macro mode
         // Todo: Implement this for other cameras
         newResult = addExiv2Tag(exifData,
-                                "Exif.CanonCs1.Macro",
+                                "Exif.CanonCs.Macro",
                                 EXTRACTOR_MACRO_MODE,
                                 result);
         if (newResult == result) {
@@ -299,7 +298,7 @@
         // Image quality setting (compression)
         // Todo: Implement this for other cameras
         newResult = addExiv2Tag(exifData,
-                                "Exif.CanonCs1.Quality",
+                                "Exif.CanonCs.Quality",
                                 EXTRACTOR_IMAGE_QUALITY,
                                 result);
         if (newResult == result) {
@@ -369,7 +368,7 @@
         // Todo: Implement this for other cameras
 
         newResult = addExiv2Tag(exifData,
-                                "Exif.CanonCs2.WhiteBalance",
+                                "Exif.CanonSi.WhiteBalance",
                                 EXTRACTOR_WHITE_BALANCE,
                                 result);
         if (newResult == result) {

Thanks for the help!

Dave


Diffstat:
Msrc/plugins/exiv2/exiv2extractor.cc | 6+++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/plugins/exiv2/exiv2extractor.cc b/src/plugins/exiv2/exiv2extractor.cc @@ -189,7 +189,7 @@ extern "C" { // Flash bias // Todo: Implement this for other cameras newResult = addExiv2Tag(exifData, - "Exif.CanonCs2.FlashBias", + "Exif.CanonSi.FlashBias", EXTRACTOR_FLASH_BIAS, result); if (newResult == result) { @@ -299,7 +299,7 @@ extern "C" { // Image quality setting (compression) // Todo: Implement this for other cameras newResult = addExiv2Tag(exifData, - "Exif.CanonCs1.Quality", + "Exif.CanonCs.Quality", EXTRACTOR_IMAGE_QUALITY, result); if (newResult == result) { @@ -369,7 +369,7 @@ extern "C" { // Todo: Implement this for other cameras newResult = addExiv2Tag(exifData, - "Exif.CanonCs2.WhiteBalance", + "Exif.CanonSi.WhiteBalance", EXTRACTOR_WHITE_BALANCE, result); if (newResult == result) {