libextractor

commit a200bd811be7c4e413671d219bff6f73a9c52c7a
parent 191fe63873d35ec3a607e4f920d3dfb6d2e2672d
Author: Heikki Lindholm <holin@iki.fi>
Date:   Wed, 26 Dec 2007 13:20:14 +0000

add some notes


Diffstat:
M
src/plugins/qtextractor.c
 | 
14
++++++++++----

1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/src/plugins/qtextractor.c b/src/plugins/qtextractor.c
@@ -725,7 +725,12 @@ static const char *languages[] = {
   "JavaneseRom",
 };
 
-
+/*
+ * see http://developer.apple.com/documentation/QuickTime/QTFF/QTFFChap2/chapter
+_3_section_2.html
+ *   "User Data Text Strings and Language Codes"
+ * TODO: make conformant
+ */
 static int
 processTextTag (const char *input,
                 size_t size,
@@ -752,9 +757,7 @@ processTextTag (const char *input,
   if (lang >= sizeof (languages) / sizeof (char *))
     return 0;                   /* invalid */
   addKeyword (EXTRACTOR_LANGUAGE, languages[lang], list);
-  /* TODO: what is the character set encoding here?
-     For now, let's assume it is Utf-8 (cannot find
-     anything in the public documentation) */
+
   meta = malloc (len + 1);
   memcpy (meta, &txt[1], len);
   meta[len] = '\0';
@@ -927,6 +930,9 @@ static ITTagConversionEntry it_to_extr_table[] = {
   {NULL, EXTRACTOR_UNKNOWN},
 };
 
+/* NOTE: iTunes tag processing should, in theory, be limited to iTunes
+ * file types (from ftyp), but, in reality, it seems that there are other
+ * files, like 3gpp, out in the wild with iTunes tags. */
 static int
 iTunesTagHandler (const char *input,
            size_t size, size_t pos, struct EXTRACTOR_Keywords **list)