libextractor

commit cba2e96b5f5e464fa77ee22d62fd82b4fc3f0d07
parent 33a031d7970bcb4a9dad4a3caa521b74299496db
Author: Christian Grothoff <christian@grothoff.org>
Date:   Fri, 30 Oct 2009 19:12:07 +0000

fixing leaks, improving style


Diffstat:
M
src/plugins/ffmpeg/libavutil/lzo.c
 | 
1
+
M
src/plugins/ffmpeg/libswscale/swscale-example.c
 | 
3
++-
M
src/plugins/ffmpeg/tools/qt-faststart.c
 | 
1
+
M
src/plugins/ffmpeg/tools/trasher.c
 | 
2
+-
M
src/plugins/hash/rmd160extractor.c
 | 
53
+++++++++--------------------------------------------
M
src/plugins/pdf/XRef.cc
 | 
1
+

6 files changed, 15 insertions(+), 46 deletions(-)
diff --git a/src/plugins/ffmpeg/libavutil/lzo.c b/src/plugins/ffmpeg/libavutil/lzo.c
@@ -268,6 +268,7 @@ STOP_TIMER("lzod")
         av_log(NULL, AV_LOG_ERROR, "decompression incorrect\n");
     else
         av_log(NULL, AV_LOG_ERROR, "decompression ok\n");
+    fclose (in);
     return 0;
 }
 #endif
diff --git a/src/plugins/ffmpeg/libswscale/swscale-example.c b/src/plugins/ffmpeg/libswscale/swscale-example.c
@@ -224,6 +224,7 @@ int main(int argc, char **argv){
 #endif
 
     selfTest(src, stride, W, H);
-
+    free (rgb_data);
+    free (data);
     return 123;
 }
diff --git a/src/plugins/ffmpeg/tools/qt-faststart.c b/src/plugins/ffmpeg/tools/qt-faststart.c
@@ -257,6 +257,7 @@ int main(int argc, char *argv[])
     if (!outfile) {
         perror(argv[2]);
         fclose(outfile);
+	fclose(infile);
         free(moov_atom);
         return 1;
     }
diff --git a/src/plugins/ffmpeg/tools/trasher.c b/src/plugins/ffmpeg/tools/trasher.c
@@ -65,6 +65,6 @@ int main(int argc, char** argv)
             fwrite(&val, 1, 1, f);
         }
     }
-
+    fclose (f);
     return 0;
 }
diff --git a/src/plugins/hash/rmd160extractor.c b/src/plugins/hash/rmd160extractor.c
@@ -74,8 +74,6 @@ typedef struct rmd160_object *RMD160;
 #define RMD160_INIT3		0x10325476UL
 #define RMD160_INIT4		0xc3d2e1f0UL
 
-#define FUNCTION_NAME "rmd160_calc"
-
 static int
 _rmd160_calc (rmd160uint32 * state, rmd160uint32 * data)
 {
@@ -319,9 +317,6 @@ _rmd160_calc (rmd160uint32 * state, rmd160uint32 * data)
   return RMD160_OK;
 }
 
-#undef FUNCTION_NAME
-
-#define FUNCTION_NAME "rmd160_append"
 
 static int
 rmd160_append (RMD160 arg_obj, size_t arg_len, const unsigned char *arg_data)
@@ -435,9 +430,6 @@ rmd160_append (RMD160 arg_obj, size_t arg_len, const unsigned char *arg_data)
 
 }
 
-#undef FUNCTION_NAME
-
-#define FUNCTION_NAME "rmd160_destroy"
 
 static int
 rmd160_destroy (RMD160 ptr)
@@ -450,9 +442,7 @@ rmd160_destroy (RMD160 ptr)
   return RMD160_OK;
 }
 
-#undef FUNCTION_NAME
 
-#define FUNCTION_NAME "rmd160_copy"
 
 static RMD160
 rmd160_copy (RMD160 target_p, RMD160 source_p)
@@ -511,11 +501,7 @@ rmd160_copy (RMD160 target_p, RMD160 source_p)
   return target_p;
 }
 
-#undef FUNCTION_NAME
-
-
 
-#define FUNCTION_NAME "rmd160_sum_words"
 
 static rmd160uint32 *
 rmd160_sum_words (RMD160 arg_handle, rmd160uint32 * arg_result_p)
@@ -563,54 +549,33 @@ rmd160_sum_words (RMD160 arg_handle, rmd160uint32 * arg_result_p)
 
 }
 
-#undef FUNCTION_NAME
 
 
-
-#define FUNCTION_NAME "rmd160_sum_bytes"
-
-static unsigned char *
-rmd160_sum_bytes (RMD160 arg_handle, unsigned char *arg_result_p)
+static void
+rmd160_sum_bytes (RMD160 arg_handle, unsigned char *result_p)
 {
   rmd160uint32 temp[5];
-
   rmd160uint32 *ptemp;
-
   unsigned char *result_p;
 
-
-  if (!(result_p = arg_result_p))
-    {
-      if (!(result_p = (unsigned char *) malloc (20)))
-        return NULL;
-    }
-
   if (!rmd160_sum_words (arg_handle, temp))
-    {
-      if (!arg_result_p)
-        free (result_p);
-      return NULL;
-    }
+    return;    
 
   ptemp = temp;
   {
     int i;
     for (i = 0; i < 5; ++i)
       {
-        register rmd160uint32 w;
-        *(arg_result_p++) = 0xff & (w = *ptemp);
-        *(arg_result_p++) = 0xff & (w >> 8);
-        *(arg_result_p++) = 0xff & (w >> 16);
-        *(arg_result_p++) = 0xff & (w >> 24);
+	rmd160uint32 w;
+        *(result_p++) = 0xff & (w = *ptemp);
+        *(result_p++) = 0xff & (w >> 8);
+        *(result_p++) = 0xff & (w >> 16);
+        *(result_p++) = 0xff & (w >> 24);
         ++ptemp;
       }
   }
-
-  return arg_result_p;
-
 }
 
-#undef FUNCTION_NAME
 
 
 static struct EXTRACTOR_Keywords *
@@ -619,7 +584,7 @@ addKeyword (EXTRACTOR_KeywordList * oldhead,
 {
 
   EXTRACTOR_KeywordList *keyword;
-  keyword = (EXTRACTOR_KeywordList *) malloc (sizeof (EXTRACTOR_KeywordList));
+  keyword = malloc (sizeof (EXTRACTOR_KeywordList));
   keyword->next = oldhead;
   keyword->keyword = strdup (phrase);
   keyword->keywordType = type;
diff --git a/src/plugins/pdf/XRef.cc b/src/plugins/pdf/XRef.cc
@@ -882,6 +882,7 @@ Object *XRef::fetch(int num, int gen, Object *obj) {
     if (!obj1.isInt() || obj1.getInt() != num ||
 	!obj2.isInt() || obj2.getInt() != gen ||
 	!obj3.isCmd("obj")) {
+      delete parser;
       goto err;
     }
 #ifndef NO_DECRYPTION