libmicrohttpd

commit 194d72e1f9628d9dd3e732ef2e199f7d4c43afd6
parent b357bbaa6fcedfa43af7e2549535112468bde41b
Author: Christian Grothoff <christian@grothoff.org>
Date:   Wed, 16 Nov 2016 10:07:36 +0100

indeed this can happen with the fast path where we call the idle handler in a special place just after sending the header, and thus might call it twice for the same connection in the same event loop run, thereby possibly entering cleanup twice, causing trouble; retracting FIXME

Diffstat:
M
src/microhttpd/connection.c
 | 
3
---

1 file changed, 0 insertions(+), 3 deletions(-)
diff --git a/src/microhttpd/connection.c b/src/microhttpd/connection.c
@@ -2664,9 +2664,6 @@ cleanup_connection (struct MHD_Connection *connection)
 {
   struct MHD_Daemon *daemon = connection->daemon;
 
-  /* FIXME: when can this flag ever be needed? Sounds like we should
-     avoid this happening in the first place. Also, could there then
-     not be a race in this case? */
   if (connection->in_cleanup)
     return; /* Prevent double cleanup. */
   connection->in_cleanup = true;