libmicrohttpd

commit 3a02f18ca6a66997614cebf1231c86ad33148ad2
parent 21cdab14f8c314dc44a90e3207fba7f4fc3f838c
Author: Evgeny Grin (Karlson2k) <k2k@narod.ru>
Date:   Sun, 17 Oct 2021 13:57:22 +0300

Simplified connection.c code: reused error reply function

Diffstat:
M
src/microhttpd/connection.c
 | 
29
++++-------------------------

1 file changed, 4 insertions(+), 25 deletions(-)
diff --git a/src/microhttpd/connection.c b/src/microhttpd/connection.c
@@ -3467,32 +3467,11 @@ parse_connection_headers (struct MHD_Connection *connection)
     connection->state = MHD_CONNECTION_FULL_REQ_RECEIVED;
 #ifdef HAVE_MESSAGES
     MHD_DLOG (connection->daemon,
-              _ ("Received HTTP 1.1 request without `Host' header.\n"));
+              _ ("Received HTTP/1.1 request without `Host' header.\n"));
 #endif
-    mhd_assert (NULL == connection->response);
-    response =
-      MHD_create_response_from_buffer (MHD_STATICSTR_LEN_ (REQUEST_LACKS_HOST),
-                                       REQUEST_LACKS_HOST,
-                                       MHD_RESPMEM_PERSISTENT);
-    if (NULL == response)
-    {
-      /* can't even send a reply, at least close the connection */
-      CONNECTION_CLOSE_ERROR (connection,
-                              _ (
-                                "Closing connection (failed to create response)."));
-      return;
-    }
-    iret = MHD_queue_response (connection,
-                               MHD_HTTP_BAD_REQUEST,
-                               response);
-    MHD_destroy_response (response);
-    if (MHD_NO == iret)
-    {
-      /* can't even send a reply, at least close the connection */
-      CONNECTION_CLOSE_ERROR (connection,
-                              _ (
-                                "Closing connection (failed to queue response)."));
-    }
+    transmit_error_response_static (connection,
+                                    MHD_HTTP_BAD_REQUEST,
+                                    REQUEST_LACKS_HOST);
     return;
   }